[Freeciv-Dev] [patch #7957] README.graphics typofix "form" -> "from"

2016-11-07 Thread Marko Lindqvist 
URL:
  

 Summary: README.graphics typofix "form" -> "from"
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 07 Nov 2016 10:05:58 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:





___

File Attachments:


---
Date: Mon 07 Nov 2016 10:05:58 AM EET  Name: OffsetForm.patch  Size: 828B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25268] actiontools.h: warning: type qualifiers ignored on function return type

2016-11-07 Thread Marko Lindqvist 
URL:
  

 Summary: actiontools.h: warning: type qualifiers ignored on
function return type
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 07 Nov 2016 10:55:33 AM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

In file included from ../../src/server/actiontools.c:27:
../../src/server/actiontools.h:81: warning: type qualifiers ignored on
function return type
../../src/server/actiontools.c:901: warning: type qualifiers ignored on
function return type
In file included from ../../src/server/cityturn.c:36:
../../src/server/actiontools.h:81: warning: type qualifiers ignored on
function return type
In file included from ../../src/server/diplomats.c:38:
../../src/server/actiontools.h:81: warning: type qualifiers ignored on
function return type
In file included from ../../src/server/unithand.c:51:
../../src/server/actiontools.h:81: warning: type qualifiers ignored on
function return type
In file included from ../../src/server/unittools.c:61:
../../src/server/actiontools.h:81: warning: type qualifiers ignored on
function return type




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25270] Crash in can_extras_coexist

2016-11-07 Thread mir3x 
URL:
  

 Summary: Crash in can_extras_coexist
 Project: Freeciv
Submitted by: mir3x
Submitted on: Mon 07 Nov 2016 12:07:03 PM CET
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.6, 3.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

Savegame attached, just click end turn in qt-client.

Qt client updates menu when unit label changes to get current tooltips for
unit label, it doesnt crash in gtk.

#0  0x00663891 in can_extras_coexist (pextra1=0x8c0f80 ,
pextra2=0x0) at extras.c:691
691   return !BV_ISSET(pextra1->conflicts, extra_index(pextra2));
[Current thread is 1 (Thread 0x7f9a3d710840 (LWP 16575))]
(gdb) bt
#0  0x00663891 in can_extras_coexist (pextra1=0x8c0f80 ,
pextra2=0x0) at extras.c:691
#1  0x0074d08b in can_unit_do_activity_targeted_at (punit=0x18cddb0,
activity=ACTIVITY_IRRIGATE, 
target=0x8c0f80 , ptile=0x18166e0) at unit.c:915
#2  0x0074cf5e in can_unit_do_activity_targeted (punit=0x18cddb0,
activity=ACTIVITY_IRRIGATE, target=0x8c0f80 )
at unit.c:892
#3  0x0074cf2e in can_unit_do_activity (punit=0x18cddb0,
activity=ACTIVITY_IRRIGATE) at unit.c:881
#4  0x0075141c in can_units_do_activity (punits=0x2568450,
activity=ACTIVITY_IRRIGATE) at unitlist.c:117
#5  0x004dc1e7 in mr_menu::menus_sensitive (this=0x13064d0) at
menu.cpp:1686
#6  0x004c8cbd in update_unit_info_label (punitlist=0x2568450) at
mapview.cpp:999





___

File Attachments:


---
Date: Mon 07 Nov 2016 12:07:03 PM CET  Name: dcc.sav.bz2  Size: 12kB   By:
mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6356] Make local building requirements city independent

2016-11-07 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #4, patch #6356 (project freeciv):

> What was the original motivation?
The original motivation was to allow a building being required even if it
didn't exist in the city yet. An action enabler allowing a unit to do "Help
Wonder" can't demand that the building it is allowed to help build already is
built in the city.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25259] autoattack: a transport will attack before its cargo

2016-11-07 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #7, bug #25259 (project freeciv):

> Won't this make cargo (greater unit_transport_depth()) sort later in the
list (and hence be used last), not earlier?
It would if p1 and q1 switched place.

Want to optimize the sorting of the attacker list your self or should I?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7958] autoattack: restore player ability to specify who can autoattack

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: autoattack: restore player ability to specify who
can autoattack
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 01:27:03 PM UTC
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 
 Contains string changes: None

___

Details:

In patch #7942 Jacob Nevins  said:
> (BTW, since you're working on autoattack, I don't suppose you fancy
restoring the ability for the player to specify which units can autoattack?
Last time I looked into it, there didn't seem to be any good reason for this
to have been removed. I might actually use autoattack if I could control it
better. Obviously that's a discussion for another ticket.)

I have been thinking about it. The current behavior is useful as an
alternative to enabling ZoC. A more detailed/realistic ruleset may wish to
give the player control over what units may autoattack. I therefore suggest
giving autoattack three states: disabled, player controlled and enabled.
Adding a state could also be an opportunity to rename it to something like
"initiative". This would reflect that it isn't mere unit automation[1].

[1] The autoattack setting can, unlike a client side order, make a unit attack
an enemy unit in the middle of the enemy unit's order execution. This can be
seen as a representation of a unit acting on its own initiative (3rd and 4th
generation war) rather than waiting for orders from the top (1st and 2nd
generation war).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7942] autoattack: have the best attacker go first

2016-11-07 Thread Sveinung Kvilhaugsvik 
Update of patch #7942 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

> I don't suppose you fancy restoring the ability for the player to specify
which units can autoattack?
Is not patch #7958

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25272] ai: hostile actors are seen as diplomats

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: ai: hostile actors are seen as diplomats
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 01:35:17 PM UTC
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

Freeciv 3.0 has hostile enabler controlled actions that aren't diplomatic. The
function is_city_surrounded_by_our_spies() is used when the Diplomat/Spy
control code checks if a new Diplomat/Spy is needed.



___

File Attachments:


---
Date: Mon 07 Nov 2016 01:35:17 PM UTC  Name: hostile-diplomat.patch  Size: 2kB
  By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7959] Declare all GameLoss units autoattack Provoking

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Declare all GameLoss units autoattack Provoking
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 02:03:07 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

It is, in all bundled rulesets, reasonable to attack a GamleLoss unit at once
rather than hoping that it will attack and thus be defeated.



___

File Attachments:


---
Date: Mon 07 Nov 2016 02:03:07 PM UTC  Name:
0006-Declare-all-GameLoss-units-autoattack-Provoking.patch  Size: 4kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25268] actiontools.h: warning: type qualifiers ignored on function return type

2016-11-07 Thread Sveinung Kvilhaugsvik 
Update of bug #25268 (project freeciv):

Category:None => general
  Status:None => In Progress
 Assigned to:None => sveinung   
 Release: => TRUNK  
Operating System:None => Any
 Planned Release: => 3.0.0  
 Contains string changes:None => No 

___

Follow-up Comment #1:

Does the attacked patch make the warning go away?

(file #29323)
___

Additional Item Attachment:

File name: 0007-An-act_prob-struct-isn-t-a-pointer.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7960] Make city conquest able to cause an incident

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Make city conquest able to cause an incident
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 03:08:36 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:





___

File Attachments:


---
Date: Mon 07 Nov 2016 03:08:36 PM UTC  Name:
0008-Make-city-conquest-able-to-cause-an-incident.patch  Size: 3kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7961] Hexemplio beta roads

2016-11-07 Thread Marko Lindqvist 
URL:
  

 Summary: Hexemplio beta roads
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 07 Nov 2016 06:07:01 PM EET
Category: art
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0-beta1, 3.0.0
 Contains string changes: None

___

Details:

Updated hexemplio roads setup from GriffonSpade. TRUNK version attached.



___

File Attachments:


---
Date: Mon 07 Nov 2016 06:07:01 PM EET  Name: HexemplioBetaRoads.patch  Size:
15kB   By: cazfi


---
Date: Mon 07 Nov 2016 06:07:01 PM EET  Name: roads.png  Size: 9kB   By: cazfi


---
Date: Mon 07 Nov 2016 06:07:01 PM EET  Name: roads-rails.png  Size: 11kB   By:
cazfi


---
Date: Mon 07 Nov 2016 06:07:01 PM EET  Name: roads-maglevs.png  Size: 29kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7961] Hexemplio beta roads

2016-11-07 Thread Marko Lindqvist 
Follow-up Comment #1, patch #7961 (project freeciv):

S2_6 version

(file #29330)
___

Additional Item Attachment:

File name: HexemplioBetaRoads-S2_6.patch  Size:14 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6881] Reconcile hexemplio with latest Ampliohexbig

2016-11-07 Thread Marko Lindqvist 
Update of patch #6881 (project freeciv):

  Depends on: => patch #7961


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25234] action enabler side effect: "Conquer City" on "Paradrop Unit"

2016-11-07 Thread Sveinung Kvilhaugsvik 
Update of bug #25234 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => sveinung   
Operating System:None => Any
 Planned Release: => 3.0.0  
 Contains string changes:None => No 

___

Follow-up Comment #1:

Use the old conquest rules for now.

(file #29331)
___

Additional Item Attachment:

File name: 0009-Paradrop-Unit-Don-t-rely-on-Conquer-City.patch Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25273] Qt client - dont update unit label on update_unit_info_label

2016-11-07 Thread mir3x 
URL:
  

 Summary: Qt client - dont update unit label on
update_unit_info_label
 Project: Freeciv
Submitted by: mir3x
Submitted on: Mon 07 Nov 2016 08:04:04 PM CET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0
 Contains string changes: No

___

Details:

Moved update to real_menus_update.



___

File Attachments:


---
Date: Mon 07 Nov 2016 08:04:04 PM CET  Name: qt_dup_unit_label.patch  Size:
963B   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7947] Unitclass helptext about paradrop abilitity unterminated

2016-11-07 Thread Marko Lindqvist 
Update of patch #7947 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7962] A nation contradicts its group's absence

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: A nation contradicts its group's absence
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 09:49:08 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:





___

File Attachments:


---
Date: Mon 07 Nov 2016 09:49:08 PM UTC  Name:
0013-A-nation-contradicts-its-group-s-absence.patch  Size: 2kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7963] Prepare for ruleset derived action data

2016-11-07 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Prepare for ruleset derived action data
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 07 Nov 2016 10:17:07 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

Introduce the new function actions_rs_pre_san_gen(). It generates data that is
based on the loaded ruleset but needed before ruleset sanity checking and
ruleset compatibility upgrade.



___

File Attachments:


---
Date: Mon 07 Nov 2016 10:17:07 PM UTC  Name:
0012-Prepare-for-ruleset-derived-action-data.patch  Size: 3kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6797] Comment out setup_canvas_color_for_state()

2016-11-07 Thread Marko Lindqvist 
Update of patch #6797 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7950] Hexemplio beta unitcost

2016-11-07 Thread Marko Lindqvist 
Update of patch #7950 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24642] Supported units and present units have different size canvas on citydlg

2016-11-07 Thread Marko Lindqvist 
Update of bug #24642 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7948] Ask user to install correct mixer

2016-11-07 Thread Marko Lindqvist 
Follow-up Comment #1, patch #7948 (project freeciv):

That code is about build-time lack of mixer -> it makes no sense to try to
figure out which mixer was selected at build time when we know that no mixer
was selected.

Attached patch version just changes the message to recommend SDL2_mixer
(current default) instead of SDL_mixer.

(file #29335)
___

Additional Item Attachment:

File name: AdvertiseSdl2Mixer-2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7949] Clean out remaining radar sprite code

2016-11-07 Thread Marko Lindqvist 
Update of patch #7949 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev