Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Michael T. Pope 
On Sun, 2 Aug 2015 12:32:28 +0200
win...@genial.ms wrote:
> I did cherry-pick the relevant commits for 0.11.5 and
> pushed a stable and a tentative branch.
> Please, help testing these to ensure we don't have another
> lurking bug!

The stable branch survives several moves and load/save.  But then so did
0.11.4 with the way I play.  The upload is proceeding.

> I also updated the wiki, copied the empty template for later
> and added text to the 0.11.5 page. Please, do proofreading!
> I'm not sure if a mention of the Windows problems BR#793
> and/or BR#2328/BR#2729 in the common problems section is
> necessary, but there had been none in 0.11.4 page, too.

Having them on the bug report page is adequate.  I have proofread and
just explained the region bug a little more.

Cheers,
Mike Pope


pgphjDRr993yw.pgp
Description: OpenPGP digital signature
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Michael T. Pope 
On Sun, 2 Aug 2015 21:19:12 +0200
win...@genial.ms wrote:
> I thought again about the error handling strategy for BR#2885,
> as there are surely some people out there trying to continue
> their broken savegame.
> 
> At first I tried to just catch the NPE in MapViewer (git.0129a906)
> and this worked surprisingly well for such a simple fix.
> I could play several turns without a freeze.

Sooner or later, the null regions will get you.  The assumption that
Tile.region != null is widespread.  The only reliable fix would be to
rebuild them at load time. That *might* have been possible,
but it would certainly have required some complex code in a fairly
sensitive area.  I was doubtful it could be made right quickly, and
all that time more broken games would be being created.  So I made the
call to pull 0.11.4. 

> Something needs to be done though, so I think the best solution
> is to simply follow "fail early, fail hard" and check the Region
> at load time. Maybe put up a warning dialog if you are inclined
> to program one? And call into FreeColClient.fatal to alert people
> of the broken savegame.

Its slightly more complex than that.  On input the reader made some
placeholder regions (this is normal practice for many freecol objects as
we can not always guarantee they are defined before used), however the
placeholders were later (correctly) cleaned up as being undefined, and
there was even logging present showing this happening.  So it is not quite
as simple as checking for null region on read, you have to wait until the
dust has settled.  However, we *do* have a post-read checkup pass --- you
will notice that some objects have a checkIntegrity routine.  We could
indeed put a null region check into Tile.checkIntegrity.  You may ask why
we do not already have one?  ATM the practice with the checkIntegrity
routines is to only check something we can actually fix (the routine
might be better named checkAndOptionallyFixIntegrity:-), because there
are so many other things we can not.

Anyway, starting on the release now.

Cheers,
Mike Pope


pgpGiU63nSqtQ.pgp
Description: OpenPGP digital signature
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Caleb Williams 
I've updated the website for the 0.11.5 release in the repository.

Best wishes,

Caleb
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread winter 
Hi,

I thought again about the error handling strategy for BR#2885,
as there are surely some people out there trying to continue
their broken savegame.

At first I tried to just catch the NPE in MapViewer (git.0129a906)
and this worked surprisingly well for such a simple fix.
I could play several turns without a freeze.
Testing for type!=null in Region.getLabel would prevent even more
problems though, for example, when opening the tile info.
But its ultimately bad, because people would have it easier to
continue playing a broken savegame and loose more time when it
finally does break in some other way.

Next solution would be to regenerate broken data on game load,
but that might be too much work for too few broken savegames and
could still produce a fragile game.

Something needs to be done though, so I think the best solution
is to simply follow "fail early, fail hard" and check the Region
at load time. Maybe put up a warning dialog if you are inclined
to program one? And call into FreeColClient.fatal to alert people
of the broken savegame.


Regards,

wintertime

--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Caleb Williams 
Can do. I'll have get the most current revision before I start anyway.
On Aug 2, 2015 12:17 PM,  wrote:

> Hi,
>
> I guess you figured that out already, but Mike did some changes to the
> website to correct some mistakes, which are in git repository master
> branch.
> The download links are probably the same, just with the 4 replaced by 5 in
> all version numbers, so I guess you could prepare the changes already and
> push them into our git repository.
> I think Mike will proofread, compile, upload everything (downloads, release
> notes and website) tomorrow.
>
>
> Greetings,
>
> wintertime
>
>
> *Gesendet:* Sonntag, 02. August 2015 um 16:48 Uhr
> *Von:* "Caleb Williams" 
> *An:* "FreeCol Developers" 
> *Betreff:* Re: [Freecol-developers] 0.11.5
>
> If somebody can push the changes to the website, I can make the updates
> needed to the website in the repository.
>
> I'll just need a list of all the download links when they are available.
>
> Thanks,
>
> Caleb
> On Aug 2, 2015 5:32 AM,  wrote:
>>
>> Hi all,
>>
>> I did cherry-pick the relevant commits for 0.11.5 and
>> pushed a stable and a tentative branch.
>> Please, help testing these to ensure we don't have another
>> lurking bug!
>>
>> I also updated the wiki, copied the empty template for later
>> and added text to the 0.11.5 page. Please, do proofreading!
>> I'm not sure if a mention of the Windows problems BR#793
>> and/or BR#2328/BR#2729 in the common problems section is
>> necessary, but there had been none in 0.11.4 page, too.
>>
>>
>> Regards,
>>
>> wintertime
>
>
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread winter 

Hi,

 

I guess you figured that out already, but Mike did some changes to the

website to correct some mistakes, which are in git repository master branch.

The download links are probably the same, just with the 4 replaced by 5 in

all version numbers, so I guess you could prepare the changes already and

push them into our git repository.

I think Mike will proofread, compile, upload everything (downloads, release

notes and website) tomorrow.

 

 

Greetings,

 

wintertime

 

 

Gesendet: Sonntag, 02. August 2015 um 16:48 Uhr
Von: "Caleb Williams" 
An: "FreeCol Developers" 
Betreff: Re: [Freecol-developers] 0.11.5


If somebody can push the changes to the website, I can make the updates needed to the website in the repository.

I'll just need a list of all the download links when they are available.

Thanks,

Caleb

On Aug 2, 2015 5:32 AM,  wrote:

Hi all,

I did cherry-pick the relevant commits for 0.11.5 and
pushed a stable and a tentative branch.
Please, help testing these to ensure we don't have another
lurking bug!

I also updated the wiki, copied the empty template for later
and added text to the 0.11.5 page. Please, do proofreading!
I'm not sure if a mention of the Windows problems BR#793
and/or BR#2328/BR#2729 in the common problems section is
necessary, but there had been none in 0.11.4 page, too.


Regards,

wintertime






--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Caleb Williams 
If somebody can push the changes to the website, I can make the updates
needed to the website in the repository.

I'll just need a list of all the download links when they are available.

Thanks,

Caleb
On Aug 2, 2015 5:32 AM,  wrote:

> Hi all,
>
> I did cherry-pick the relevant commits for 0.11.5 and
> pushed a stable and a tentative branch.
> Please, help testing these to ensure we don't have another
> lurking bug!
>
> I also updated the wiki, copied the empty template for later
> and added text to the 0.11.5 page. Please, do proofreading!
> I'm not sure if a mention of the Windows problems BR#793
> and/or BR#2328/BR#2729 in the common problems section is
> necessary, but there had been none in 0.11.4 page, too.
>
>
> Regards,
>
> wintertime
>
>
> --
> ___
> Freecol-developers mailing list
> Freecol-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freecol-developers
>
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread winter 
Hi all,

I did cherry-pick the relevant commits for 0.11.5 and
pushed a stable and a tentative branch.
Please, help testing these to ensure we don't have another
lurking bug!

I also updated the wiki, copied the empty template for later
and added text to the 0.11.5 page. Please, do proofreading!
I'm not sure if a mention of the Windows problems BR#793
and/or BR#2328/BR#2729 in the common problems section is
necessary, but there had been none in 0.11.4 page, too.


Regards,

wintertime

--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread winter 
Hi,

> Gesendet: Sonntag, 02. August 2015 um 09:04 Uhr
> Von: "Michael T. Pope" 
> An: "FreeCol Developers" 
> Betreff: Re: [Freecol-developers] 0.11.5
>
> On Sun, 2 Aug 2015 08:22:57 +0200
> win...@genial.ms wrote:
> > As there is a crippling bug and 0.11.3 is too old as a full replacement, we
> > are responsible for getting a hotfix release out ASAP, as we don't want to
> > have users endure the problem unnecessarily long.
> 
> OK, two firm votes for a quick 0.11.5 is indicative.  Although I still grin
> at the thought that 0.11.3 is "old".
> 
> > IMO, create a branch from the 0.11.4 release commit, cherry-pick all 
> > bugfixes,
> 
> The minimal set is 0.11.4 (ecbc3b7) + fix#2878 (167ecf9) + fix#2885
> (56ecbac).  I do not think the other bug fixes are safe enough and/or
> string-change free.
> 

I was going through the changelist independently and here are the commits,
which I found looked mergeable and possibly useful. It would need to be
shortened still to remove too risky stuff:

a2297d91 Autosave directory fix
5de4460f Integer option limits
7aef6f59 + b8c21dc2 + 8394732c BR#2875 package, maybe not useful enough
167ecf98 BR#2878
72190eeb splash moving, unnecessary?
1728101d temporary race condition fix
62073e9c IR#164, don't know if necessary?
56ecbac7 BR#2885
9f0b19cb + fa00b093 + 67e79229 Do we care about website stuff in the release 
branch?

> > Then copy the release info from the 0.11.4 release...
> 
> Can I get you to do the Release Notes?  I have to leave shortly, and am
> unlikely to have time to roll the release until tomorrow evening anyway.
> 

I'll update the wiki, but can't complete it until we know whats included.
You can proofread/change it tomorrow?


Greetings,

wintertime

--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] 0.11.5

2015-08-02 Thread Michael T. Pope 
On Sun, 2 Aug 2015 08:22:57 +0200
win...@genial.ms wrote:
> As there is a crippling bug and 0.11.3 is too old as a full replacement, we
> are responsible for getting a hotfix release out ASAP, as we don't want to
> have users endure the problem unnecessarily long.

OK, two firm votes for a quick 0.11.5 is indicative.  Although I still grin
at the thought that 0.11.3 is "old".

> IMO, create a branch from the 0.11.4 release commit, cherry-pick all bugfixes,

The minimal set is 0.11.4 (ecbc3b7) + fix#2878 (167ecf9) + fix#2885
(56ecbac).  I do not think the other bug fixes are safe enough and/or
string-change free.

> Then copy the release info from the 0.11.4 release...

Can I get you to do the Release Notes?  I have to leave shortly, and am
unlikely to have time to roll the release until tomorrow evening anyway.
  
> Btw., I yesterday was looking if izpack got new versions, but they seem to
> have lost their hoster and the website I saw is a mess, promoting an RC5
> as newest download, but the news section having the full release and 3
> other bugfix releases already, without providing a download.

Ugh.  Not inspiring of confidence.

Cheers,
Mike Pope


pgpuD447E3R4s.pgp
Description: OpenPGP digital signature
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers