Re: [Freecol-developers] Fwd: Re: Mouse event Problem in #199

[Michael T. Pope]

On Tue, 6 Dec 2016 09:50:11 -0500
Dong Kim  wrote:
> Sounds awesome, thanks for all your help! It was a great experience
> overall.

Not entirely.  I just grabbed the merge, and it is very hard for me to
work out what you have done because of all the code reformatting.  In
particular, there are TABs everywhere, which we explicitly ask *not* to be
used in FreeCol code contributions.  Look at AbstractGoodsLabel to see
what I mean --- AFAICT there you have added a new field and setter/getter
methods for it, but "git diff" shows almost all of the file is changed!  I
strongly encourage you to put in another merge request that contains
*only* what needs to change to implement the features.  As things stand I
can not merge without a lot of extra tedious work.

Cheers,
Mike Pope
  


pgp89uBHQjk5Q.pgp
Description: OpenPGP digital signature
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] Fwd: Re: Mouse event Problem in #199

[Dong Kim]

Hi Caleb,

Sounds awesome, thanks for all your help! It was a great experience
overall.

On Mon, Dec 5, 2016 at 6:19 PM, Caleb Williams  wrote:

> For record keeping purposes.
> -- Forwarded message --
> From: "Caleb Williams" 
> Date: Dec 5, 2016 5:18 PM
> Subject: Re: [Freecol-developers] Mouse event Problem in #199
> To: "Dong Kim" 
> Cc:
>
> We're not sure but it does work for SHIFT+ALT,
> defaultTransferHander.importData just does not get called for
> SHIFT+CONTROL for reasons not known.
>
>
> I think that can always be tracked down later if it is really a big deal.
>
> Our current pull request has the SHIFT+ALT event implemented, so we
> deviated from the improvement request a bit. Will this be fine?
>
>
> My opinion is that this will be fine, but the final say will be Mike's.
>
> I look forward to taking a look at the code too.
>
> Thanks again for contributing. Once this is finalized, I will add a credit
> on pur website for you and your group.
>
> Thanks,
>
> Caleb
>
> 
> --
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/xeonphi
> ___
> Freecol-developers mailing list
> Freecol-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freecol-developers
>
>
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

[Freecol-developers] Fwd: Re: Mouse event Problem in #199

[Caleb Williams]

For record keeping purposes.
-- Forwarded message --
From: "Caleb Williams" 
Date: Dec 5, 2016 5:18 PM
Subject: Re: [Freecol-developers] Mouse event Problem in #199
To: "Dong Kim" 
Cc:

We're not sure but it does work for SHIFT+ALT,
defaultTransferHander.importData just does not get called for SHIFT+CONTROL
for reasons not known.


I think that can always be tracked down later if it is really a big deal.

Our current pull request has the SHIFT+ALT event implemented, so we
deviated from the improvement request a bit. Will this be fine?


My opinion is that this will be fine, but the final say will be Mike's.

I look forward to taking a look at the code too.

Thanks again for contributing. Once this is finalized, I will add a credit
on pur website for you and your group.

Thanks,

Caleb
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers