Re: [Freecol-developers] Pull Request #7 Review...
Sure, will do that tomorrow. David On Sun, Nov 12, 2017, 1:03 PM Michael T. Pope wrote: > On Tue, 07 Nov 2017 16:55:05 + > David Lewis wrote: > > Please review Pull Request #7: > > https://github.com/FreeCol/freecol/pull/7 > > The title suggests this a fix for the entryLocation stuffup, which is > now fixed (properly, it was only happening because I broke the > serialization of Player). However a really quick look shows there are a > bunch of unrelated cleanups in there as well. Can I leave it to you to > merge in what you think is useful? Despite a productive weekend, we > still have new open bugs that I should look at first. > > Cheers, > Mike Pope > > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
Re: [Freecol-developers] Pull Request #7 Review...
On Tue, 07 Nov 2017 16:55:05 + David Lewis wrote: > Please review Pull Request #7: > https://github.com/FreeCol/freecol/pull/7 The title suggests this a fix for the entryLocation stuffup, which is now fixed (properly, it was only happening because I broke the serialization of Player). However a really quick look shows there are a bunch of unrelated cleanups in there as well. Can I leave it to you to merge in what you think is useful? Despite a productive weekend, we still have new open bugs that I should look at first. Cheers, Mike Pope pgp86t4vumSok.pgp Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
[Freecol-developers] Pull Request #7 Review...
Please review Pull Request #7: https://github.com/FreeCol/freecol/pull/7 Thanks! David -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
