Re: [Freecol-developers] open bug review

[Caleb Williams]

> The look and feel stuff (IIRC in plaf folder) is the place where widgets
get customized globally, but its weird und I never saw through it
completely.

Good to know. My research of the Java documentation took me in that
direction, so I will take a look there.

> Thats why it probably needs to be set when creating that instance, which
is still better than circumventing the system thats in place, checking a
redundant bool and overriding on every repaint.

That makes the most sense. I will look at that code soon.

Thanks,

Caleb
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] open bug review

[winter]

Hi,

 

I think that would be more like a hack and not the right way of doing it.

The look and feel stuff (IIRC in plaf folder) is the place where widgets get customized globally, but its weird und I never saw through it completely.

The problem is that a widget may be reused and may need background in one instance and no background in another instance, and both methods would change it for the whole class.

Thats why it probably needs to be set when creating that instance, which is still better than circumventing the system thats in place, checking a redundant bool and overriding on every repaint.

 

 

Greetings,

 

wintertime

 

 

Gesendet: Mittwoch, 05. Oktober 2016 um 03:15 Uhr
Von: "Caleb Williams" 
An: "FreeCol Developers" 
Betreff: Re: [Freecol-developers] open bug review







BR#2911

 * I reviewed the places where this occurs due to code and in may cases it's a small overlay with the "new" background behind a small section. One place that I don't really like the overlay is on the buttons. It does a great job of letting you know there is something new there, but it I almost feel as if a different texture would be a great way to make this stand out. Something darker perhaps. I also looked at possibly using a solid color background for readability purposes, but the colors I choose did work from what the color "should look like" to when you input that color as an RGB value. Hopefully in the next couple of days I can re-run over the some of the panels and see if I see any egregious errors.








 

 







Still looking at this, but it's possible that for certain panels or sub-panels that we may need to override paintComponent(Graphics g) so that we do not paint in the FreeCol background rather than the setOpaque(boolean isOpaque) method call mentioned earlier in the bug report itself. I have not yet experimented further with this idea.

 

Thanks,

 
--


Caleb R. Williams

 

 









--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] open bug review

[Caleb Williams]

>
> BR#2911
>  * I reviewed the places where this occurs due to code and in may cases
> it's a small overlay with the "new" background behind a small section. One
> place that I don't really like the overlay is on the buttons. It does a
> great job of letting you know there is something new there, but it I almost
> feel as if a different texture would be a great way to make this stand out.
> Something darker perhaps. I also looked at possibly using a solid color
> background for readability purposes, but the colors I choose did work from
> what the color "should look like" to when you input that color as an RGB
> value. Hopefully in the next couple of days I can re-run over the some of
> the panels and see if I see any egregious errors.
>

Still looking at this, but it's possible that for certain panels or
sub-panels that we may need to override paintComponent(Graphics g)

so
that we do not paint in the FreeCol background rather than the
setOpaque(boolean
isOpaque)

method call mentioned earlier in the bug report itself. I have not yet
experimented further with this idea.

Thanks,

-- 
*Caleb R. Williams*
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] open bug review

[Michael T. Pope]

On Sat, 1 Oct 2016 00:50:53 +0200
win...@genial.ms wrote:
> The thing I always wanted to do when next release comes was put in that 
> graphics file Stian sent months ago.

Good.

> Otherwise there was not much left I felt like doing, as I got kinda stuck on 
> that incomplete AI project (am unsure if I'll complete it).

You will not be either the first or the last in that position:-).

> I had the River dialog in mind though and thought about making it scrollable, 
> but considered it low priority; I guess I can take another look at it 
> sometimes.

Agreed it is low priority.

Cheers,
Mike Pope


pgpsVBd116IlO.pgp
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] open bug review

[winter]

Hi,

 

sorry for the delay. I'm still reading all notifications, but had a few days backlog.

 

The thing I always wanted to do when next release comes was put in that graphics file Stian sent months ago.

Otherwise there was not much left I felt like doing, as I got kinda stuck on that incomplete AI project (am unsure if I'll complete it).

I had the River dialog in mind though and thought about making it scrollable, but considered it low priority; I guess I can take another look at it sometimes.


 

 

Greetings,

 

wintertime

 

 


Gesendet: Donnerstag, 29. September 2016 um 05:33 Uhr
Von: "Caleb Williams" 
An: "FreeCol Developers" 
Betreff: Re: [Freecol-developers] open bug review


Thoughts a couple of bugs:
 

BR#2911

 * I reviewed the places where this occurs due to code and in may cases it's a small overlay with the "new" background behind a small section. One place that I don't really like the overlay is on the buttons. It does a great job of letting you know there is something new there, but it I almost feel as if a different texture would be a great way to make this stand out. Something darker perhaps. I also looked at possibly using a solid color background for readability purposes, but the colors I choose did work from what the color "should look like" to when you input that color as an RGB value. Hopefully in the next couple of days I can re-run over the some of the panels and see if I see any egregious errors.

 

BR#2926:
 * I looked at this and the issue is that the container used to display the dialog selection isn't a JScrollPane and I've had a hard time moving it in that direction. The panel is not based on a MigLayout implementation but rather on a simple JFrame which I am not as familiar with customizing. It's possibly switching to a MigLayout may work. I pinged Wintertime on this, but have heard nothing back, so this could be something to do with a longer stretch of time. It would be nice to fix this panel before the next release.

 

Thanks,

 

--

Caleb R. Williams

 

 









--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] open bug review

[Caleb Williams]

Thoughts a couple of bugs:

BR#2911
 * I reviewed the places where this occurs due to code and in may cases
it's a small overlay with the "new" background behind a small section. One
place that I don't really like the overlay is on the buttons. It does a
great job of letting you know there is something new there, but it I almost
feel as if a different texture would be a great way to make this stand out.
Something darker perhaps. I also looked at possibly using a solid color
background for readability purposes, but the colors I choose did work from
what the color "should look like" to when you input that color as an RGB
value. Hopefully in the next couple of days I can re-run over the some of
the panels and see if I see any egregious errors.

BR#2926:
 * I looked at this and the issue is that the container used to display the
dialog selection isn't a JScrollPane and I've had a hard time moving it in
that direction. The panel is not based on a MigLayout implementation but
rather on a simple JFrame which I am not as familiar with customizing. It's
possibly switching to a MigLayout may work. I pinged Wintertime on this,
but have heard nothing back, so this could be something to do with a longer
stretch of time. It would be nice to fix this panel before the next release.

Thanks,

-- 
*Caleb R. Williams*
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

[Freecol-developers] open bug review

[Michael T. Pope]

By way of a general update, we are still stuck on BR#2925, which requires
more shovelling before a fix can go in.  Other than that though, the bug
list is in pretty good shape.  BR#2982 has me puzzled, and I would like to
see BR#2983 finally sorted by release, but nothing else sticks out as
critical.  Anyway, here is my current view of the bug list.

BR#2982   I am looking at this, but its a tricky one
BR#2981   Should be fixed, needs playtest
BR#2979   Should be fixed, needs playtest
BR#2978   Should be fixed, needs playtest
BR#2971 * Native trade is being rewritten, should go away when I am done
BR#2961 * Same as above
BR#2959 * Diplomacy is due to be rewritten right after native trade
BR#2937 ???   Needs a revisit, is this still replicable?
BR#2936 ???   Possible fix went in, is this still replicable?
BR#2926 * Map editor UI
BR#2925 * Release blocker that needs the native+diplomacy work
BR#2921 ???   Can not replicate, no response, close?
BR#2912 **UI issue likely to be system dependent
BR#2911 **Caleb is looking at this
BR#2983 ***   America_large map needs predefined regions
BR#2981 WWC1D
BR#2888 Media   
BR#2887 * Belived to be fixed, close at release if no further sightings
BR#2883 **UI issue
BR#2876 ? Is this still happening?
BR#2939 Media
BR#2827 * Dock/tile ownership, good one for students
BR#2824 WWC1D 
BR#2820 ??UI, unclear if its still happening
BR#2813 * Believed to be fixed, close at release if no further sightings
BR#2806 ???   Should be fixed but unclear
BR#2803 * Need a dual monitor setup to check
BR#2751 ???   Lots changed here, might be gone, might still be cases?
BR#2730 * Minor, needs a special case in the path traversal
BR#2729 ??Mitigated, windows specific, still happens?
BR#2722 Media
BR#2703 **The opening video fail
BR#2611 ???   Probably a Java bug that may now be fixed, revisit
BR#2593 * Upkeep related, need to playtest a game with upkeep enabled
BR#2527 * Lots of usability complaints, needs the big UI revision
BR#2515 ? Unclear
BR#2377 WWC1D
BR#2328 ???   Opening video going behind, wintertime says it was fixed in 2014?
BR#2170 * Windows specific (possibly XP?)
BR#2049 Media
BR#2043 Media
BR#2014 * Good one for students
BR#1959 * Good one for Michael if he returns:-)
BR#1944 ? Want some clarification from Nick if he returns:-)
BR#1924 ? Weirdness with the Java file selector widget?
BR#1873 ? UI/aesthetics issue
BR#1824 * Long term UI project, good one for students
BR#1738 ??The "windows going behind" problem, Java/Windows?
BR#1637 ???   Has been kicked, might be gone, close at release?
BR#1307 * Java file selector sucks
BR#793  ? Really an windows installer bug. Check the installer?

*s are on bugs where we know what needs to be done, number of *s is
the priority.  ?s are on bugs where something is unclear, the number
of ?s is the priority again.  Others are blocked due to WWC1D or lack
of media.  There are a lot of bugs that *might* be fixed.

Cheers,
Mike Pope


pgp1rxPz4yQxJ.pgp
Description: OpenPGP digital signature
--
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers