[Freeipa-devel] [freeipa PR#769][comment] test_caless: add pkinit option and test it

2017-05-19 Thread MartinBasti 
  URL: https://github.com/freeipa/freeipa/pull/769
Title: #769: test_caless: add pkinit option and test it

MartinBasti commented:
"""
master:

* f7c4039e415af2db51ae132ec15456f57eed161a test_caless: add pkinit option and 
test it
* d5e84d70650a8b3430c11583876e5f604560c74e test_caless: mark TestCertinstall 
intermediate CA tests as xfail


ipa-4-5:

* cea42421bc17317f69143061173e8b9a5c0e153e test_caless: add pkinit option and 
test it
* f9bf76e1f3b39495a9ad61513d842844b89201dc test_caless: mark TestCertinstall 
intermediate CA tests as xfail


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/769#issuecomment-302670212
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#769][comment] test_caless: add pkinit option and test it

2017-05-18 Thread HonzaCholasta 
  URL: https://github.com/freeipa/freeipa/pull/769
Title: #769: test_caless: add pkinit option and test it

HonzaCholasta commented:
"""
@stlaz & @Rezney, kind permission given.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/769#issuecomment-30231
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#769][comment] test_caless: add pkinit option and test it

2017-05-18 Thread stlaz 
  URL: https://github.com/freeipa/freeipa/pull/769
Title: #769: test_caless: add pkinit option and test it

stlaz commented:
"""
Please note that tests trying to use `ipa-server-certinstall` with certificates 
signed by an intermediate CA fail because of 
https://pagure.io/freeipa/issue/6955
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/769#issuecomment-302331214
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#769][comment] test_caless: add pkinit option and test it

2017-05-18 Thread stlaz 
  URL: https://github.com/freeipa/freeipa/pull/769
Title: #769: test_caless: add pkinit option and test it

stlaz commented:
"""
The changes are fine. Please note the licence at the original file which you're 
copying here:
```bash
 #!/bin/bash -e
 #
 # Copyright (c) 2015, Jan Cholasta 
 #
 # Permission to use, copy, modify, and/or distribute this software for any
 # purpose with or without fee is hereby granted, provided that the above
 # copyright notice and this permission notice appear in all copies.
 #
 # THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 # WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 # MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 # ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 # WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 # ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 # OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
```
I don't want to appear amid some multi-licence hell, so I suppose you should 
add at least the common header for FreeIPA files:
```
#
# Copyright (C) 2017  FreeIPA Contributors see COPYING for license
#
```
with the kind permission of @HonzaCholasta.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/769#issuecomment-302330229
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org