Re: [Freeipa-devel] [PATCH] 517 updated command documentation

2010-08-26 Thread Pavel Zůna

On 2010-08-25 05:52, Rob Crittenden wrote:

David O'Brien reviewed all the per-command documentation last month and
provided a ton of great feedback. I've applied all his changes.

rob


ACK.

Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange

2010-08-26 Thread Adam Young

On 08/26/2010 01:13 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 11:21 PM, Adam Young wrote:

On 08/25/2010 10:33 PM, Adam Young wrote:

On 08/25/2010 05:52 PM, Rob Crittenden wrote:

Adam Young wrote:

On 08/25/2010 10:41 AM, Adam Young wrote:

On 08/25/2010 07:39 AM, Pavel Zůna wrote:

On 2010-08-24 23:57, Adam Young wrote:
This is a fairly substantial patch that makes use of the 
hashchange

event to drive the site. It affcets just about all places where
click
events are triggered.



Just started reviewing the patch a few moments ago. Just 2 
notes in

advance:

1) It doesn't apply after the script eng tag patch, that was
ACKed,
but not pushed yet.

2) I don't want to sound like a nitpicker, but you should do some
tweaking to your text editor. It seems to leave trailing white
spaces
and more importantly, it converts 8 spaces to tabs!

The only edits in details.js are the tab conversions, so there
should
be no conflict with my details patch when you remove them.

Pavel



OK. I think I can deal with both of those issues. I'll repost the
patch after, to have the one for the record on the mailing list, 
but

also so you can confrium it works with your changes.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


removed whitespace
updated the Makefile.am to include add.js
applies on top of recent changes to other files in the directory.


This isn't working for me. I tried both with lite-server and a real
deployment and all I see are the header and the Edit: line (users,
groups, etc). Clicking on the different tabs doesn't seem to do
anything.

rob


That behavior seems to be what happens when the html errors out on
Javascript loads.
The liter server can't hang /ipa/ui...it needs the final slash in the
url.  On my lite server it works with:

http://127.0.0.1:/ipa/ui/

Note that this gets the sample data, not the calls to the server.  We
have a workaround for that, that I will submit in a follow on patch.

I found quite a few bugs in the second version of this patch, which I
have fixed here.  I have tested this on both the lite and httpd
servers in my VM and it works.   I suspect I have fixed the error you
were seeing on the httpd server.  But, I will test it on a lab VM as
well.










___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

And...this one has bugs too.
What I found so far:

Add User doesn't work.
Host details goes to list page
Netgroup and Hostgroup Add Another acts like Add and Edit, but with no
primary key.
Group enroll seems to fail silently.


Gonna pull this one until I work out this issues.  This is mostly
based on the routing from page to page, so it is not surprising that
many of the page transitions aren't set right.  Part of the
refactoring I've started is sdesigned to reduce the amount of cut and
past code.



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel



Lost of sand in the machinery on this one, but I managed to get
everything fixed but the group enroll.  The group enroll may not be
broken itself, but the Browser is showing a corrupted user.js file,
which I've seen before.


Ok, seems to work at least as well as before, ACK.

rob

pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 508 fix reference to _handle_errors

2010-08-26 Thread Adam Young

On 08/10/2010 03:05 PM, Rob Crittenden wrote:
In remove_principal_key() we were calling self._handle_errors() rather 
than _handle_errors().


I've pushed this under the one-liner rule.

rob

From 6befd08973183f0aa9b681a1d7fd0b9a3a89fe08 Mon Sep 17 00:00:00 2001
From: Rob Crittenden rcrit...@redhat.com
Date: Tue, 10 Aug 2010 15:03:11 -0400
Subject: [PATCH] Fix reference to _handle_errors() in 
remove_principal_key()


It incorrectly was trying to call the class method _handle_errors() 
instead

of the global function.
---
 ipaserver/plugins/ldap2.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ipaserver/plugins/ldap2.py b/ipaserver/plugins/ldap2.py
index 3c536e2..81c2aeb 100644
--- a/ipaserver/plugins/ldap2.py
+++ b/ipaserver/plugins/ldap2.py
@@ -839,7 +839,7 @@ class ldap2(CrudBackend, Encoder):
 try:
 self.conn.modify_s(dn, mod)
 except _ldap.LDAPError, e:
-self._handle_errors(e, **{})
+_handle_errors(e, **{})

 # CrudBackend methods


ACK

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 500 configure nslcd and a host of other ldap files

2010-08-26 Thread Adam Young

On 08/04/2010 10:14 AM, Rob Crittenden wrote:

Configure nslcd and a host of possible systems that use LDAP.

We will update any/all of /etc/ldap.conf, /etc/nss_ldap.conf,
/etc/libnss-ldap.conf and /etc/pam_ldap.conf.

nslcd is the replacement for nss_ldap.

ticket 50


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK, but needs QA attention in testing
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel