[Freeipa-devel] [PATCH] 0063 Fix ipa_uuid misbehavior

2011-01-19 Thread Simo Sorce

ipa_uuid was returning an improper error if a modify operation was
performed on an entry that doesn't exists.
This was preventing the dna plugin from working correctly.

Do not error on missing entries, let DS handle the case and report the
proper error code.

Ticket 813

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
From be5cbfdb62cd986e4d873773a62ae1490df86da2 Mon Sep 17 00:00:00 2001
From: Simo Sorce sso...@redhat.com
Date: Wed, 19 Jan 2011 14:54:01 -0500
Subject: [PATCH] Fix ipa_uuid to not interfer with proper error reporting

Fixes: https://fedorahosted.org/freeipa/ticket/813
---
 daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c |5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c b/daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c
index 83aac77da95df39cb162988e9a58172585b7ab5a..c6353aeed4a68560be45cb3b3779bdef5ff83620 100644
--- a/daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c
+++ b/daemons/ipa-slapi-plugins/ipa-uuid/ipa_uuid.c
@@ -819,9 +819,8 @@ static int ipauuid_pre_op(Slapi_PBlock *pb, int modtype)
 slapi_sdn_free(tmp_dn);
 
 if (ret) {
-LOG_FATAL(slapi_search_internal_get_entry failed!? Err %d\n,
-ret);
-ret = LDAP_OPERATIONS_ERROR;
+/* ok a client tried to modify an entry that doesn't exist.
+ * Nothing to see here, move along ... */
 goto done;
 }
 
-- 
1.7.3.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0063 Fix ipa_uuid misbehavior

2011-01-19 Thread Rob Crittenden

Simo Sorce wrote:


ipa_uuid was returning an improper error if a modify operation was
performed on an entry that doesn't exists.
This was preventing the dna plugin from working correctly.

Do not error on missing entries, let DS handle the case and report the
proper error code.

Ticket 813

Simo.


ack

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 0063 Fix ipa_uuid misbehavior

2011-01-19 Thread Simo Sorce
On Wed, 19 Jan 2011 15:15:53 -0500
Rob Crittenden rcrit...@redhat.com wrote:

 Simo Sorce wrote:
 
  ipa_uuid was returning an improper error if a modify operation was
  performed on an entry that doesn't exists.
  This was preventing the dna plugin from working correctly.
 
  Do not error on missing entries, let DS handle the case and report
  the proper error code.
 
  Ticket 813
 
  Simo.
 
 ack

Thanks,
pushed to master.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel