Re: [Freeipa-devel] [PATCH] 270 Improve migration NotFound error

2012-06-05 Thread Martin Kosek
On Mon, 2012-06-04 at 23:13 -0400, Rob Crittenden wrote:
 Martin Kosek wrote:
  When no user/group was found, migration plugin reported an ambiguous
  error about invalid container. But the root cause may be for example
  in a wrong list of user/group objectclasses. Report both in the error
  message to avoid user confusion.
 
  User/group objectclass attribute is now also marked as required.
  Without the list of objectclasses, an invalid LDAP search is
  produced.
 
  https://fedorahosted.org/freeipa/ticket/2206
 
 ACK. The output is a lot readable, you might reconsider having it in 
 parens. A separate sentence or separated by a colon may be more readable.
 
 rob

I tried different formats, but the former approach still seemed to me as
the most readable, so I kept that :-)

Pushed to master.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 270 Improve migration NotFound error

2012-06-04 Thread Rob Crittenden

Martin Kosek wrote:

When no user/group was found, migration plugin reported an ambiguous
error about invalid container. But the root cause may be for example
in a wrong list of user/group objectclasses. Report both in the error
message to avoid user confusion.

User/group objectclass attribute is now also marked as required.
Without the list of objectclasses, an invalid LDAP search is
produced.

https://fedorahosted.org/freeipa/ticket/2206


ACK. The output is a lot readable, you might reconsider having it in 
parens. A separate sentence or separated by a colon may be more readable.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel