[Freeipa-devel] [PATCH] 377 Use correct service name in cainstance.backup_config

2014-11-21 Thread Jan Cholasta

Hi,

the attached patch fixes https://fedorahosted.org/freeipa/ticket/4754.

Honza

--
Jan Cholasta
From c1db9d92088436234d2a00c946a8e470d740745b Mon Sep 17 00:00:00 2001
From: Jan Cholasta jchol...@redhat.com
Date: Fri, 21 Nov 2014 07:52:24 +
Subject: [PATCH] Use correct service name in cainstance.backup_config

https://fedorahosted.org/freeipa/ticket/4754
---
 ipaserver/install/cainstance.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/cainstance.py b/ipaserver/install/cainstance.py
index 6ccbe41..6b4317f 100644
--- a/ipaserver/install/cainstance.py
+++ b/ipaserver/install/cainstance.py
@@ -1861,7 +1861,8 @@ def backup_config(dogtag_constants=None):
 if dogtag_constants is None:
 dogtag_constants = dogtag.configured_constants()
 
-if services.knownservices.dogtag.is_running():
+if services.knownservices[dogtag_constants.SERVICE_NAME].is_running(
+dogtag_constants.PKI_INSTANCE_NAME):
 raise RuntimeError(Dogtag must be stopped when creating backup of %s
% dogtag_constants.CS_CFG_PATH)
 shutil.copy(dogtag_constants.CS_CFG_PATH,
-- 
2.1.0

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 377 Use correct service name in cainstance.backup_config

2014-11-21 Thread Martin Kosek
On 11/21/2014 09:11 AM, Jan Cholasta wrote:
 Hi,
 
 the attached patch fixes https://fedorahosted.org/freeipa/ticket/4754.
 
 Honza

ACK, works fine.

Pushed to:
master: 71c4d3e979584e9f841bc8565e69b53fc111c8c6
ipa-4-1: 1b5cd5b2271240526177810f7340400db695aafc
ipa-4-0: 1ef2d080c4d8a0edc20ab96591b03aad5372ae76

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel