Re: [Freeipa-devel] [PATCH] 450 Fix redirection on deletion of last dns record entry

2013-09-16 Thread Petr Viktorin

On 09/06/2013 04:47 PM, Ana Krivokapic wrote:

On 09/06/2013 02:30 PM, Petr Vobornik wrote:

https://fedorahosted.org/freeipa/ticket/3907


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


ACK



Pushed to:
master: 5c4a72de59840b84a128c8649c8d7b444993
ipa-3-3: ac5447f57953dd022f63f9f801c5628df3e4b832


--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 450 Fix redirection on deletion of last dns record entry

2013-09-06 Thread Ana Krivokapic
On 09/06/2013 02:30 PM, Petr Vobornik wrote:
> https://fedorahosted.org/freeipa/ticket/3907
>
>
> ___
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 450 Fix redirection on deletion of last dns record entry

2013-09-06 Thread Petr Vobornik

https://fedorahosted.org/freeipa/ticket/3907
--
Petr Vobornik
From d1c6e5e2e42551a707c0b295d6b760879b068ad1 Mon Sep 17 00:00:00 2001
From: Petr Vobornik 
Date: Fri, 6 Sep 2013 14:24:36 +0200
Subject: [PATCH] Fix redirection on deletion of last dns record entry

https://fedorahosted.org/freeipa/ticket/3907
---
 install/ui/src/freeipa/dns.js   |  2 +-
 ipatests/test_webui/test_dns.py | 21 -
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index c31313a13de99fafb516d8032b32c640c9b1c08d..62b20e31cdae482dc21dc594b289e5194d628340 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -1313,7 +1313,7 @@ IPA.dnsrecord_redirection_dialog = function(spec) {
 };
 
 that.on_ok = function() {
-navigation.show_entity_page('dnszone','default');
+navigation.show_entity('dnszone','default');
 };
 
 return that;
diff --git a/ipatests/test_webui/test_dns.py b/ipatests/test_webui/test_dns.py
index aeff77b8e02eb7bf3775f3baceb5c034d1a450e5..c832190d39c23fc5b90884439779341c448cd099 100644
--- a/ipatests/test_webui/test_dns.py
+++ b/ipatests/test_webui/test_dns.py
@@ -46,11 +46,12 @@ ZONE_DATA = {
 
 
 RECORD_PKEY = 'itest'
+A_IP = '192.168.1.10'
 RECORD_ADD_DATA = {
 'pkey': RECORD_PKEY,
 'add': [
 ('textbox', 'idnsname', RECORD_PKEY),
-('textbox', 'a_part_ip_address', '192.168.1.10'),
+('textbox', 'a_part_ip_address', A_IP),
 ]
 }
 
@@ -98,6 +99,24 @@ class test_dns(UI_driver):
 self.navigate_by_breadcrumb("DNS Zones")
 self.delete_record(ZONE_PKEY)
 
+def test_last_entry_deletion(self):
+"""
+Test last entry deletion
+"""
+self.init_app()
+self.add_record(ZONE_ENTITY, ZONE_DATA)
+self.navigate_to_record(ZONE_PKEY)
+self.add_record(ZONE_ENTITY, RECORD_ADD_DATA,
+facet=ZONE_DEFAULT_FACET)
+self.navigate_to_record(RECORD_PKEY)
+self.delete_record(A_IP, parent=self.get_facet(), table_name='arecord')
+self.assert_dialog('message_dialog')
+self.dialog_button_click('ok')
+self.wait_for_request(n=2)
+self.assert_facet(ZONE_ENTITY, ZONE_DEFAULT_FACET)
+self.navigate_by_breadcrumb("DNS Zones")
+self.delete_record(ZONE_PKEY)
+
 def test_config_crud(self):
 """
 Basic CRUD: dnsconfig
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel