Re: [Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible
On 04/02/2014 08:48 AM, Martin Kosek wrote: On 04/01/2014 07:33 PM, Rob Crittenden wrote: Martin Kosek wrote: ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that version) to fix the failure. https://fedorahosted.org/freeipa/ticket/4290 ACK. Tested F-20 client against RHEL 6.5 server. rob Thanks. Pushed to: master: 66fb4d5e849a049e95d3ef4fcf2b86217488634d ipa-3-3: ee2fac9bee6728facfa4525b8f97585f7030a14c Martin This breaks master, which uses rpcclient instead of xmlclient. Here is a one-liner fix. Pushed to master: 2478aa42a0cc3b9a061c6a281a99f6acb9b84fca -- PetrĀ³ From 32abe5bae298197ff5f93237aa616500df64c969 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 13 May 2014 16:48:49 +0200 Subject: [PATCH] ipa-client-automount: Use rpcclient, not xmlclient, for automountlocation_show Fix for a regression in 66fb4d5e849a049e95d3ef4fcf2b86217488634d https://fedorahosted.org/freeipa/ticket/4290 --- ipa-client/ipa-install/ipa-client-automount | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 2923a8f46903b26da5644737af55917a9d1a8469..861e9249083ede0e8c9fe422e6cdfb6968eba8e3 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount @@ -441,7 +441,7 @@ def main(): sys.exit('Cannot connect to the server due to ' + str(e)) try: # Use the RPC directly so older servers are supported -result = api.Backend.xmlclient.forward( +result = api.Backend.rpcclient.forward( 'automountlocation_show', unicode(options.location), version=u'2.0', -- 1.9.0 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible
On 04/01/2014 07:33 PM, Rob Crittenden wrote: Martin Kosek wrote: ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that version) to fix the failure. https://fedorahosted.org/freeipa/ticket/4290 ACK. Tested F-20 client against RHEL 6.5 server. rob Thanks. Pushed to: master: 66fb4d5e849a049e95d3ef4fcf2b86217488634d ipa-3-3: ee2fac9bee6728facfa4525b8f97585f7030a14c Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible
ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that version) to fix the failure. https://fedorahosted.org/freeipa/ticket/4290 -- Martin Kosek mko...@redhat.com Supervisor, Software Engineering - Identity Management Team Red Hat Inc. From cebfd91869bdc22fa8f72c4e47d32cac73487e45 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Tue, 1 Apr 2014 16:23:14 +0200 Subject: [PATCH] Make ipa-client-automount backwards compatible ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that version) to fix the failure. https://fedorahosted.org/freeipa/ticket/4290 --- ipa-client/ipa-install/ipa-client-automount | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ipa-client/ipa-install/ipa-client-automount b/ipa-client/ipa-install/ipa-client-automount index 62531bfe1d923b1705aed1187da6766b54c90a0c..77829b927e8c1772598d1a4e590c3f99977aa8eb 100755 --- a/ipa-client/ipa-install/ipa-client-automount +++ b/ipa-client/ipa-install/ipa-client-automount @@ -440,7 +440,12 @@ def main(): except errors.KerberosError, e: sys.exit('Cannot connect to the server due to ' + str(e)) try: -api.Command['automountlocation_show'](unicode(options.location)) +# Use the RPC directly so older servers are supported +result = api.Backend.xmlclient.forward( +'automountlocation_show', +unicode(options.location), +version=u'2.0', +) except errors.VersionError, e: sys.exit('This client is incompatible: ' + str(e)) except errors.NotFound: -- 1.8.5.3 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 468 Make ipa-client-automount backwards compatible
Martin Kosek wrote: ipa-client-automount calls automountlocation-show command during the process. Unfortunately, FreeIPA commands are forward compatible only and thus fail the installer. Similarly to ipa-client-install, call XML-RPC interface directly with version fixed to 2.0 (command was already available at that version) to fix the failure. https://fedorahosted.org/freeipa/ticket/4290 ACK. Tested F-20 client against RHEL 6.5 server. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel