Re: [Freeipa-devel] [PATCH] 745 webui: notify psw change success only once

2014-09-08 Thread Petr Vobornik

On 4.9.2014 20:37, Endi Sukma Dewata wrote:

On 8/29/2014 3:40 AM, Petr Vobornik wrote:

Password change initiated from header menu notified success twice.
First one in `dialogs.password.dialog` and second one in a success
callback. The second notification was removed.

Caused by:
https://fedorahosted.org/freeipa/changeset/870db2f677dff01750aeec104c90fce3ca0e54be/



ACK.



Pushed to:
ipa-4-1: f8fc3bbcd84e12d4f918fe05910c9e664fc0b07c
master: ad6001fc2e70b6e7dbbe986f4243dd785f1bd3b2

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 745 webui: notify psw change success only once

2014-09-04 Thread Endi Sukma Dewata

On 8/29/2014 3:40 AM, Petr Vobornik wrote:

Password change initiated from header menu notified success twice.
First one in `dialogs.password.dialog` and second one in a success
callback. The second notification was removed.

Caused by:
https://fedorahosted.org/freeipa/changeset/870db2f677dff01750aeec104c90fce3ca0e54be/


ACK.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] 745 webui: notify psw change success only once

2014-08-29 Thread Petr Vobornik

Password change initiated from header menu notified success twice.
First one in `dialogs.password.dialog` and second one in a success
callback. The second notification was removed.

Caused by:
https://fedorahosted.org/freeipa/changeset/870db2f677dff01750aeec104c90fce3ca0e54be/
--
Petr Vobornik
From 70ee651fd3c33547d7fd442f40187141c1cbf435 Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Fri, 29 Aug 2014 10:33:23 +0200
Subject: [PATCH] webui: notify psw change success only once

Password change initiated from header menu notified success twice.
First one in `dialogs.password.dialog` and second one in a success
callback. The second notification was removed.

Caused by:
https://fedorahosted.org/freeipa/changeset/870db2f677dff01750aeec104c90fce3ca0e54be/
---
 install/ui/src/freeipa/ipa.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/install/ui/src/freeipa/ipa.js b/install/ui/src/freeipa/ipa.js
index 0fb35632e9147c901f1a961c978d6ed8ff84aa2e..b414e48250c554c10a03059d234d825168a08789 100644
--- a/install/ui/src/freeipa/ipa.js
+++ b/install/ui/src/freeipa/ipa.js
@@ -632,8 +632,6 @@ IPA.password_selfservice = function() {
 IPA.update_password_expiration();
 };
 command.execute();
-
-IPA.notify_success(text.get('@i18n:password.password_change_complete'));
 });
 reset_dialog.open();
 };
-- 
1.9.3

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel