[Freeipa-devel] [PATCH] Removed unused code.

2011-02-07 Thread Endi Sukma Dewata
This depends on freeipa-edewata-0094-Restructuring-details-page.patch.

--
Endi S. Dewata

From 14fbaabf3c283f43113d4ee87b4db87a88102a95 Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 4 Feb 2011 11:48:09 -0600
Subject: [PATCH] Removed unused code.

---
 install/ui/details.js|  385 +++---
 install/ui/test/details_tests.js |   45 -
 2 files changed, 25 insertions(+), 405 deletions(-)

diff --git a/install/ui/details.js b/install/ui/details.js
index 7eb7c038ec561ec1f9f61058b3137f7c615c8ad7..6445c5a8700551a1b6d9675e10bb808a5f3ddeea 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -29,269 +29,7 @@
 IPA.expand_icon = 'ui-icon-minus';
 IPA.collapse_icon = 'ui-icon-plus';
 
-IPA.is_field_writable = function(rights){
-if (!rights){
-alert('no right');
-}
-return rights.indexOf('w')  -1;
-};
-
-IPA.details_field =  function (spec) {
-
-spec = spec || {};
-
-var that = IPA.widget(spec);
-
-that.load = spec.load || load;
-that.save = spec.save || save;
-
-function load(record) {
-that.record = record;
-that.values = record[that.name];
-that.reset();
-
-var param_info = IPA.get_param_info(that.entity_name, that.name);
-if (param_info) {
-if (param_info['primary_key']) {
-that.read_only = true;
-}
-if ('no_update' in param_info['flags']) {
-that.read_only = true;
-}
-}
-}
-
-that.update = function() {
-
-if (!that.record) return;
-
-/* remove all dd tags i.e. all attribute values */
-$('dd', that.container).remove();
-
-var multivalue = false;
-var hint_span = null;
-var dd;
-
-var param_info = IPA.get_param_info(that.entity_name, that.name);
-if (param_info) {
-if (param_info['multivalue'] || param_info['class'] == 'List')
-multivalue = true;
-var hint = param_info['doc'];
-if (hint){
-hint_span = $('span /',{
-'class': 'attrhint',
-'html': 'Hint: ' + hint});
-}
-}
-
-var rights = 'rsc';
-
-if (that.record.attributelevelrights){
-rights = that.record.attributelevelrights[this.name] || rights ;
-}
-
-if (that.values) {
-/*
-  Too much logic currently assumes an array.
-  This is true everywhere but ACIs. */
-
-if (!(that.values instanceof Array)){
-that.values = [that.values];
-}
-
-dd = IPA.create_first_dd(that.name);
-dd.append(that.create_value(that.values[0], hint_span, rights, 0));
-dd.appendTo(that.container);
-
-for (var i = 1; i  that.values.length; ++i) {
-dd = IPA.create_other_dd(that.name);
-dd.append(that.create_value(that.values[i], hint_span, rights, i));
-dd.appendTo(that.container);
-}
-
-if (multivalue  IPA.is_field_writable(rights) ) {
-dd = IPA.create_other_dd(that.name);
-dd.append(IPA.details_field_create_add_link.call(that, that.name, rights, that.values.length));
-dd.appendTo(that.container);
-}
-
-} else {
-if (multivalue   IPA.is_field_writable(rights)) {
-dd = IPA.create_first_dd(that.name);
-dd.append(IPA.details_field_create_add_link.call(that, that.name, rights, 0));
-dd.appendTo(that.container);
-
-} else {
-dd = IPA.create_first_dd(that.name);
-dd.append(that.create_value('', hint_span, rights, 0));
-dd.appendTo(that.container);
-}
-}
-};
-
-
-/* creates a Remove link for deleting attribute values */
-function create_remove_link(attr, param_info){
-function remove_on_click(obj){
-var jobj = $(obj);
-var attr = jobj.attr('title');
-var par = jobj.parent();
-var input = par.find('input');
-if (input.is('.strikethrough')){
-input.removeClass('strikethrough');
-jobj.text(Remove);
-}else{
-input.addClass('strikethrough');
-jobj.text(Undo);
-}
-return (false);
-}
-
-if (param_info){
-/* check if the param is required or of the Password type
- * if it is, then we don't want people to be able to remove it */
-if ((param_info['required']) ||
-(param_info['class'] == 'Password')){
-return ('');
-}
-}
-return $('a/',{
-href:jslink,
-click: function (){return (remove_on_click(this));},
-

Re: [Freeipa-devel] [PATCH] Removed unused code.

2011-02-07 Thread Adam Young

On 02/07/2011 10:27 AM, Endi Sukma Dewata wrote:

This depends on freeipa-edewata-0094-Restructuring-details-page.patch.

--
Endi S. Dewata



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK:  pushed to master
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel