Re: [Freeipa-devel] [PATCH] jderose 016 Fixed undefined `dns_forwarders` in ipa-server-install

2009-09-09 Thread Martin Nagy
David O'Brien wrote:
 Jason Gerard DeRose wrote:
  In ipa-server-install, if options.setup_dns is False, the
  `dns_forwarders` variable doesn't get defined, and so things crap out
  when bind.setup() is called in line 649.

 
 I'm assuming this is what causes the local variable 'dns_forwarders' 
 referenced before assignment error in the install process? Can I work 
 around this just by using --no-forwarders? (I'm about to find out...)

Yes, but then you have to also use --setup-dns. You can try to apply
the patch, or simply just apply the changes by hand. But this is
already pushed in git, so..

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] jderose 016 Fixed undefined `dns_forwarders` in ipa-server-install

2009-09-08 Thread Jason Gerard DeRose
In ipa-server-install, if options.setup_dns is False, the
`dns_forwarders` variable doesn't get defined, and so things crap out
when bind.setup() is called in line 649.


From 0001ead23abfca6bd419e06ca6ab134367672e63 Mon Sep 17 00:00:00 2001
From: Jason Gerard DeRose jder...@redhat.com
Date: Tue, 8 Sep 2009 01:03:55 -0600
Subject: [PATCH] Fixed dns_forwarders not being defined when options.setup_dns is False

---
 install/tools/ipa-server-install |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/install/tools/ipa-server-install b/install/tools/ipa-server-install
index cad1a3c..70d74dd 100755
--- a/install/tools/ipa-server-install
+++ b/install/tools/ipa-server-install
@@ -544,6 +544,8 @@ def main():
 dns_forwarders = options.forwarders
 else:
 dns_forwarders = read_dns_forwarders()
+else:
+dns_forwarders = ()
 
 if not options.unattended:
 print 
-- 
1.6.0.4

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] jderose 016 Fixed undefined `dns_forwarders` in ipa-server-install

2009-09-08 Thread Martin Nagy
On Tue, 2009-09-08 at 01:12 -0600, Jason Gerard DeRose wrote:
 In ipa-server-install, if options.setup_dns is False, the
 `dns_forwarders` variable doesn't get defined, and so things crap out
 when bind.setup() is called in line 649.

Ack and pushed.
Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel