Re: [Freeipa-devel] [PATCH] jderose 033 Fix fuzzy digigits under Fedora12

2010-01-22 Thread Martin Nagy
On Mon, 2010-01-11 at 11:40 -0700, Jason Gerard DeRose wrote:
 I'm not sure why the difference, but the uidnumber, gidnumber, etc. are
 being returned as `unicode` instead of `str` under Fedora12.  Returning
 as `unicode` is correct, but this patch allows the test to still work
 under Fedora11 for the time being.

ACK

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] jderose 033 Fix fuzzy digigits under Fedora12

2010-01-22 Thread Rob Crittenden

Martin Nagy wrote:

On Mon, 2010-01-11 at 11:40 -0700, Jason Gerard DeRose wrote:

I'm not sure why the difference, but the uidnumber, gidnumber, etc. are
being returned as `unicode` instead of `str` under Fedora12.  Returning
as `unicode` is correct, but this patch allows the test to still work
under Fedora11 for the time being.


ACK

Martin


pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH] jderose 033 Fix fuzzy digigits under Fedora12

2010-01-11 Thread Jason Gerard DeRose
I'm not sure why the difference, but the uidnumber, gidnumber, etc. are
being returned as `unicode` instead of `str` under Fedora12.  Returning
as `unicode` is correct, but this patch allows the test to still work
under Fedora11 for the time being.

From dafbfc22cccff32ff847a2e2eced09ac8c881378 Mon Sep 17 00:00:00 2001
From: Jason Gerard DeRose jder...@redhat.com
Date: Sun, 10 Jan 2010 17:47:15 -0700
Subject: [PATCH] Fixed xmlrpc_test.fuzzy_digits for Fedora12

---
 tests/test_xmlrpc/xmlrpc_test.py |2 +-
 tests/util.py|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test_xmlrpc/xmlrpc_test.py b/tests/test_xmlrpc/xmlrpc_test.py
index 02b1f92..61fca50 100644
--- a/tests/test_xmlrpc/xmlrpc_test.py
+++ b/tests/test_xmlrpc/xmlrpc_test.py
@@ -32,7 +32,7 @@ from ipalib import errors
 # Matches a gidnumber like '1391016742'
 # FIXME: Does it make more sense to return gidnumber, uidnumber, etc. as `int`
 # or `long`?  If not, we still need to return them as `unicode` instead of `str`.
-fuzzy_digits = Fuzzy('^\d+$', type=str)
+fuzzy_digits = Fuzzy('^\d+$', type=basestring)
 
 # Matches an ipauniqueid like u'784d85fd-eae7-11de-9d01-54520012478b'
 fuzzy_uuid = Fuzzy(
diff --git a/tests/util.py b/tests/util.py
index ed8ecad..4d5fea6 100644
--- a/tests/util.py
+++ b/tests/util.py
@@ -210,7 +210,7 @@ class Fuzzy(object):
 self.re = re.compile(regex)
 if type is None:
 type = unicode
-assert type in (unicode, str)
+assert type in (unicode, str, basestring)
 self.regex = regex
 self.type = type
 self.test = test
-- 
1.6.3.3

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel