Re: [Freeipa-devel] [PATCH 0093] Fix incorrect message occurence when re-adding the trust

2013-08-27 Thread Petr Viktorin

On 08/23/2013 07:23 PM, Nathaniel McCallum wrote:

On Fri, 2013-08-23 at 13:13 +0200, Tomas Babej wrote:

Hi,

You cannot re-add the trust and modify the range in the process.
The check in the code was malfunctioning since it assumed that
range_size parameter has default value. However, default value
is assigned only later in the add_range function.

https://fedorahosted.org/freeipa/ticket/3870


ACK


Pushed to
master: e68bef0b1ce3786f896689975c78ffc61f4db970
ipa-3-3: b3424ed8b5bf55b81b316e3d1c7d195e3bb814a8


--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH 0093] Fix incorrect message occurence when re-adding the trust

2013-08-23 Thread Tomas Babej

Hi,

You cannot re-add the trust and modify the range in the process.
The check in the code was malfunctioning since it assumed that
range_size parameter has default value. However, default value
is assigned only later in the add_range function.

https://fedorahosted.org/freeipa/ticket/3870

--
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org

From 4841fa8954b860fe5383d077178d5e1a3655517e Mon Sep 17 00:00:00 2001
From: Tomas Babej tba...@redhat.com
Date: Fri, 23 Aug 2013 13:06:52 +0200
Subject: [PATCH] Fix incorrect error message occurence when re-adding the
 trust

You cannot re-add the trust and modify the range in the process.
The check in the code was malfunctioning since it assumed that
range_size parameter has default value. However, default value
is assigned only later in the add_range function.

https://fedorahosted.org/freeipa/ticket/3870
---
 ipalib/plugins/trust.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipalib/plugins/trust.py b/ipalib/plugins/trust.py
index 6c7ea560eedd441b5fa46fc97b342b41010fd9f8..d2348c8e43525bdaec85c078c59460fcafb10508 100644
--- a/ipalib/plugins/trust.py
+++ b/ipalib/plugins/trust.py
@@ -423,7 +423,7 @@ sides.
 ))
 
 base_id = options.get('base_id')
-range_size = options.get('range_size') != DEFAULT_RANGE_SIZE
+range_size = options.get('range_size')
 
 if old_range and (base_id or range_size):
 raise errors.ValidationError(
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0093] Fix incorrect message occurence when re-adding the trust

2013-08-23 Thread Nathaniel McCallum
On Fri, 2013-08-23 at 13:13 +0200, Tomas Babej wrote:
 Hi,
 
 You cannot re-add the trust and modify the range in the process.
 The check in the code was malfunctioning since it assumed that
 range_size parameter has default value. However, default value
 is assigned only later in the add_range function.
 
 https://fedorahosted.org/freeipa/ticket/3870

ACK

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel