Re: [Freeipa-devel] [PATCH 0159] FIX: DNS policy upgrade raises assertion error

2014-11-13 Thread Martin Basti 

On 07/11/14 15:15, Martin Basti wrote:

Ticket: https://fedorahosted.org/freeipa/ticket/4708
Patch attached.


As I and Honza discussed personally, the updated patch modifies place of 
the fix

Updated patch attached

--
Martin Basti

From 003b429f755970aa86d0cf8f3dd9c2da57cda14d Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Fri, 7 Nov 2014 15:09:29 +0100
Subject: [PATCH] Fix: DNS policy upgrade raises asertion error

Ticket: https://fedorahosted.org/freeipa/ticket/4708
---
 ipaserver/install/plugins/dns.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ipaserver/install/plugins/dns.py b/ipaserver/install/plugins/dns.py
index 1aef837f63176cd307868c726460485fd4a004ed..62cf588d27155acb03026f69ea09ff15582d26dc 100644
--- a/ipaserver/install/plugins/dns.py
+++ b/ipaserver/install/plugins/dns.py
@@ -86,7 +86,9 @@ class update_dnszones(PostUpdate):
 api.env.realm)
 
 if update:
-api.Command.dnszone_mod(zone[u'idnsname'][0], **update)
+# FIXME: https://fedorahosted.org/freeipa/ticket/4722
+api.Command.dnszone_mod(zone[u'idnsname'][0].make_absolute(),
+**update)
 
 return (False, False, [])
 
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0159] FIX: DNS policy upgrade raises assertion error

2014-11-13 Thread Jan Cholasta 

Hi,

Dne 13.11.2014 v 13:00 Martin Basti napsal(a):

On 07/11/14 15:15, Martin Basti wrote:

Ticket: https://fedorahosted.org/freeipa/ticket/4708
Patch attached.



As I and Honza discussed personally, the updated patch modifies place of
the fix
Updated patch attached



Thanks, ACK.

Pushed to:
ipa-4-0: e5ec47992cd641def024cc77c07f98ca66b7b673
ipa-4-1: 1b22a53717cd2ead8a8f3fec84d04dac698d8925
master: 40ea328a78bec511377b464700e3add09cedc2b9

Honza

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0159] FIX: DNS policy upgrade raises assertion error

2014-11-07 Thread Martin Basti 

Ticket: https://fedorahosted.org/freeipa/ticket/4708
Patch attached.

--
Martin Basti

From 16b4b38d3feb09485c6af7033b46507ebb5df3a9 Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Fri, 7 Nov 2014 15:09:29 +0100
Subject: [PATCH] Fix: DNS policy upgrade raises asertion error

Ticket: https://fedorahosted.org/freeipa/ticket/4708
---
 ipaserver/install/plugins/dns.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/install/plugins/dns.py b/ipaserver/install/plugins/dns.py
index 1aef837f63176cd307868c726460485fd4a004ed..f5bb6ac8cc4271195f369fcb15f289bb7673e194 100644
--- a/ipaserver/install/plugins/dns.py
+++ b/ipaserver/install/plugins/dns.py
@@ -65,7 +65,7 @@ class update_dnszones(PostUpdate):
 return (False, False, [])
 
 try:
-zones = api.Command.dnszone_find(all=True)['result']
+zones = api.Command.dnszone_find(all=True, raw=True)['result']
 except errors.NotFound:
 self.log.info('No DNS zone to update found')
 return (False, False, [])
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel