Re: [Freeipa-devel] [PATCH 0169] Fix: read_ip_address should return CheckedIPAddress instance instead of string

2014-11-21 Thread Jan Cholasta

Hi,

Dne 20.11.2014 v 17:52 Martin Basti napsal(a):

Ticket: https://fedorahosted.org/freeipa/ticket/4747

Patch attached:


ACK!

Pushed to:
master: 7de424f42541e73ed24a95f1dd90ff4a61e111fa
ipa-4-1: 5b397dced1ef4a1eea7b3636fc71c2b7108a0b25

Honza

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH 0169] Fix: read_ip_address should return CheckedIPAddress instance instead of string

2014-11-20 Thread Martin Basti

Ticket: https://fedorahosted.org/freeipa/ticket/4747

Patch attached:

--
Martin Basti

From 98ce62ec68a406fa30c4a9ed4249ebb1b1330e4e Mon Sep 17 00:00:00 2001
From: Martin Basti mba...@redhat.com
Date: Thu, 20 Nov 2014 17:45:46 +0100
Subject: [PATCH] Fix: read_ip_addresses should return ipaddr object

Interactive prompt callback returns list of str instead of CheckedIPAddress
instances.

Ticket: https://fedorahosted.org/freeipa/ticket/4747
---
 ipaserver/install/installutils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/install/installutils.py b/ipaserver/install/installutils.py
index 9cda26f16f09ddc04e708a94858fb039ee3a8360..b23b404d224e1fef6679582d9e9333ca533ca872 100644
--- a/ipaserver/install/installutils.py
+++ b/ipaserver/install/installutils.py
@@ -243,7 +243,7 @@ def read_ip_addresses(host_name, fstore):
 except Exception, e:
 print Error: Invalid IP Address %s: %s % (ip, e)
 continue
-ips.append(ip)
+ips.append(ip_parsed)
 
 return ips
 
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel