Re: [Freeipa-devel] [PATCH 0293] ipatests: Invoke class install methods properly with respect

2014-12-16 Thread Petr Viktorin

On 12/16/2014 11:57 AM, Tomas Babej wrote:


On 12/16/2014 11:49 AM, Tomas Babej wrote:

On 12/15/2014 11:32 AM, Tomas Babej wrote:

Hi,

Multihost object was is not passed to the install method in the super
construction.
This fixes setup errors in AD Trust, Forced client reenrollment, CALess
and Sudo
tests.

https://fedorahosted.org/freeipa/ticket/4809


Attaching updated patch, along with few related fixes.



Upon further inspection, it seems I managed to miss two cases in the
first patch. Fixed.


Thank you!
ACK, pushed to master: b7e58ce74623c5bb52ce7c74c4242dfda3786a3a


--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] [PATCH 0293] ipatests: Invoke class install methods properly with respect

2014-12-15 Thread Tomas Babej
Hi,

Multihost object was is not passed to the install method in the super
construction.
This fixes setup errors in AD Trust, Forced client reenrollment, CALess
and Sudo
tests.

https://fedorahosted.org/freeipa/ticket/4809

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 


From c5d4ae6b59c6b5143e8926c3274c8c5db99fdb99 Mon Sep 17 00:00:00 2001
From: Tomas Babej tba...@redhat.com
Date: Mon, 15 Dec 2014 11:29:05 +0100
Subject: [PATCH] ipatests: Invoke class install methods properly with respect
 to pytest-multihost

Multihost object was is not passed to the install method in the super construction.
This fixes setup errors in AD Trust, Forced client reenrollment, CALess and Sudo
tests.

https://fedorahosted.org/freeipa/ticket/4809
---
 ipatests/test_integration/test_caless.py | 2 +-
 ipatests/test_integration/test_forced_client_reenrollment.py | 2 +-
 ipatests/test_integration/test_sudo.py   | 2 +-
 ipatests/test_integration/test_trust.py  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ipatests/test_integration/test_caless.py b/ipatests/test_integration/test_caless.py
index 426a4ad549e7f7cd1b35ab2da814f4c496a14762..637db71119a333962d7f545470addb86cb0ab019 100644
--- a/ipatests/test_integration/test_caless.py
+++ b/ipatests/test_integration/test_caless.py
@@ -68,7 +68,7 @@ def assert_error(result, stderr_text, returncode=None):
 class CALessBase(IntegrationTest):
 @classmethod
 def install(cls, mh):
-super(CALessBase, cls).install()
+super(CALessBase, cls).install(mh)
 cls.cert_dir = tempfile.mkdtemp(prefix=ipatest-)
 cls.pem_filename = os.path.join(cls.cert_dir, 'root.pem')
 scriptfile = os.path.join(os.path.dirname(__file__),
diff --git a/ipatests/test_integration/test_forced_client_reenrollment.py b/ipatests/test_integration/test_forced_client_reenrollment.py
index 709bc72c9037e4c37202ad91fce07ca4395f0bf6..ed9800d49f77f6f292f59c22509a9f568041200b 100644
--- a/ipatests/test_integration/test_forced_client_reenrollment.py
+++ b/ipatests/test_integration/test_forced_client_reenrollment.py
@@ -36,7 +36,7 @@ class TestForcedClientReenrollment(IntegrationTest):
 
 @classmethod
 def install(cls, mh):
-super(TestForcedClientReenrollment, cls).install()
+super(TestForcedClientReenrollment, cls).install(mh)
 tasks.install_master(cls.master)
 tasks.install_replica(cls.master, cls.replicas[0], setup_ca=False)
 cls.BACKUP_KEYTAB = os.path.join(
diff --git a/ipatests/test_integration/test_sudo.py b/ipatests/test_integration/test_sudo.py
index 38427a78808a316a385acf0fef5b3efdce415d07..8454d19ce675127649bb1e17cf7087add898c114 100644
--- a/ipatests/test_integration/test_sudo.py
+++ b/ipatests/test_integration/test_sudo.py
@@ -31,7 +31,7 @@ class TestSudo(IntegrationTest):
 
 @classmethod
 def install(cls):
-super(TestSudo, cls).install()
+super(TestSudo, cls).install(mh)
 
 cls.client = cls.clients[0]
 
diff --git a/ipatests/test_integration/test_trust.py b/ipatests/test_integration/test_trust.py
index 9a7ab2948673b104c009a192be0ced974ac30e1a..772a50842f7c251b78d68fd4bd3c91668f580d50 100644
--- a/ipatests/test_integration/test_trust.py
+++ b/ipatests/test_integration/test_trust.py
@@ -34,7 +34,7 @@ class ADTrustBase(IntegrationTest):
 
 @classmethod
 def install(cls, mh):
-super(ADTrustBase, cls).install()
+super(ADTrustBase, cls).install(mh)
 cls.ad = cls.ad_domains[0].ads[0]
 cls.install_adtrust()
 cls.check_sid_generation()
-- 
1.9.3

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel