Re: [Freeipa-devel] [PATCH 0344] tests: service_plugin: Make sure the cert is decoded from

2015-07-22 Thread Tomas Babej 
On 07/22/2015 08:40 AM, Martin Babinsky wrote:
 On 07/21/2015 06:01 PM, Tomas Babej wrote:
 Hi,

 this patch fixes an issue in tests where the certificate was not decoded
 from base64 representation.

 Tomas



 ACK
 

Pushed to:
master: 12395a94f38f4db23e356a6f7d96629155c02532
ipa-4-2: 0fe31fa58a45ad0f957d3b6e4eb87d776c41bd48

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0344] tests: service_plugin: Make sure the cert is decoded from

2015-07-22 Thread Martin Babinsky 

On 07/21/2015 06:01 PM, Tomas Babej wrote:

Hi,

this patch fixes an issue in tests where the certificate was not decoded
from base64 representation.

Tomas




ACK

--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0344] tests: service_plugin: Make sure the cert is decoded from

2015-07-21 Thread Tomas Babej 
Hi,

this patch fixes an issue in tests where the certificate was not decoded
from base64 representation.

Tomas

From 4bf69e94984d72d1f52dfb2afd65574c73838ece Mon Sep 17 00:00:00 2001
From: Tomas Babej tba...@redhat.com
Date: Tue, 21 Jul 2015 13:58:13 +0200
Subject: [PATCH] tests: service_plugin: Make sure the cert is decoded from
 base64

---
 ipatests/test_xmlrpc/test_service_plugin.py | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ipatests/test_xmlrpc/test_service_plugin.py b/ipatests/test_xmlrpc/test_service_plugin.py
index 006c35999a2ca8540116ff62b8ee6176b2518c2f..78ba60a691a625d3fdce2ea0df0f2aef9ef3caac 100644
--- a/ipatests/test_xmlrpc/test_service_plugin.py
+++ b/ipatests/test_xmlrpc/test_service_plugin.py
@@ -383,7 +383,11 @@ class test_service(Declarative):
 
 dict(
 desc='Update %r with a bad certificate' % service1,
-command=('service_mod', [service1], dict(usercertificate=badservercert)),
+command=(
+'service_mod',
+[service1],
+dict(usercertificate=base64.b64decode(badservercert))
+),
 expected=errors.CertificateOperationError(
 error=u'Issuer CN=IPA Test Certificate Authority does not ' +
 u'match the expected issuer'),
-- 
2.1.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code