[Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Jan Cholasta 

Hi,

the attached patch fixes .

Honza

--
Jan Cholasta
From 8a1327f8810608c958da985bf3b304c12376849e Mon Sep 17 00:00:00 2001
From: Jan Cholasta 
Date: Tue, 12 Jan 2016 15:41:43 +0100
Subject: [PATCH] ipalib: assume version 2.0 when skip_version_check is enabled

https://fedorahosted.org/freeipa/ticket/5601
---
 ipalib/frontend.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipalib/frontend.py b/ipalib/frontend.py
index 8d5142a..5b730b1 100644
--- a/ipalib/frontend.py
+++ b/ipalib/frontend.py
@@ -28,7 +28,6 @@ import six
 
 from ipapython.version import API_VERSION
 from ipapython.ipa_log_manager import root_logger
-from ipalib.capabilities import VERSION_WITHOUT_CAPABILITIES
 from ipalib.base import NameSpace
 from ipalib.plugable import Plugin
 from ipalib.parameters import create_param, Param, Str, Flag
@@ -429,7 +428,7 @@ class Command(HasParam):
 if version_provided:
 self.verify_client_version(unicode(options['version']))
 elif self.api.env.skip_version_check and not self.api.env.in_server:
-options['version'] = VERSION_WITHOUT_CAPABILITIES
+options['version'] = u'2.0'
 else:
 options['version'] = API_VERSION
 params = self.args_options_2_params(*args, **options)
-- 
2.4.3

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Martin Kosek 
On 01/12/2016 03:46 PM, Jan Cholasta wrote:
> Hi,
> 
> the attached patch fixes .
> 
> Honza

I see you set the version to 2.0. As I am reading
https://bugzilla.redhat.com/show_bug.cgi?id=1297811#c1
, shouldn't the minimal version be set to something higher than 2.49?

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Jan Pazdziora 
On Tue, Jan 12, 2016 at 03:58:49PM +0100, Martin Kosek wrote:
> On 01/12/2016 03:46 PM, Jan Cholasta wrote:
> > Hi,
> > 
> > the attached patch fixes .
> > 
> > Honza
> 
> I see you set the version to 2.0. As I am reading
> https://bugzilla.redhat.com/show_bug.cgi?id=1297811#c1
> , shouldn't the minimal version be set to something higher than 2.49?

No. We set it to 2.51 and that fails with RHEL 6 installation. That's why
we have the bugzilla 1297811.

I cannot comment on the suitability of the 2.0 value in particular -- not
sure who and where checks that value.

-- 
Jan Pazdziora
Senior Principal Software Engineer, Identity Management Engineering, Red Hat

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 539] ipalib: assume version 2.0 when skip_version_check is enabled

2016-01-12 Thread Martin Basti 



On 12.01.2016 16:07, Jan Cholasta wrote:

On 12.1.2016 15:58, Martin Kosek wrote:

On 01/12/2016 03:46 PM, Jan Cholasta wrote:

Hi,

the attached patch fixes 
.


Honza


I see you set the version to 2.0. As I am reading
https://bugzilla.redhat.com/show_bug.cgi?id=1297811#c1
, shouldn't the minimal version be set to something higher than 2.49?


It shouldn't, as that would not fix the issue, there would still be 
versions where skip_version_check is ineffective. Something higher 
than 2.49 is what we have right now - 2.51.


Failures are expected, the documentation for skip_version_check 
clearly states that "Can lead to errors/strange behavior when newer 
clients talk to older servers. Use with caution."



ACK

Pushed to:
master:
6b2b173a4d6b1cd8789e87d0392dd86c980f858a ipalib: assume version 2.0 when 
skip_version_check is enabled


ipa-4-3:
51d5150b9b5ffe6ff5f77230a389a9091f28ce48 ipalib: assume version 2.0 when 
skip_version_check is enabled


ipa-4-2:
7a4a3b099e82fc566d3f353d42009a5f0ef6be18 ipalib: assume version 2.0 when 
skip_version_check is enabled


--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code