[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes martbab commented: """ Reverted the Fix install scripts debugging commit. master: * dc873007f8616ab9e77f903e235ba49f45ecde37 Revert "Fix install scripts debugging" """ See the full comment at https://github.com/freeipa/freeipa/pull/184#issuecomment-256334107 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes abbra commented: """ I'm fine with that (revert --debug commit). Either alternative (make Configurable be aware of the debug or do a refactoring of an installer) is roughly going into the same direction. I certainly see a reason to have Configurable gain knowledge about --debug option to allow it to configure specific services in debug mode which would go beyond just setting up loggers in the installer itself. """ See the full comment at https://github.com/freeipa/freeipa/pull/184#issuecomment-256325663 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes martbab commented: """ Note that the installer class has no access to debug options. These are only used in the containing ConfigureTool class to set up loggers (see https://git.fedorahosted.org/cgit/freeipa.git/tree/ipapython/install/cli.py#n267) and are not passed to the Configurable object. We may need to revert commit #2 to unblock installation of FreeIPA server. The proper fix shall be implemented as a part of installer refactoring effort. """ See the full comment at https://github.com/freeipa/freeipa/pull/184#issuecomment-256324868 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes pvoborni commented: """ The debug patch breaks test installation on RHEL. Following exception is printed only if install.py is adjusted to print exception on line ``` ipa : ERRORdebug Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/ipaserver/install/server/install.py", line 899, in install if options.debug: File "/usr/lib/python2.7/site-packages/ipapython/install/core.py", line 550, in __getattr__ raise AttributeError(name) AttributeError: debug ``` I.e. there is no Knob debug nor verbose unless it is somehow copied. I don't know why it doesn't break install on Fedora but imho the patch cannot work. This might also be the "there is no ipa-client-install.log" issue. Because it fails just before calling ipa-client-install. """ See the full comment at https://github.com/freeipa/freeipa/pull/184#issuecomment-256165308 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
On ma, 24 loka 2016, Simo Sorce wrote: On Mon, 2016-10-24 at 17:38 +0200, abbra wrote: URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes abbra commented: """ ACK from my side if you would split the commit into two small ones, please. Note that CI integration is currently broken so travis says your commits failed the checks. """ Done, and the CI seem happy ? Yes, thank you. I acked the request. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
On Mon, 2016-10-24 at 17:38 +0200, abbra wrote: > URL: https://github.com/freeipa/freeipa/pull/184 > Title: #184: Minor install script fixes > > abbra commented: > """ > ACK from my side if you would split the commit into two small ones, please. > > Note that CI integration is currently broken so travis says your commits > failed the checks. > """ Done, and the CI seem happy ? Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#184][comment] Minor install script fixes
URL: https://github.com/freeipa/freeipa/pull/184 Title: #184: Minor install script fixes abbra commented: """ ACK from my side if you would split the commit into two small ones, please. Note that CI integration is currently broken so travis says your commits failed the checks. """ See the full comment at https://github.com/freeipa/freeipa/pull/184#issuecomment-255777099 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
