[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread npmccallum
  URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket

npmccallum commented:
"""
This PR can be closed.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/469#issuecomment-280660092
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread npmccallum
  URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket

npmccallum commented:
"""
We shouldn't use either. We should use RemoveOnStop= now.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/469#issuecomment-280657734
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread simo5
  URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket

simo5 commented:
"""
@tiran I do not know, @npmccallum may know.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/469#issuecomment-280656899
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-17 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket

tiran commented:
"""
Would you rather use ```/usr/bin/rm -f``` to only ignore missing files but 
propagate permission errors? I'm not sure why unlink was used in favor of rm. 
@simo5 ?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/469#issuecomment-280604757
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#469][comment] Ignore unlink error in ipa-otpd.socket

2017-02-16 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/469
Title: #469: Ignore unlink error in ipa-otpd.socket

HonzaCholasta commented:
"""
This will ignore all errors, not just file does not exist. Are we OK with that?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/469#issuecomment-280291966
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code