Re: [Freeipa-devel] [PATCH] 208 Entity select widget improvements

2011-07-18 Thread Endi Sukma Dewata

On 7/18/2011 11:52 AM, Endi Sukma Dewata wrote:

On 7/18/2011 10:44 AM, Endi Sukma Dewata wrote:

The IPA.entity_select_widget has been modified into a searchable and
editable drop down list.

Ticket #1361


Fixed z-index problem and renamed base class to IPA.combobox_widget.


Included new icon provided by ayoung.

--
Endi S. Dewata
From db48ea67e0569ffc2650dbb651ef6e32f51b789c Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Fri, 15 Jul 2011 12:18:59 -0500
Subject: [PATCH] Entity select widget improvements

The IPA.entity_select_widget has been modified into a searchable and
editable drop down list. The base functionality has been extracted
into IPA.combobox_widget.

Ticket #1361
---
 install/ui/aci.js|   41 +++--
 install/ui/combobox_open.png |  Bin 0 - 274 bytes
 install/ui/details.js|   53 +++---
 install/ui/dialog.js |6 +-
 install/ui/entitle.js|8 +-
 install/ui/hbac.js   |4 +-
 install/ui/host.js   |9 +-
 install/ui/ipa.css   |  216 --
 install/ui/jsl.conf  |2 +-
 install/ui/policy.js |9 +-
 install/ui/search.js |   11 +-
 install/ui/serverconfig.js   |5 +-
 install/ui/service.js|7 +-
 install/ui/test/aci_tests.js |2 +-
 install/ui/test/details_tests.js |   14 +-
 install/ui/test/widget_tests.js  |   11 +-
 install/ui/user.js   |   12 +-
 install/ui/widget.js |  378 --
 18 files changed, 472 insertions(+), 316 deletions(-)
 create mode 100755 install/ui/combobox_open.png

diff --git a/install/ui/aci.js b/install/ui/aci.js
index 1a95af0e7f9d663fccb98d472aee3b2a8fee2868..54050c79cfa2f88fae87907cae67bb71affb7082 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -50,7 +50,8 @@ IPA.entity_factories.permission = function() {
 }]}).
 standard_association_facets().
 adder_dialog({
-height: '400',
+width: 500,
+height: 400,
 fields:[
 'cn',
 {
@@ -165,12 +166,16 @@ IPA.entity_factories.delegation = function() {
 fields:[
 'aciname',
 {
-factory:IPA.entity_select_widget,
-name: 'group', entity: 'group'
+factory: IPA.entity_select_widget,
+name: 'group',
+other_entity: 'group',
+other_field: 'cn'
 },
 {
-factory:IPA.entity_select_widget,
-name: 'memberof', entity: 'group',
+factory: IPA.entity_select_widget,
+name: 'memberof',
+other_entity: 'group',
+other_field: 'cn',
 join: true
 },
 {
@@ -183,13 +188,19 @@ IPA.entity_factories.delegation = function() {
 fields:[
 'aciname',
 {
-factory:IPA.entity_select_widget,
-name: 'group', entity: 'group', undo: false
+factory: IPA.entity_select_widget,
+name: 'group',
+other_entity: 'group',
+other_field: 'cn',
+undo: false
 },
 {
-factory:IPA.entity_select_widget,
-name: 'memberof', entity: 'group',
-join: true, undo: false
+factory: IPA.entity_select_widget,
+name: 'memberof',
+other_entity: 'group',
+other_field: 'cn',
+join: true,
+undo: false
 },
 {
 factory:IPA.attributes_widget,
@@ -402,8 +413,12 @@ IPA.target_section = function(spec) {
 cols: 30, rows: 1,
 undo: that.undo
 });
-that.group_select = IPA.entity_select_widget(
-{name: 'targetgroup', entity:'group', undo: that.undo});
+that.group_select = IPA.entity_select_widget({
+name: 'targetgroup',
+other_entity: 'group',
+other_field: 'cn',
+undo: that.undo
+});
 that.type_select = IPA.select_widget({name: 'type', undo: that.undo});
 that.attribute_table = IPA.attributes_widget({
 name: 'attrs', undo: that.undo});
@@ -506,7 +521,7 @@ IPA.target_section = function(spec) {
 that.group_select.create(span);
 },
 load: function(record){
-that.group_select.entity_select.val(record.targetgroup);
+that.group_select.list.val(record.targetgroup);
 },
 save: 

Re: [Freeipa-devel] [PATCH] 208 Entity select widget improvements

2011-07-18 Thread Adam Young

On 07/18/2011 02:39 PM, Endi Sukma Dewata wrote:

On 7/18/2011 11:52 AM, Endi Sukma Dewata wrote:

On 7/18/2011 10:44 AM, Endi Sukma Dewata wrote:

The IPA.entity_select_widget has been modified into a searchable and
editable drop down list.

Ticket #1361


Fixed z-index problem and renamed base class to IPA.combobox_widget.


Included new icon provided by ayoung.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK.  Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel