Re: [Freeipa-devel] [PATCH] 676 rpcserver: fix local vs utc time comparison
On 25.6.2014 17:36, Jan Cholasta wrote: Hi, On 24.6.2014 16:02, Petr Vobornik wrote: login_password did not work properly in timezones other than +0h because local time was compared with utc time. ACK. pushed to master: 1c94edd3a09711d85ba099bd815c0bdd8f0210c1 rpcserver: fix local vs utc time comparison Bug introduced in: https://fedorahosted.org/freeipa/ticket/4339 We should review other code for invalid usage of datetime.now() All other uses of datetime.now() predate LDAP datetime decoding, so I think we are fine. Honza -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 676 rpcserver: fix local vs utc time comparison
Hi, On 24.6.2014 16:02, Petr Vobornik wrote: login_password did not work properly in timezones other than +0h because local time was compared with utc time. ACK. Bug introduced in: https://fedorahosted.org/freeipa/ticket/4339 We should review other code for invalid usage of datetime.now() All other uses of datetime.now() predate LDAP datetime decoding, so I think we are fine. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel