[Freeipmi-devel] [bug #53810] Lan channels number

[Albert Chu]

Update of bug #53810 (project freeipmi):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Freeipmi-devel] [bug #53810] Lan channels number

[Albert Chu]

Follow-up Comment #2, bug #53810 (project freeipmi):

ends up also need to update

ipmi-channel-spec.h

I'll go ahead and make the change.

This will be in the next release of FreeIPMI 1.6.2, which I will try to
release semi-soon.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Freeipmi-devel] [bug #53810] Lan channels number

[Albert Chu]

Update of bug #53810 (project freeipmi):

Severity:  3 - Normal => 4 - Important  

___

Follow-up Comment #1:

You're right, looks like I missed that errata change.

I can apply your patch as is.  PLMK who to give credit to.  Or if you wish,
you could alternately supply a pull request at:

https://github.com/chu11/freeipmi-mirror

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Freeipmi-devel] [bug #53810] Lan channels number

[anonymous]

URL:
  

 Summary: Lan channels number
 Project: GNU FreeIPMI
Submitted by: None
Submitted on: Wed 02 May 2018 02:38:13 PM UTC
Category: bmc-config
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Improper Behaviour
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
Operating System: GNU/Linux

___

Details:

Hello,

Description of the problem:
Lan channels 8 to 11 are not usable (usefull for Tyan motherboards using lan
channel 8)


According to the errata 409 ("E409 Addendum - Additional IPMI Channel Number
support") these channels are now usable for lan, you could consult this errata
here :
https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/second-gen-interface-spec-v4.pdf

This documentation also refer to these new available la channels in "Table 6-,
Channel Number Assignments" page 49 (75 of the pdf) :
https://www.intel.com.tw/content/www/tw/zh/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html

Fix:

This minor patch enable the new lan channels, it work for my usage but I did
not check the whole code and I probably miss some others required patchs or
checks.

diff --git a/libfreeipmi/util/ipmi-channel-util.c
b/libfreeipmi/util/ipmi-channel-util.c
index 67056f7..95b1c91 100644
--- a/libfreeipmi/util/ipmi-channel-util.c
+++ b/libfreeipmi/util/ipmi-channel-util.c
@@ -43,7 +43,7 @@
 
 #include "freeipmi-portability.h"
 
-#define IPMI_NUM_CHANNELS 8
+#define IPMI_NUM_CHANNELS 12
 
 static int
 _get_channel_numbers (ipmi_ctx_t ctx,
@@ -68,7 +68,7 @@ _get_channel_numbers (ipmi_ctx_t ctx,
   goto cleanup;
 }
 
-  /* Channel numbers range from 0 - 7 */
+  /* Channel numbers range from 0 - 11 */
   for (i = 0; i < IPMI_NUM_CHANNELS; i++)
 {
   uint8_t channel_medium_type_read;


Regards




___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.gnu.org/


___
Freeipmi-devel mailing list
Freeipmi-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/freeipmi-devel