[FreeRDP-devel] ERROR: unexpected license packet

2019-01-24 Thread Andrey Vasilkin via FreeRDP-devel

Hi.

After updating the source code, I get the following error when trying to 
connect to one of my servers (Windows Server 2008 R2 Enterprise);


[13:39:13:250] [13731:206b4b80] [ERROR][com.freerdp.core.license] - 
unexpected license packet.
[13:39:13:259] [13731:206b4b80] [ERROR][com.freerdp.core.transport] - 
transport_check_fds: transport->ReceiveCallback() - -1
[13:39:13:263] [13731:206b4b80] [ERROR][com.freerdp.core] - 
freerdp_set_last_error ERRCONNECT_CONNECT_TRANSPORT_FAILED [0x0002000D]
[13:39:13:268] [13731:206b4b80] [ERROR][com.freerdp.core] - 
freerdp_post_connect failed
[13:39:13:275] [13731:206b4b80] [ERROR][com.freerdp.client.OS2] - 
Freerdp connect error


But I can connect to other servers with the same and other Windoze 
versions. The problem disappeared when I commented on the next piece of 
code:


libfreerdp\core\license.c , function icense_generate_hwid() :

BOOL license_generate_hwid(rdpLicense* license)
{
const BYTE *hashTarget;
size_t targetLen;
BYTE macAddress[6];

ZeroMemory(license->HardwareId, HWID_LENGTH);

if (license->rdp->settings->OldLicenseBehaviour)
{
ZeroMemory(macAddress, sizeof(macAddress));
hashTarget = macAddress;
targetLen = sizeof(macAddress);
}
else
{
wStream s;
const char *hostname = license->rdp->settings->ClientHostname;
/*
[ Next code causes an error "unexpected license packet". ]

Stream_StaticInit(, license->HardwareId, 4);
Stream_Write_UINT32(, PLATFORMID);
Stream_Free(, TRUE);
*/

...

This new code has appeared here:

https://github.com/FreeRDP/FreeRDP/commit/f4b7a27c2bb7506f0a82c72570ea171a93d094d6


___
FreeRDP-devel mailing list
FreeRDP-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel


Re: [FreeRDP-devel] bug in channels/drive

2019-01-24 Thread Bernhard Miklautz via FreeRDP-devel
Hi Andrey,

On Thu, Jan 24, 2019 at 03:56:04PM +1100, Andrey Vasilkin via FreeRDP-devel 
wrote:
> File channels/drive/client/drive_file.c , function
> drive_file_set_information() , in block "case
> FileAllocationInformation:" :
> 
> we read input data in variable "size";
> Stream_Read_INT64(input, size);
> but than we use liSize for set file position:
> if (!SetFilePointerEx(file->file_handle, liSize, NULL, FILE_BEGIN))
> 
> I've insert next line before call SetFilePointerEx():
> liSize = *((PLARGE_INTEGER));
you are right that was an issue. But you possibly want to update your
code base to master as this was already fixed some days ago:
https://github.com/FreeRDP/FreeRDP/blob/ac0c91300b032f8a8610368dbbd0dca86d81eeeb/channels/drive/client/drive_file.c#L618

Thank you and best regards,
Bernhard


___
FreeRDP-devel mailing list
FreeRDP-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel