Re: [ft-devel] Re: meddlesome compiler warns against for( ...; ...;...) ;
On Wed, 15 Oct 2008 00:42:36 +0900 [EMAIL PROTECTED] wrote: Turner has post easier-to-eye fix, I will commit within 24 hours. Sorry for my lated action. The FreeType2 tree in my Macintosh is too messed to check an atomic test. http://lists.nongnu.org/archive/html/freetype-devel/2008-10/msg00030.html Just I've committed to CVS. Thank you everybody! Regards, mpsuzuki ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel
[ft-devel] missing 'const' on tt_post_default_names causes problems with writable static data
Here's another small problem I found when porting to 2.3.7. There's a missing 'const' in the declaration of the array tt_post_default_names. It causes the pointers to be non-const, and that creates 1032 (4 * 258) bytes of writable static data, which prevents builds from working for several platforms including Symbian OS. The fix is (line 67 of ttpost.c): static const FT_String* tt_post_default_names[258] = - static const FT_String* const tt_post_default_names[258] = Best regards, Graham ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel
RE: [ft-devel] discrepancy in underline offset
You're welcome - and I apologise for not noticing this when I moved to 2.3.7. Did you put some variant of my original explanatory comment in? It might help. Here it is: /* Adjust underline position from top edge to centre of stroke to convert TrueType meaning to FreeType meaning. */ Best regards, Graham -Original Message- From: Werner LEMBERG [mailto:[EMAIL PROTECTED] Sent: 12 October 2008 13:12 To: [EMAIL PROTECTED] Cc: freetype-devel@nongnu.org Subject: Re: [ft-devel] discrepancy in underline offset More than a year ago Graham wrote: root-underline_position = (FT_Short)(face-postscript.underlinePosition - (face-postscript.underlineThickness / 2)); Somehow this old email escaped my attention. I've now applied this fix to the sources so that the implementation follows the documentation. Thanks! Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] discrepancy in underline offset
Did you put some variant of my original explanatory comment in? I only added a link to the OpenType specs. /* Adjust underline position from top edge to centre of stroke to convert TrueType meaning to FreeType meaning. */ I've added this now. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] missing 'const' on tt_post_default_names causes problems with writable static data
static const FT_String* tt_post_default_names[258] = - static const FT_String* const tt_post_default_names[258] = Applied, thanks. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/freetype-devel
