Re: [ft-devel] .gitignore in release tarballs
On 06/30/2011 07:17 AM, Miles Bader wrote: Marek Kasik mka...@redhat.com writes: our building system warned me that there are .gitignore files distributed in release tarballs of freetype. Could you remove them in upcoming releases? Why should .gitignore files be removed from release tarballs? They're part of the source code. A build system that warns about them would seem to be broken. -Miles OK, I just thought that you don't want git specific files there since you've removed git specific directories. I'll workaround it in freetype's spec file. Regards Marek ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] .gitignore in release tarballs
our building system warned me that there are .gitignore files distributed in release tarballs of freetype. Could you remove them in upcoming releases? Why should .gitignore files be removed from release tarballs? They're part of the source code. Mhmm, not really IMHO. For me, `.gitignore' is rather an administrative metafile (like the `.git' subdirectory). Consequently, such files make only sense in the git repository but not in the tarball. OK, I just thought that you don't want git specific files there since you've removed git specific directories. I'll workaround it in freetype's spec file. If you are in a hurry, please provide a patch so that `make dist' ignores those files :-) Otherwise, I'll fix this, but without any guarantee of a time frame. Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] .gitignore in release tarballs
Hi; On Thu, Jun 30, 2011 at 12:24 PM, Werner LEMBERG w...@gnu.org wrote: OK, I just thought that you don't want git specific files there since you've removed git specific directories. I'll workaround it in freetype's spec file. If you are in a hurry, please provide a patch so that `make dist' ignores those files :-) Otherwise, I'll fix this, but without any guarantee of a time frame. Since freetype no longer uses CVS attached patch could do the job. Regards. diff --git a/builds/toplevel.mk b/builds/toplevel.mk index d9fbee0..d552a4a 100644 --- a/builds/toplevel.mk +++ b/builds/toplevel.mk @@ -199,7 +199,7 @@ dist: currdir=`pwd` ; \ for f in `find . -wholename '*/.git' -prune \ - -o -name .cvsignore \ + -o -name .gitignore \ -o -type d \ -o -print` ; do \ ln -s $$currdir/$$f tmp/$$f ; \ ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] .gitignore in release tarballs
Hi, On 06/30/2011 12:24 PM, Werner LEMBERG wrote: If you are in a hurry, please provide a patch so that `make dist' ignores those files :-) Otherwise, I'll fix this, but without any guarantee of a time frame. I'm not in a hurry with this, next release is ok for me. Sorry for not providing a patch in the first message. On 06/30/2011 12:30 PM, İsmail Dönmez wrote: Since freetype no longer uses CVS attached patch could do the job. Thanks for preparing the patch :). Regards Marek ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] .gitignore in release tarballs
Since freetype no longer uses CVS attached patch could do the job. Applied, thanks! Werner ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
[ft-devel] .gitignore in release tarballs
Hi, our building system warned me that there are .gitignore files distributed in release tarballs of freetype. Could you remove them in upcoming releases? Regards Marek P.S.: I see that they are there since 2.3.12 ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
Re: [ft-devel] .gitignore in release tarballs
Marek Kasik mka...@redhat.com writes: our building system warned me that there are .gitignore files distributed in release tarballs of freetype. Could you remove them in upcoming releases? Why should .gitignore files be removed from release tarballs? They're part of the source code. A build system that warns about them would seem to be broken. -Miles -- Next to fried food, the South has suffered most from oratory. -- Walter Hines Page ___ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel
