Re: [ft-devel] Improving documentation re vertical metrics

2011-05-23 Thread Behdad Esfahbod 
On 05/18/11 12:21, Werner LEMBERG wrote:
 
 I'm adding vertical text support to HarfBuzz and it occurred to me
 that FreeType's vertBearingY and vertAdvance metrics have a Y
 coordinate growing downwards, while all other Y coordinates in
 FreeType grow upwards.  Thought that may be worth documenting.
 
 Could you provide a patch, please?

How about this:

diff --git a/include/freetype/freetype.h b/include/freetype/freetype.h
index 3956676..602e475 100644
--- a/include/freetype/freetype.h
+++ b/include/freetype/freetype.h
@@ -226,10 +226,12 @@ FT_BEGIN_HEADER
   /*  Left side bearing for vertical layout.   */
   /*   */
   /*vertBearingY ::*/
-  /*  Top side bearing for vertical layout.*/
+  /*  Top side bearing for vertical layout.  Larger positive values*/
+  /*  mean further below the vertical glyph origin.*/
   /*   */
   /*vertAdvance :: */
-  /*  Advance height for vertical layout.  */
+  /*  Advance height for vertical layout.  Positive values mean the*/
+  /*  glyph has a positive advance downward.   */
   /*   */
   /* Note*/
   /*If not disabled with @FT_LOAD_NO_HINTING, the values represent */

___
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [ft-devel] Improving documentation re vertical metrics

2011-05-23 Thread Werner LEMBERG 

 How about this:

Applied, thanks.


Werner

___
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel

[ft-devel] Improving documentation re vertical metrics

2011-05-18 Thread Behdad Esfahbod 
Hi,

I'm adding vertical text support to HarfBuzz and it occurred to me that
FreeType's vertBearingY and vertAdvance metrics have a Y coordinate growing
downwards, while all other Y coordinates in FreeType grow upwards.  Thought
that may be worth documenting.

Cheers,
behdad

___
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel

Re: [ft-devel] Improving documentation re vertical metrics

2011-05-18 Thread Werner LEMBERG 

 I'm adding vertical text support to HarfBuzz and it occurred to me
 that FreeType's vertBearingY and vertAdvance metrics have a Y
 coordinate growing downwards, while all other Y coordinates in
 FreeType grow upwards.  Thought that may be worth documenting.

Could you provide a patch, please?


Werner

___
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel