Core dump in FvwmIconBox
Hi All,
I was just trying to have a look at the new spangly mozilla icons
and found a core dump in FvwmIconBox. Patch attached.
Cheers,
Tim.
Index: modules/ChangeLog
===
RCS file: /u/phippst/share/cvsroot/fvwm/modules/ChangeLog,v
retrieving revision 1.31
diff -u -r1.31 ChangeLog
--- modules/ChangeLog 2002/08/27 11:46:33 1.31
+++ modules/ChangeLog 2002/08/28 11:32:24
@@ -1,3 +1,7 @@
+2002-08-28 Hippo
+ * FvwmIconBox/icons.c:
+ Fixed core dump
+
2002-08-26 Mikhael Goikhman [EMAIL PROTECTED]
* FvwmButtons/dynamic.c:
Index: modules/FvwmIconBox/icons.c
===
RCS file: /u/phippst/share/cvsroot/fvwm/modules/FvwmIconBox/icons.c,v
retrieving revision 1.7
diff -u -r1.7 icons.c
--- modules/FvwmIconBox/icons.c 2002/08/14 13:14:57 1.7
+++ modules/FvwmIconBox/icons.c 2002/08/28 11:28:31
@@ -236,9 +236,15 @@
/
void GetIconFromFile(struct icon_info *item)
{
- char *path = NULL;
+ char *path = PictureFindImageFile(item-icon_file, imagePath, R_OK);
FvwmPictureAttributes fpa;
+ if (NULL == path)
+ {
+ fprintf(stderr, [FvwmIconBox] cannot find %s on ImagePath
%s\n,
+ item-icon_file, imagePath);
+ return;
+ }
fpa.mask = FPAM_NO_ALLOC_PIXELS; /* olicha why ? */
if (Iconcolorset = 0 Colorset[Iconcolorset].do_dither_icon)
{
Re: Core dump in FvwmIconBox
On Wed, Aug 28, 2002 at 12:40:29PM +0100, Tim Phipps wrote: Hi All, I was just trying to have a look at the new spangly mozilla icons and found a core dump in FvwmIconBox. Patch attached. CVS, or 2.4.x or both? Bye Dominik ^_^ ^_^ -- Dominik Vogt, mail: [EMAIL PROTECTED], phone: 0721/91374-382 Schlund + Partner AG, Erbprinzenstr. 4-12, D-76133 Karlsruhe -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
CVS domivogt: * Applied IconBox core dump fix.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt02/08/28 06:50:39 Modified files: . : ChangeLog modules/FvwmIconBox: icons.c Log message: * Applied IconBox core dump fix. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Core dump in FvwmIconBox
Dominik Vogt wrote: CVS, or 2.4.x or both? CVS, but it might be in older releases Cheers, Tim. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Notification: incoming/919
FVWM Bug Tracking notification new message incoming/919 Message summary for PR#919 From: [EMAIL PROTECTED] Subject: Mozilla 1.1 maximize window drift Date: Wed, 28 Aug 2002 11:27:44 -0500 0 replies 0 followups ORIGINAL MESSAGE FOLLOWS From [EMAIL PROTECTED] Wed Aug 28 11:27:47 2002 Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17k5fX-0006kC-00 for [EMAIL PROTECTED]; Wed, 28 Aug 2002 11:27:47 -0500 Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by util2.math.uh.edu with esmtp (Exim 4.10) id 17k5fX-M9-00 for [EMAIL PROTECTED]; Wed, 28 Aug 2002 11:27:47 -0500 Received: from localhost ([127.0.0.1] ident=65534) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17k5fU-0006k3-00 for [EMAIL PROTECTED]; Wed, 28 Aug 2002 11:27:44 -0500 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Mozilla 1.1 maximize window drift Message-Id: [EMAIL PROTECTED] Date: Wed, 28 Aug 2002 11:27:44 -0500 Full_Name: Tore Nordstrand Version: 2.5.3 CVS_Date: OS: suse 8 X_Server: xfree86 nvidia Submission from: (NULL) (80.212.160.173) The new maximize (f11) function in mozilla causes mozilla yo absorb the total size of window + border, leading to window drift. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
CVS migo: * fixed no window context for StartMenu
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: migo02/08/28 14:44:31 Modified files: modules: ChangeLog modules/FvwmTaskBar: FvwmTaskBar.c Log message: * fixed no window context for StartMenu -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
FVWM: How to use Conditional Commands to...
... test for a specific page number? I mean, everytime I enter a specific page (lets say 0 1) I want to execute a command, so how can I build a function that test for that without using Piperead? It seems to me that the built-in conditional commands only matchs windows... -- Christian Lyra POP-PR - RNP Thus spake the master programmer: ``It is time for you to leave.'' The Tao Of Programing -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: How to use Conditional Commands to...
On 28 Aug 2002 13:43:25 +, Mikhael Goikhman wrote: On 28 Aug 2002 10:34:16 -0300, Christian Lyra wrote: ... test for a specific page number? I mean, everytime I enter a specific page (lets say 0 1) I want to execute a command, so how can I build a function that test for that without using Piperead? It seems to me that the built-in conditional commands only matchs windows... You don't use conditional commands for this, since this is useless, You listen to the new_page event using, for example, FvwmEvent. FvwmBacker may help too depending on what you want to do. A small addition. FvwmBacker has a built-in support for checking for a specific page, but if you want to use FvwmEvent you do need PipeRead. Regards, Mikhael. -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: How to use Conditional Commands to...
Thanks!!! FvwmBacker can do exactly what I want! On Wednesday 28 August 2002 10:59, Mikhael Goikhman wrote: On 28 Aug 2002 13:43:25 +, Mikhael Goikhman wrote: On 28 Aug 2002 10:34:16 -0300, Christian Lyra wrote: ... test for a specific page number? I mean, everytime I enter a specific page (lets say 0 1) I want to execute a command, so how can I build a function that test for that without using Piperead? It seems to me that the built-in conditional commands only matchs windows... You don't use conditional commands for this, since this is useless, You listen to the new_page event using, for example, FvwmEvent. FvwmBacker may help too depending on what you want to do. A small addition. FvwmBacker has a built-in support for checking for a specific page, but if you want to use FvwmEvent you do need PipeRead. Regards, Mikhael. -- Christian Lyra POP-PR - RNP Thus spake the master programmer: ``A well-written program is its own heaven; a poorly-written program is its own hell.'' The Tao Of Programing -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: How to use Conditional Commands to...
At 13:59 + 2002/08/28, Mikhael Goikhman wrote: A small addition. FvwmBacker has a built-in support for checking for a specific page, but if you want to use FvwmEvent you do need PipeRead. Checking for what page it is changing to, right? Sometimes I'd like to know additionally what page it is changing *from*. -- Victor Eijkhout [EMAIL PROTECTED] tel: 865 974 9308 (W), 865 673 6998 (H), 865 974 8296 (F) http://www.cs.utk.edu/~eijkhout/ -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: .fvwm2rc syntax guide?
Date: Mon, 26 Aug 2002 14:45:50 +0200 From: Imre Vida [EMAIL PROTECTED] On Sun, Aug 25, 2002 at 08:29:50PM -0400, Dan Espen wrote: Are you aware that you can start fvwm with no config file at all, press F1 or any mouse button on the root window and fvwm will offer to create a few different configurations for you? yes, it is mentioned in the man but it appears at line 365 in a very modest 2 line sentence (context: .fvwm2rc). it is repeated in a somewhat more extended version at ~1100 (Built in KM Bindings). while I agree that structurally these are apropriate locations, i believe not many newbies can spot and pick up the message (i personally missed them when first read/ scanned through the manual. mind you it is 8000+ lines of heavy text). I think it would be helpful to - to put a To the Impatient setion at the very begining of the man with this info - mention this also in one of the INSTALL and/or README files (e.g. README.sysrc). My own `newbie' experience years ago was a burning baptism, rather than a gentle drift into expertise. So this question is to others, expecially recent newbies. A tutorial document has been suggested. Would it be useful to have one that helps a new user build ``their own'' simple .fvwm2rc from almost scratch, without wholesale importing of any ready made themes or bits of configuration? Each FVWM feature would be explained, as the user includes it into their config, and they could run FVWM at various stages as it develops. They would start off from a known place: a really simple config that contains only emacs, or another editor of their choice (nedit?), a restart menu item, and perhaps a program runnign to monitor the error output from FVWM (e.g. the error monitor from AnotherLevelUp). This initial config would be explained in the first section. Next sections would give step by step instructions for adding more features. Later sections would tell them what is wanted, but get them to find out how to do it from the man pages, and try it first with FvwmConsole before adding it to their file, etc.. It would cover the sort of things that newbies want to do: choose a background, get an xterm on the menu, choose window frame features, have a task bar, have multiple desk tops,have some fvwm buttons, ... Is this a sensible sort of order? Perhaps it could evolve through it's readers sugegsting what things they want to do next. By the end the student of fvwm (!) would have basically copied a simple config, but feel able to risk being creative. Maybe some exercises could be suggested for further learning. Does such a thing already exist? Would it be welcome? I'm not quite on the verge of volnteering to think about writing something... Best wishes, John Latham -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: How to use Conditional Commands to...
On 28 Aug 2002 13:21:03 -0400, Victor Eijkhout wrote: At 13:59 + 2002/08/28, Mikhael Goikhman wrote: A small addition. FvwmBacker has a built-in support for checking for a specific page, but if you want to use FvwmEvent you do need PipeRead. Checking for what page it is changing to, right? Sometimes I'd like to know additionally what page it is changing *from*. Then you should keep the variable to store the old one. Something like the following in the event handler function: PipeRead ' do something with $[OLD_PAGE_NX] and $[OLD_PAGE_NY] ' # save the current page for the next event SetEnv OLD_PAGE_NX $[page.nx] SetEnv OLD_PAGE_NY $[page.ny] If you really need such non-trivial functionality, you may consider to write a small module in perl listening to M_NEW_PAGE and doing the work. Regards, Mikhael. -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
FVWM: Window context Task Bar bug
Hi. I think I have just noticed a bug which I believe might be explained as
follows. In fvwm 2.4.8, when the start button is activated, the menu is run
with no window context, and so any window operations cause the user to first
pick a window. This is good. In fvwm 2.5.{2,3} when the start button is
activated, the menu is run with the taskbar itself as the window context. This
is not good. The up shot is, when say a move operation is chosen from the
start menu in 2.5, it is the task bar that gets moved ! :-)
I recall in some of the early 2.2.x versions, the start menu was invoked with
an illegal window context, which caused FVWM to crash if a window operation
was invoked via it. I suggested a patch at the time to fix it to have the root
window as focus, and sumbitted that to fvwm and to Red Hat. This is probably a
coincidence, but you never know... :-)
Best wishes, John Latham
--
Visit the official FVWM web page at URL: http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm in the body of a
message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: Window context Task Bar bug
On 28 Aug 2002 19:21:41 +0100, John Latham wrote:
Hi. I think I have just noticed a bug which I believe might be explained
as follows. In fvwm 2.4.8, when the start button is activated, the menu
is run with no window context, and so any window operations cause the
user to first pick a window. This is good. In fvwm 2.5.{2,3} when the
start button is activated, the menu is run with the taskbar itself as
the window context. This is not good. The up shot is, when say a move
operation is chosen from the start menu in 2.5, it is the task bar that
gets moved ! :-)
I recall in some of the early 2.2.x versions, the start menu was invoked
with an illegal window context, which caused FVWM to crash if a window
operation was invoked via it. I suggested a patch at the time to fix it
to have the root window as focus, and sumbitted that to fvwm and to Red
Hat. This is probably a coincidence, but you never know... :-)
No, this was broken since 2.5.1, I think.
Fixed in cvs.
Regards,
Mikhael.
--
Visit the official FVWM web page at URL: http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm in the body of a
message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: Re: Build time on cygwin ?
On Thu, 02 May 2002 13:56:50 -0400 David S Goldberg [EMAIL PROTECTED] wrote: Roughly 20 minutes from ./configure etc etc through make install on my HP500 laptop, which I think is a 750MHz PIII (sorry, I'm not at it right now to check). -- Dave Goldberg [EMAIL PROTECTED] On my Mac 8500/120 MHz 2.5.3 takes about 30 minutes to compile. Not bad with 32 MB RAM! But X got to go when compiling. And the 2.4.6 in Cygwin is allright, I think. Mattias Andersson, Falun Sweden -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: FVWM: fvwm for MacOS X
On Tue, 16 Jul 2002 13:32:46 +0100 (BST) Toby Blake [EMAIL PROTECTED] wrote: I can find a trace of 2.4.7, but it only contains man pages. If you want fvwm packages for your OS, ask OpenDarwin people, or install from sources. Go to fink.sourceforge.net and install fink. Then you can get fvwm2 version 2.4.7 without any problem. It works fine for me. And you want fink no matter what. Trust me on that. Great, thanks very much for the info. And also thanks to Mikhael for the reply. Cheers Toby I agree with that compile from the sources. I am writing this on a Mac 8500/120 using 2.5.3 CVS. And yes, under LinuxPPC - what else! :) Everything work if you have X running in OS X. Check out X on X! Mattias Andersson, Falun Sweden -- Visit the official FVWM web page at URL: http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
