Re: PositionPlacement UnderMouse to force window on-screen?

2009-02-17 Thread Thomas Adam 
2009/2/17 Bob Woodside :
> On Tuesday 17 February 2009, Dominik Vogt wrote:
>> Yes.  I just don't have enough time to take care of all the
>> patches.  I think you should have commit privileges for CVS to
>> speed things up.  Changes in behaviour should be discussed in
>> advance anyway.
>>
>> Any other opinions?
>
> Agreed.

Well, that's an honour indeed -- thank you all for your encouragement.
 I work quite differently to how most others have on this list over
the years -- I am a strong believer in peer-review, and despite my
having commit access, I will still send patches through for larger
functionality before commiting anything -- it works rather well.

I will email Jason Tibbets with the relevant details later on.

Thanks again,

-- Thomas Adam

Re: PositionPlacement UnderMouse to force window on-screen?

2009-02-17 Thread Bob Woodside 
On Tuesday 17 February 2009, Dominik Vogt wrote:
> Yes.  I just don't have enough time to take care of all the
> patches.  I think you should have commit privileges for CVS to
> speed things up.  Changes in behaviour should be discussed in
> advance anyway.
>
> Any other opinions?

Agreed.

Re: PositionPlacement UnderMouse to force window on-screen?

2009-02-17 Thread Dan Espen 
Dominik Vogt  writes:

> On Mon, Feb 16, 2009 at 10:00:53PM +, Thomas Adam wrote:
> Yes.  I just don't have enough time to take care of all the
> patches.  I think you should have commit privileges for CVS to
> speed things up.  Changes in behaviour should be discussed in
> advance anyway.
>
> Any other opinions?

Agreed.

Re: PositionPlacement UnderMouse to force window on-screen?

2009-02-17 Thread Dominik Vogt 
On Mon, Feb 16, 2009 at 10:00:53PM +, Thomas Adam wrote:
> When the old UnderMousePlacement style got folded in to
> PositionPlacement, if the window or part of it was going to be placed
> off-screen, then the window was forced on-screen.  Given that
> "PositionPlacement UnderMouse" just equates to "m-50w m-50w", it's
> technically possible to fudge this just by tweaking the offsets, but
> that's sub-optimal.
> 
> Is this behaviour of having the window partially or completely in some
> cases off-screen desirable?  Granted it's technically what the user
> asked for but it seems wrong to me.

Yes, I think that's wrong.

>  If I patched this, would it be accepted [1]?

Yes.  I just don't have enough time to take care of all the
patches.  I think you should have commit privileges for CVS to
speed things up.  Changes in behaviour should be discussed in
advance anyway.

Any other opinions?

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

PositionPlacement UnderMouse to force window on-screen?

2009-02-16 Thread Thomas Adam 
Hi,

When the old UnderMousePlacement style got folded in to
PositionPlacement, if the window or part of it was going to be placed
off-screen, then the window was forced on-screen.  Given that
"PositionPlacement UnderMouse" just equates to "m-50w m-50w", it's
technically possible to fudge this just by tweaking the offsets, but
that's sub-optimal.

Is this behaviour of having the window partially or completely in some
cases off-screen desirable?  Granted it's technically what the user
asked for but it seems wrong to me.  If I patched this, would it be
accepted [1]?

Kindly,

-- Thomas Adam

[1] I appreciate I have a number of outstanding ""patches"" sent to
this list, so I suppose I really ought to address the balance and not
let any of them stagnate.  ;)