[fvwmorg/fvwm] 9a57db: Fix typos/spelling errors

2016-12-27 Thread Thomas Adam 
  Branch: refs/heads/master
  Home:   https://github.com/fvwmorg/fvwm
  Commit: 9a57db1dd4ae6423a991a6aa0f399c8e137728f8
  
https://github.com/fvwmorg/fvwm/commit/9a57db1dd4ae6423a991a6aa0f399c8e137728f8
  Author: Thomas Adam 
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
M doc/commands/BugOpts.xml
M doc/commands/Style.xml
M doc/commands/TitleStyle.xml
M doc/fvwm/images.xml
M fvwm/builtins.c
M fvwm/events.c
M modules/FvwmBacker/FvwmBacker.1.in
M modules/FvwmButtons/FvwmButtons.1.in
M modules/FvwmCommand/FvwmCommand.c
M modules/FvwmPerl/FvwmPerl.1
M modules/FvwmProxy/FvwmProxy.1.in
M modules/FvwmScript/Instructions.c
M modules/FvwmScript/Widgets/Widget.c

  Log Message:
  ---
  Fix typos/spelling errors

Via Debian linter.

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

2016-12-27 Thread Jaimos Skriletz 
On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>> Hello,
>>
>> This was reported by a Debian user. Please retain the CC to
>> 849355-forwar...@bugs.debian.org in your response, so that
>> the Debian BTS has a record.
>>
>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>> opening and closing windows. I too have had this issue in 2.6.7 (and
>> previous versions) so I can also say it affects my Debian system.
>
>
> I don't get any such messages with or without FvwmIconMan.  Can
> you give detailed instructions pelase?
>

Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
patches, but I will compile a version without patches and test.

Run FvwnIconMan by itself with no configuration, so FvwmIconMan is in
its own window (if FvwmIconMan was swallowed in FvwmButtons I did not
notice this warning).

Once FvwmIconMan is running, run xterm, warning appears, close xterm,
warning appears again.

I tested this with other windows and modules. FvwmScript modules
seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
do with transient windows or not (just something I noticed).

If you are not able to reproduce this wonder if it is something
specific with Debian's xserver, let me know what other output you
would want.

jaimos

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

2016-12-27 Thread Dominik Vogt 
On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>  wrote:
> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
> >>> Hello,
> >>>
> >>> This was reported by a Debian user. Please retain the CC to
> >>> 849355-forwar...@bugs.debian.org in your response, so that
> >>> the Debian BTS has a record.
> >>>
> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
> >>> previous versions) so I can also say it affects my Debian system.
> >>
> >>
> >> I don't get any such messages with or without FvwmIconMan.  Can
> >> you give detailed instructions pelase?
> >>
> >
> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
> > patches, but I will compile a version without patches and test.
> >
> 
> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
> same issue.
> 
> >
> > I tested this with other windows and modules. FvwmScript modules
> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
> > do with transient windows or not (just something I noticed).
> >
> 
> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
> was not producing the warning was it was configured so FvwmIconMan did
> not create a button for that window.
> 
> After further testing the warning seems to be due to be caused by
> adding/removing the button for a window from FvwmIconMan. Windows that
> appear there trigger the warning but ones that don't appear don't.

Still no luck to reproduce it.  After said message there should
always be this one which prints all the details of the window and
the faulty hints:

fvwm_msg(
WARN, "GetWindowSizeHints",
"The application window (id %#lx)\n"
"  \"%s\" has broken size hints (%s).\n"
"fvwm is ignoring those hints.  "
"  hint override = %d, flags = %lx\n"
"  min_width = %d, min_height = %d, "
"max_width = %d, max_height = %d\n"
"  width_inc = %d, height_inc = %d\n"
"  min_aspect = %d/%d, max_aspect = %d/%d\n"
"  base_width = %d, base_height = %d\n"
"  win_gravity = %d\n",

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

2016-12-27 Thread Jaimos Skriletz 
On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  wrote:
> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>>  wrote:
>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>> >>> Hello,
>> >>>
>> >>> This was reported by a Debian user. Please retain the CC to
>> >>> 849355-forwar...@bugs.debian.org in your response, so that
>> >>> the Debian BTS has a record.
>> >>>
>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
>> >>> previous versions) so I can also say it affects my Debian system.
>> >>
>> >>
>> >> I don't get any such messages with or without FvwmIconMan.  Can
>> >> you give detailed instructions pelase?
>> >>
>> >
>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
>> > patches, but I will compile a version without patches and test.
>> >
>>
>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
>> same issue.
>>
>> >
>> > I tested this with other windows and modules. FvwmScript modules
>> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
>> > do with transient windows or not (just something I noticed).
>> >
>>
>> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
>> was not producing the warning was it was configured so FvwmIconMan did
>> not create a button for that window.
>>
>> After further testing the warning seems to be due to be caused by
>> adding/removing the button for a window from FvwmIconMan. Windows that
>> appear there trigger the warning but ones that don't appear don't.
>
> Still no luck to reproduce it.  After said message there should
> always be this one which prints all the details of the window and
> the faulty hints:
>
> fvwm_msg(
> WARN, "GetWindowSizeHints",
> "The application window (id %#lx)\n"
> "  \"%s\" has broken size hints (%s).\n"
> "fvwm is ignoring those hints.  "
> "  hint override = %d, flags = %lx\n"
> "  min_width = %d, min_height = %d, "
> "max_width = %d, max_height = %d\n"
> "  width_inc = %d, height_inc = %d\n"
> "  min_aspect = %d/%d, max_aspect = %d/%d\n"
> "  base_width = %d, base_height = %d\n"
> "  win_gravity = %d\n",
>

I get no other output after the warning, so that message is never
printed to stderr on my system.

Unsure if this helps, but I did enable BugOpts DebugCRMotionMethod,
and get the output

_cdim: not moved 0x55927d4a8990 'FvwmIconMan'

after each time the warning is produced.

Spelling errors and manpage patchs

2016-12-27 Thread Jaimos Skriletz 
Hello,

In making the Debian package lintian found some spelling errors in
both the man page and some binaries. Patch attached.

Additionally a Debian user noticed that the manpage under ClickTime
did not specify this also configures time for double clicks. The
second patch just adds a small note to this.

jaimos
Description: Add double click time info to ClickTime in manpage.
Author: Jaimos Skriletz 
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=567387
--- a/doc/commands/ClickTime.xml
+++ b/doc/commands/ClickTime.xml
@@ -26,4 +26,6 @@ is 150 milliseconds.  Omitting the delay
 ClickTime
 to the default.
 
+ClickTime also specifies the delay
+between two clicks to be interpreted as a double-click.
 
Description: Spelling Errors.
 Fixes spelling errors found by lintian.
Author: Jaimos Skriletz 
Last-Update: 2016-12-05
--- a/modules/FvwmCommand/FvwmCommand.c
+++ b/modules/FvwmCommand/FvwmCommand.c
@@ -532,7 +532,7 @@ void usage(void)
   fprintf (stderr,
 	   "  -v  print version number\n");
   fprintf (stderr,
-	   "  -w   waiting time for the reponse from fvwm\n");
+	   "  -w   waiting time for the response from fvwm\n");
   fprintf (stderr, "\nDefault fifo names are ~/.%sC and ~/.%sM\n",
 	   MYNAME, MYNAME);
   fprintf (stderr, "Default waiting time is 500,000 us\n");
--- a/fvwm/events.c
+++ b/fvwm/events.c
@@ -4213,7 +4213,7 @@ void InitEventHandlerJumpTable(void)
 	{
 		/* should never happen */
 		fvwm_msg(ERR, "InitEventHandlerJumpTable",
-			 "Faild to initialize event handlers");
+			 "Failed to initialize event handlers");
 		exit(1);
 	}
 	if (FShapesSupported)
@@ -4231,7 +4231,7 @@ void InitEventHandlerJumpTable(void)
 shape_jump_table))
 		{
 			fvwm_msg(ERR, "InitEventHandlerJumpTable",
- "Faild to init Shape event handler");
+ "Failed to init Shape event handler");
 		}
 	}
 
--- a/fvwm/builtins.c
+++ b/fvwm/builtins.c
@@ -611,7 +611,7 @@ static char *ReadMultiPixmapDecor(char *
 			{
 fvwm_msg(
 	ERR, "ReadMultiPixmapDecor",
-	"Colorset shoule take one or two "
+	"Colorset should take one or two "
 	"positive integers as argument");
 			}
 			else
--- a/modules/FvwmScript/Instructions.c
+++ b/modules/FvwmScript/Instructions.c
@@ -794,7 +794,7 @@ static char *FuncSendMsgAndGet(int *NbAr
   FILE *f;
   struct timeval timeout;
 
-  /* comunication name */
+  /* communication name */
   (*NbArg)++;
   com_name=CalcArg(TabArg,NbArg);
   /* the command send to the receiver */
@@ -851,7 +851,7 @@ static char *FuncSendMsgAndGet(int *NbAr
   if (i > IN_FIFO_NBR_OF_TRY)
   {
 	fprintf(stderr,
-	 "[%s][GetMsgAndGet]: <> No in fifo %s for comunication %s\n",
+	 "[%s][GetMsgAndGet]: <> No in fifo %s for communication %s\n",
 	  ScriptName,in_fifo,com_name);
 	close(filedes);
 	err = 1;
@@ -908,7 +908,7 @@ static char *FuncSendMsgAndGet(int *NbAr
   if (i > OUT_FIFO_NBR_OF_TRY)
   {
 	fprintf(stderr,
-	 "[%s][GetMsgAndGet]: <>: No out fifo %s for comunication %s\n",
+	 "[%s][GetMsgAndGet]: <>: No out fifo %s for communication %s\n",
 	 ScriptName,out_fifo,com_name);
 	err = 1;
 	break;
--- a/modules/FvwmBacker/FvwmBacker.1.in
+++ b/modules/FvwmBacker/FvwmBacker.1.in
@@ -101,7 +101,7 @@ Cancels the effect of the previous optio
 It it possible to replace FvwmBacker's configuration at run-time,
 although it is not yet possible to remove existing configuration
 lines.  This is done by simply removing the old configuration from
-withing fvwm and then read a new one.  This can be done in many
+within fvwm and then read a new one.  This can be done in many
 ways, for example by using an fvwm function or one of the modules
 .BR FvwmCommand " or " FvwmConsole .
 
--- a/modules/FvwmButtons/FvwmButtons.1.in
+++ b/modules/FvwmButtons/FvwmButtons.1.in
@@ -988,7 +988,7 @@ inside the relief and padding.
 
 .SH DYNAMICAL ACTIONS
 A running FvwmButtons instance may receive some commands at run time.
-This is achived using the fvwm command
+This is achieved using the fvwm command
 .nf
 .sp
 SendToModule FvwmButtons-Alias  
--- a/modules/FvwmPerl/FvwmPerl.1
+++ b/modules/FvwmPerl/FvwmPerl.1
@@ -204,7 +204,7 @@ The following 5 options are only valid t
 If \fB\-\-nolock\fR is added here, \fBModuleSynchronous\fR returns immediately. Note that \fBModule\fR returns immediately regardless of this option.
 .SH "USING ALIAS"
 .IX Header "USING ALIAS"
-Aliases allow to have several module invocations and work separately with all invocations, here is an example:
+Aliases allow one to have several module invocations and work separately with all invocations, here is an example:
 .PP
 .Vb 4
 \&ModuleSynchronous FvwmPerl FvwmPerl\-JustTest
@@ -214,7 +214,7 @@ Aliases allow to have several module inv
 .Ve
 .SH "PREPROCESSING EXAMPLE"
 .IX Header "PREPROCESSING EXAMPLE"
-One of the effective proprocessing solutions is to pass the whole fvwm configuration with embeded perl code to \*(L"FvwmPerl

Re: Spelling errors and manpage patchs

2016-12-27 Thread Thomas Adam 
On Tue, Dec 27, 2016 at 05:46:47PM -0700, Jaimos Skriletz wrote:
> Hello,
> 
> In making the Debian package lintian found some spelling errors in
> both the man page and some binaries. Patch attached.

Applied.

> Additionally a Debian user noticed that the manpage under ClickTime
> did not specify this also configures time for double clicks. The
> second patch just adds a small note to this.

Not applying.

-- Thomas Adam

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

2016-12-27 Thread Jaimos Skriletz 
On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
 wrote:
> On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>>> Hello,
>>>
>>> This was reported by a Debian user. Please retain the CC to
>>> 849355-forwar...@bugs.debian.org in your response, so that
>>> the Debian BTS has a record.
>>>
>>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>>> opening and closing windows. I too have had this issue in 2.6.7 (and
>>> previous versions) so I can also say it affects my Debian system.
>>
>>
>> I don't get any such messages with or without FvwmIconMan.  Can
>> you give detailed instructions pelase?
>>
>
> Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
> patches, but I will compile a version without patches and test.
>

Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
same issue.

>
> I tested this with other windows and modules. FvwmScript modules
> seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
> do with transient windows or not (just something I noticed).
>

Nevermind this, FvwmIdentify is not a traisnent window, the reason it
was not producing the warning was it was configured so FvwmIconMan did
not create a button for that window.

After further testing the warning seems to be due to be caused by
adding/removing the button for a window from FvwmIconMan. Windows that
appear there trigger the warning but ones that don't appear don't.

jaimos

[fvwmorg/fvwm] 9a57db: Fix typos/spelling errors

2016-12-27 Thread Thomas Adam 
  Branch: refs/heads/ta/spelling
  Home:   https://github.com/fvwmorg/fvwm
  Commit: 9a57db1dd4ae6423a991a6aa0f399c8e137728f8
  
https://github.com/fvwmorg/fvwm/commit/9a57db1dd4ae6423a991a6aa0f399c8e137728f8
  Author: Thomas Adam 
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
M doc/commands/BugOpts.xml
M doc/commands/Style.xml
M doc/commands/TitleStyle.xml
M doc/fvwm/images.xml
M fvwm/builtins.c
M fvwm/events.c
M modules/FvwmBacker/FvwmBacker.1.in
M modules/FvwmButtons/FvwmButtons.1.in
M modules/FvwmCommand/FvwmCommand.c
M modules/FvwmPerl/FvwmPerl.1
M modules/FvwmProxy/FvwmProxy.1.in
M modules/FvwmScript/Instructions.c
M modules/FvwmScript/Widgets/Widget.c

  Log Message:
  ---
  Fix typos/spelling errors

Via Debian linter.

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

2016-12-27 Thread Jaimos Skriletz 
On Tue, Dec 27, 2016 at 5:28 PM, Jaimos Skriletz
 wrote:
> On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  wrote:
>> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
>>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>>>  wrote:
>>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>>> >>> Hello,
>>> >>>
>>> >>> This was reported by a Debian user. Please retain the CC to
>>> >>> 849355-forwar...@bugs.debian.org in your response, so that
>>> >>> the Debian BTS has a record.
>>> >>>
>>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
>>> >>> previous versions) so I can also say it affects my Debian system.
>>> >>
>>> >>
>>> >> I don't get any such messages with or without FvwmIconMan.  Can
>>> >> you give detailed instructions pelase?
>>> >>
>>> >
>>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
>>> > patches, but I will compile a version without patches and test.
>>> >
>>>
>>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
>>> same issue.
>>>
>>> >
>>> > I tested this with other windows and modules. FvwmScript modules
>>> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
>>> > do with transient windows or not (just something I noticed).
>>> >
>>>
>>> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
>>> was not producing the warning was it was configured so FvwmIconMan did
>>> not create a button for that window.
>>>
>>> After further testing the warning seems to be due to be caused by
>>> adding/removing the button for a window from FvwmIconMan. Windows that
>>> appear there trigger the warning but ones that don't appear don't.
>>
>> Still no luck to reproduce it.  After said message there should
>> always be this one which prints all the details of the window and
>> the faulty hints:
>>
>> fvwm_msg(
>> WARN, "GetWindowSizeHints",
>> "The application window (id %#lx)\n"
>> "  \"%s\" has broken size hints (%s).\n"
>> "fvwm is ignoring those hints.  "
>> "  hint override = %d, flags = %lx\n"
>> "  min_width = %d, min_height = %d, "
>> "max_width = %d, max_height = %d\n"
>> "  width_inc = %d, height_inc = %d\n"
>> "  min_aspect = %d/%d, max_aspect = %d/%d\n"
>> "  base_width = %d, base_height = %d\n"
>> "  win_gravity = %d\n",
>>
>
> I get no other output after the warning, so that message is never
> printed to stderr on my system.
>
> Unsure if this helps, but I did enable BugOpts DebugCRMotionMethod,
> and get the output
>
> _cdim: not moved 0x55927d4a8990 'FvwmIconMan'
>
> after each time the warning is produced.

Further testing, if I set the ManagerGeometry to something like 5x3 so
FvwmIconMan doesn't resize itself, I no longer get the warning. It is
only with the default like 0x1, causing the window to grow/shrink I
get the warning.

Wild guess, could it be some timing issue during the resizing of the
window when adding/removing a button cause the window's current size
to become invalid as per the warning?

jaimos

[fvwmorg/fvwm] 0d5b7b: fvwm-menu-desktop improvements

2016-12-27 Thread somiaj 
  Branch: refs/heads/fvwm2-stable
  Home:   https://github.com/fvwmorg/fvwm
  Commit: 0d5b7be18d60b426ef52202d69e6f5a1371ec059
  
https://github.com/fvwmorg/fvwm/commit/0d5b7be18d60b426ef52202d69e6f5a1371ec059
  Author: somiaj 
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
M bin/fvwm-menu-desktop-config.fpl
M bin/fvwm-menu-desktop.in
R modules/FvwmForm/FvwmForm-GenOptionHelp
R modules/FvwmForm/FvwmForm-MultiMenuHelp
R modules/FvwmForm/FvwmForm-SingleMenuHelp
A modules/FvwmForm/FvwmForm-XDGMenuHelp
A modules/FvwmForm/FvwmForm-XDGOptionsHelp
M modules/FvwmForm/Makefile.am

  Log Message:
  ---
  fvwm-menu-desktop improvements

 * Added the ability to load defaults from the
   FvwmForm-XDGMenu-Config data file.

 * The top level menu now has two additional items:
 'Regenerate' - Regenerates menu with saved options.
 'Configure' - Opens up FvwmForm-XDGMenu.
   Added --include-items [config|regenerate|both|none]

 * Modified the FvwmForm-XDGMenu-Config interface and renamed it.

 * The default menu name is now XDGMenu (was FvwmMenu)

 * Added --without-titles option. Needed to overrided the config
   file if titles are set there.

[fvwmorg/fvwm] 81eb91: NEWS

2016-12-27 Thread Thomas Adam 
  Branch: refs/heads/fvwm2-stable
  Home:   https://github.com/fvwmorg/fvwm
  Commit: 81eb913db452004068be53d7858ecaeefbbfa3f3
  
https://github.com/fvwmorg/fvwm/commit/81eb913db452004068be53d7858ecaeefbbfa3f3
  Author: Thomas Adam 
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
M NEWS

  Log Message:
  ---
  NEWS

[fvwmorg/fvwm] e3db89: fvwm-menu-desktop more improvements

2016-12-27 Thread somiaj 
  Branch: refs/heads/fvwm2-stable
  Home:   https://github.com/fvwmorg/fvwm
  Commit: e3db89576ed1b0b70835ce6ea0dd9f7ccc580bc1
  
https://github.com/fvwmorg/fvwm/commit/e3db89576ed1b0b70835ce6ea0dd9f7ccc580bc1
  Author: somiaj 
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
M NEWS
M bin/fvwm-menu-desktop-config.fpl
M bin/fvwm-menu-desktop.1.in
M bin/fvwm-menu-desktop.in
M modules/FvwmForm/FvwmForm-XDGMenuHelp
M modules/FvwmForm/FvwmForm-XDGOptionsHelp

  Log Message:
  ---
  fvwm-menu-desktop more improvements

 * Added --dynamic option.
 * Added --regen-cmd to control the Regenerate menu item.
 * Made titles default and added --without-titles
 * Added --all-menus to generate all menus and not try to
   find the best one.
 * Updated man page to reflect the changes.
 * Updated News file about changes.