Re: StyleById patch voting thread
On Thu, Jun 19, 2003 at 03:51:50PM +0200, [EMAIL PROTECTED] wrote: On Sat, Jun 07, 2003 at 07:20:12PM +0200, Olivier Chapuis wrote: On Mon, May 19, 2003 at 01:44:27PM +0200, Dominik Vogt wrote: Should the StyleById patch be applied before 2.6? Please cast your votes here. Seems that there is no conclusion here. It seems that there is two votes for it (me and Mikhael) one vote against (Dominik) and one unclear vote (Dan). So I ask for more votes and clarification (Dan?). For that I send an other version of the patch (attached). I've followed all the advice (I can follow) that I get in this thread. In particular, I've followed all the remarks (as I can) of Dominik regarding the code. So, Dominik I even hope you revert your vote (very little hope ...). I don't know about your hope, but the chance that I do is zero. It is not the right time. The reason of my hope is that the new version of the patch take in account the reasons why you reject it. You give 7 arguments. The new patch handle arguments 3, 4 and 6. Moreover, I've worked on argument 5 and style list simplification has been improved. About 1 and 2 I can just say that I do not _think_ that the patch can cause instability. Finally, I do not understand argument 7. But, maybe the most important is that there is 4 votes for the patch (Dan, Mikhael, Olivier and Tim) and one vote against (Dominik). So, I think we should apply the patch. Regards, Olivier -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
CVS domivogt: * Applied Start button font fix in FvwmTaskBar.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt03/06/24 01:41:23 Modified files: . : AUTHORS modules: ChangeLog modules/FvwmTaskBar: Start.c Log message: * Applied Start button font fix in FvwmTaskBar. -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Wrong font in FvwmTaskBar
On Tue, Jun 24, 2003 at 01:24:13AM +0300, [EMAIL PROTECTED] wrote: Hi, I've noticed that in the development branch, the Start button from FvwmTaskBar uses the same font as the unselected buttons. I thought that it would be nicer if it used the selected buttons' font, and after looking around in the code, I've seen that this is the author's intention too. So, I've made a small patch that fixes things. I have applied the patch. I also have another question: I would like to implement another goodie for FvwmTaskBar, namely a CPU usage meter. Is anyone interested in such a thing? Should I post the patches once they are ready? Apart from the fact that fvwm-2.5.x is in feature freeze at the moment, we are always interested in patches. In this specific case, I somewhat doubt that it is possible to write a *portable* CPU meter. Keep in mind that fvwm code has to compile and run on any UNIX system and Cygwin. Bye Dominik ^_^ ^_^ -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: StyleById patch voting thread
On Tue, Jun 24, 2003 at 06:40:50AM +0200, Olivier Chapuis wrote: On Thu, Jun 19, 2003 at 03:51:50PM +0200, [EMAIL PROTECTED] wrote: On Sat, Jun 07, 2003 at 07:20:12PM +0200, Olivier Chapuis wrote: On Mon, May 19, 2003 at 01:44:27PM +0200, Dominik Vogt wrote: Should the StyleById patch be applied before 2.6? Please cast your votes here. Seems that there is no conclusion here. It seems that there is two votes for it (me and Mikhael) one vote against (Dominik) and one unclear vote (Dan). So I ask for more votes and clarification (Dan?). For that I send an other version of the patch (attached). I've followed all the advice (I can follow) that I get in this thread. In particular, I've followed all the remarks (as I can) of Dominik regarding the code. So, Dominik I even hope you revert your vote (very little hope ...). I don't know about your hope, but the chance that I do is zero. It is not the right time. The reason of my hope is that the new version of the patch take in account the reasons why you reject it. Nothing on earth can make me agree to adding huge features in feature freeze. You give 7 arguments. The new patch handle arguments 3, 4 and 6. Moreover, I've worked on argument 5 and style list simplification has been improved. As I said before, I reject making facts now that can never be changed again. The way the style list works has always been a mistake. No matter how much time you spend on optimising the style list code, it will always be a memory leak. This logic is due for replacement, not for expansion. About 1 and 2 I can just say that I do not _think_ that the patch can cause instability. It has already consumed much time in pointless arguments that could have been spent stabilising the code. There is a direct relationship between my motivation to work on the remaining problems and the amount of distractions on this list that have nothing to do with it. Finally, I do not understand argument 7. It's an ad-hoc syntax that *will* be thrown away right when we start thinking. I have many enhancements in mind that have no chance of being implemented with this kind of just-throw-in-a-new- command-whenever-it-seems-to-work-for-the-moment approach. But, maybe the most important is that there is 4 votes for the patch (Dan, Mikhael, Olivier and Tim) and one vote against (Dominik). Of course Dan can speak for himself, but according to the mail archive he did neither vote for nor against the patch. Not that I think it matters. So, I think we should apply the patch. Then take the consequences and abandon the idea of a stable 2.6 release. Bye Dominik ^_^ ^_^ -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Wrong font in FvwmTaskBar
[EMAIL PROTECTED] wrote: I also have another question: I would like to implement another goodie for FvwmTaskBar, namely a CPU usage meter. Is anyone interested in such a thing? Should I post the patches once they are ready? IMHO it would be great if you could implement the swallowing-functionality from FvwmButton in FvwmTaskBar. With this you could include any tool like aload, mixers, FvwmPager(!), etc. in the taskbar. (I tried to use FvwmButton as a taskbar, but this is very complicated.) Gert -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
Re: Wrong font in FvwmTaskBar
Dominik Vogt wrote: FvwmButtons with a swallowed FvwmIconMan already does a very good job of emulating a task bar. It would be much easier to just provide a taskbar-like config for FvwmButtons. Ok. Does anybody have a good and general solution for this that could be provided e.g on fvwm.org as a partial configuration example? Gert -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
FvwmButtons relief patch
Hi, I have a patch lying around here (for a few months now) which adds an option to FvwmButtons for customizing the relief (flat/raised/sunken) for both states. Do you suggest i polish it and send it through now, or should i wait for 2.7 ? cheers, Remko -- Visit the official FVWM web page at URL:http://www.fvwm.org/. To unsubscribe from the list, send unsubscribe fvwm-workers in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
