Re: some 64bit cleanup on CVS head (XGetWindowProperty())
There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) signature.asc Description: OpenPGP digital signature
Re: MapWindow directly after UnmapWindow
On Wed, Aug 30, 2006 at 11:20:27AM +0200, Dominik Vogt wrote: I have committed a fix for this. At the end of HandleUnmapNotify, check for pending MapRequests for that window, replace the window and parent with the client window and root, then call dispatch_event immediately. (See attached patch). I can also confirm that the attached fix seems to fix the fpga_editor related problem I reported as bug 4062 in the bugtracker. So it would be good if someone could close the bug report. /Andreas
CVS domivogt: * Fixed map/unmap bug.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: domivogt06/08/31 06:36:56 Modified files: . : ChangeLog NEWS fvwm : events.c ewmh.c Log message: * Fixed map/unmap bug. * Another 64 bit fix.
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0))
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: Hi Renato, The snapshot of today still uses 0 instead of 0L in the argument list for XGetWindowProperty. Maybe you have a modified version, or you are working on a different branch? I've updated now from cvs, and it uses 0L... Maybe the snapshot is outdated. Probably tomorrow it gets updated. (?) BTW, if you are actively working on fvwm, I sugest you use cvs instead of the snapshots. There are times when there is no activity at all, but there are also times where several changes are made in a few hours. It usually pays off to work with the latest code. Cheers Renato PS: Please reply to the list! Yeah, sometimes it happens to me too :) Regards Harri == seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) -- Dipl.-Ing. Harald Dunkel | The bureaucratic mentality is Muehlenbachstr. 3| the only constant in universe. 52134 Herzogenrath, Germany | +49 2407 565 105 | Dr. Leonard (Bones) McCoy
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, seventh guardian [EMAIL PROTECTED] wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: Hi Renato, The snapshot of today still uses 0 instead of 0L in the argument list for XGetWindowProperty. Maybe you have a modified version, or you are working on a different branch? I've updated now from cvs, and it uses 0L... Maybe the snapshot is outdated. Probably tomorrow it gets updated. (?) BTW, if you are actively working on fvwm, I sugest you use cvs instead of the snapshots. There are times when there is no activity at all, but there are also times where several changes are made in a few hours. It usually pays off to work with the latest code. Also, it helps with the network traffic. With cvs you only download what changes, while with the snapshot you download the full fvwm code every time.. Renato Cheers Renato PS: Please reply to the list! Yeah, sometimes it happens to me too :) Regards Harri == seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) -- Dipl.-Ing. Harald Dunkel | The bureaucratic mentality is Muehlenbachstr. 3| the only constant in universe. 52134 Herzogenrath, Germany | +49 2407 565 105 | Dr. Leonard (Bones) McCoy
