Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 12:17 PM, Dominik Vogt  
wrote:

> On Mon, Dec 13, 2021 at 07:40:06AM +, Hegel3DReloaded wrote:

> > > Yes, I fixed a leak at the cost of introducing a crash.
> >
> > I see. It is working now. May I close 
> > https://github.com/fvwmorg/fvwm3/issues/647
>
> Ye, please.

Closed.

> > or you will do it with some description FTR?

> Only if forced to. I'm not good with web tools. :-)

Me niether, but to be honest, Github web is very responsive and without too
much distractions if compared with some corporate shit I need to watch
occasionally or equally bad so called "social networks".

Thomas made really advanced automation system there. I will try to stick
with this as much as I can; I have a feeling it can be fruitful and useful
as project mgmt.


--
Miroslav




Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 08:06:41AM +, Hegel3DReloaded wrote:
> It appears that on "Restart" Front Panel ends up in the +0 +0, upper left
> corner of the screen. It starts ok, it is placed at the bottom center
> part, but something relocates it in the last moment. I remember we had this
> problem often introduced and then fixed again.
>
> Now it seems that
>
> "All (FrontPanel,CirculateHit) PlaceAgain" is causing the problem. That is,
> it behaves differently that on fvwm3 1.0.4 and fvwm 2.6.9. It looks like
> PlaceAgain is ignoring Style for panel:
>
> PositionPlacement $[infostore.frontpanel.pos.placement]
>
> ... where infostore.frontpanel.pos.placement is "screen c 50-50w -0p ewmhiwa"

Oh, I had noticed that but thought it was something to fix in the
move_loop rewrite.  It's fixed now.

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt



Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Dominik Vogt
On Mon, Dec 13, 2021 at 07:40:06AM +, Hegel3DReloaded wrote:
> On Monday, December 13th, 2021 at 2:14 AM, Dominik Vogt  
> wrote:
> > On Mon, Dec 13, 2021 at 12:22:47AM +, Hegel3DReloaded wrote:
>
> > > Is this has something to do with intensive work you and Thomas did
> > > couple weeks ago with new parser?
> >
> > Yes, I fixed a leak at the cost of introducing a crash.
>
> I see. It is working now. May I close 
> https://github.com/fvwmorg/fvwm3/issues/647

Ye, please.

> or you will do it with some description FTR?

Only if forced to.  I'm not good with web tools.  :-)

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt



Re: FvwmPager aspect ratio breaks FvwmButtons panel sliding

2021-12-13 Thread Hegel3DReloaded
On Monday, December 13th, 2021 at 2:51 AM, Dominik Vogt  
wrote:

> I've committed a patch to master that truncates out of range sizes
> and positions to the max/min values instead of rejecting them.

Yes, it is ok now.

> Is there anything else in your config that's out of range? The X
> protocol is limited to 16 bit values for positions (signed) and
> window sizes (unsigned). I.e. -32768 to +32767 and 0 to 65535.

It appears that on "Restart" Front Panel ends up in the +0 +0, upper left
corner of the screen. It starts ok, it is placed at the bottom center
part, but something relocates it in the last moment. I remember we had this
problem often introduced and then fixed again.

Now it seems that

"All (FrontPanel,CirculateHit) PlaceAgain" is causing the problem. That is,
it behaves differently that on fvwm3 1.0.4 and fvwm 2.6.9. It looks like
PlaceAgain is ignoring Style for panel:

PositionPlacement $[infostore.frontpanel.pos.placement]

... where infostore.frontpanel.pos.placement is "screen c 50-50w -0p ewmhiwa"
hardcoding this in styles instead of infostore variable doesn't change this.

A bit of more diagnostic:
If I execute PlaceAgain with FvwmCommand from terminal in this branch, Front
Panel (FvwmButtons) ends up on +0 +0. If I execute "Move screen c 50-50w -0p 
ewmhiwa"
it ends up where it needs to be.

> -32768 is probably the better choice for "out of view" windows.
> Fvwm doesn't use negative coordinates.

Thanks, I will make it like that.

Now if I can only remember what I need to test, and what behaviour to expect
from the FvwmPager. :-) I have set it up on two monitors now, and it looks
consistent on the both screens with and without "Monitor" setting. When
without "Monitor" setting, it shows both screens and it is horizontaly
wide. I have tried with DeskTopScale too, it is ok.


--
Miroslav