Tabs implementation question

[David Maciver]

Hello,
I'm trying to find out how to have multiple windows sharing the same frame.
I'm playing with FvwmTabs but I also want to experiment with a simpler
implementation on my own. I wrote something like the following in the main
fvwm code.

Add tab: (client is the fw-wins.client from another frame)
XReparentWindow(dpy, client, fw-wins.parent, 0, 0);
XResizeWindow(dpy, client, fw-frame_g.width, fw-frame_g.height);
XLowerWindow(dpy, client);
XUnmapWindow(dpy, client);

Next tab: (fw-wins.client is advanced by a linked list)
XMapWindow(dpy, fw-wins.client);
XRaiseWindow(dpy, fw-wins.client);
XSaveContext(dpy, fw-wins.client, FvwmContext, (caddr_t) fw);
rectangle frame_g = fw-frame_g;
frame_force_setup_window(
fw, frame_g.x, frame_g.y, frame_g.width, frame_g.height,
True);

When I switch to another tab, the window works as normal except it doesn't
recieve FocusIn/Out events. This stops the focus decor from changing when the
mouse is in the window. When I switch back to the first tab, it works properly.

There seems to be something special about the first client window because it
was originally in that frame. I thought setting FvwmContext would give each
client the exact same structure but it doesn't. HandleFocusIn is never called
except for the first window. I'm just wondering, what is the solution to this?

David

Possible patches

[David Maciver]

Hello devs,

I've created a patchset[1] to try to improve the way fvwm looks. I've been
using it for a while and made various themes and it seems to work ok. Some
of it is inefficient and incomplete, but I can clean it up if you want.

I was wondering if you were interested in any of the features for the main
branch. I'm not sure what can be added before 2.6/3.0 so I haven't planned
on commiting but some of the patches are quite small and might be worth a
look.

[1] http://abdn.ac.uk/~u15dm4/fvwm/

Re: Possible patches

[David Maciver]

If you search this list for Patch: HasTitle and HasBorders, there is a
thread that may be relevant. I haven't tested the borders condition though.

I've made them so that everything is off by default so I don't think it would
hurt performance much.

I'm using gentoo, there is an unofficial ebuild available here:
http://forums.gentoo.org/viewtopic-t-465973.html

Re: Menu Title patch

[David Maciver]

On Sat, 21 Jan 2006 04:17:43 +, David Maciver wrote:
 Hello,
 
 I've written a patch that lets you configure the menu title and colorset
 separately from the rest of the menu.
 
 I've added menustyle options HilightTitle, TitleColorset and TitleFont.
 
 Here is an example of what it looks like:
 http://metawire.org/~frogb/menu2.png
 
 Patch against CVS:
 http://metawire.org/~frogb/menutitle.patch
 
Could this be included in fvwm? This sort of configuration seems quite
popular in other window managers. It was originally posted on the fvwm
forum[1] where people seem to want it. It seems to work ok for me but is
there anything that should be changed/fixed in the code, or any reason
this cannot be accepted?

[1] http://fvwm.lair.be/viewtopic.php?t=1141

Menu Title patch

[David Maciver]

Hello,

I've written a patch that lets you configure the menu
title and colorset separately from the rest of the menu.

I've added menustyle options HilightTitle, TitleColorset
and TitleFont.

Here is an example of what it looks like:
http://metawire.org/~frogb/menu2.png

Patch against CVS:
http://metawire.org/~frogb/menutitle.patch

I can write the documentation and changelog if you accept
this. I am new to fvwm development so advice on anything I
should change would be helpful.

Thanks
David