Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On Thu, Aug 31, 2006 at 04:13:56PM +0100, seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. That's because I already committed the fix. There should have been a CVS mail about it. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 9/1/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Thu, Aug 31, 2006 at 04:13:56PM +0100, seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. That's because I already committed the fix. There should have been a CVS mail about it. Ops yes, there was :) it was the same as the map/unmap fix, so it went unnoticed.. Cheers Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFE+GAtmeSprTOr4tgRAlpCAJ9e0ESoydohPvZ2UdLswvRB098nlQCghrGF O9D38PibCnYKn/Ie6ns7UQ8= =E3+w -END PGP SIGNATURE-
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) signature.asc Description: OpenPGP digital signature
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0))
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: Hi Renato, The snapshot of today still uses 0 instead of 0L in the argument list for XGetWindowProperty. Maybe you have a modified version, or you are working on a different branch? I've updated now from cvs, and it uses 0L... Maybe the snapshot is outdated. Probably tomorrow it gets updated. (?) BTW, if you are actively working on fvwm, I sugest you use cvs instead of the snapshots. There are times when there is no activity at all, but there are also times where several changes are made in a few hours. It usually pays off to work with the latest code. Cheers Renato PS: Please reply to the list! Yeah, sometimes it happens to me too :) Regards Harri == seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) -- Dipl.-Ing. Harald Dunkel | The bureaucratic mentality is Muehlenbachstr. 3| the only constant in universe. 52134 Herzogenrath, Germany | +49 2407 565 105 | Dr. Leonard (Bones) McCoy
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On 8/31/06, seventh guardian [EMAIL PROTECTED] wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: Hi Renato, The snapshot of today still uses 0 instead of 0L in the argument list for XGetWindowProperty. Maybe you have a modified version, or you are working on a different branch? I've updated now from cvs, and it uses 0L... Maybe the snapshot is outdated. Probably tomorrow it gets updated. (?) BTW, if you are actively working on fvwm, I sugest you use cvs instead of the snapshots. There are times when there is no activity at all, but there are also times where several changes are made in a few hours. It usually pays off to work with the latest code. Also, it helps with the network traffic. With cvs you only download what changes, while with the snapshot you download the full fvwm code every time.. Renato Cheers Renato PS: Please reply to the list! Yeah, sometimes it happens to me too :) Regards Harri == seventh guardian wrote: On 8/31/06, Harald Dunkel [EMAIL PROTECTED] wrote: There is another broken call to XGetWindowProperty() in ewmh.c, which seems to have been introduced recently. Attached is the patch. I guess it was already corrected? I've tried the patch, but it seemed that the changes were already there.. Cheers Renato Hope this helps. Regards Harri --- fvwm-snap-20060830/fvwm/ewmh.c~ 2006-08-30 10:00:03.0 +0200 +++ fvwm-snap-20060830/fvwm/ewmh.c 2006-08-31 08:16:41.0 +0200 @@ -394,7 +394,7 @@ retval = NULL; length = 0x7fff; ok = XGetWindowProperty( - dpy, win, to_get, 0, length, False, type, type_ret, + dpy, win, to_get, 0L, length, False, type, type_ret, format_ret, num_ret, bytes_after, retval); if ((ok == Success) (retval) (num_ret 0) (format_ret 0)) -- Dipl.-Ing. Harald Dunkel | The bureaucratic mentality is Muehlenbachstr. 3| the only constant in universe. 52134 Herzogenrath, Germany | +49 2407 565 105 | Dr. Leonard (Bones) McCoy
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
On Sun, Aug 27, 2006 at 10:25:33AM +0200, Harald Dunkel wrote: Harald Dunkel wrote: Hi folks, Attached you can find a patch to fix XGetWindowProperty in various sources. This makes at least Xine work _much_ better on 64bit Debian. PS: Better means: The decorations around the popups and the main window are correct. Okay, I've applied the patch. Can you please provide ChangeLog entries for it? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
Dominik Vogt wrote: Okay, I've applied the patch. Can you please provide ChangeLog entries for it? Sure, see attachment. Many thanx Harri diff -ur /tmp/fvwm-snap-20060829/ChangeLog fvwm-snap-20060829/ChangeLog --- /tmp/fvwm-snap-20060829/ChangeLog 2006-08-27 10:00:02.0 +0200 +++ fvwm-snap-20060829/ChangeLog2006-08-29 18:19:15.0 +0200 @@ -1,3 +1,11 @@ +2006-08-29 Harald Dunkel [EMAIL PROTECTED] + + * fvwm/icccm2.c: + * fvwm/gnome.c: + * fvwm/decorations.c: + fix offset and length args for XGetWindowProperty() + (to support 64bit architectures) + 2006-08-26 Viktor Griph [EMAIL PROTECTED] * NEWS: diff -ur /tmp/fvwm-snap-20060829/modules/ChangeLog fvwm-snap-20060829/modules/ChangeLog --- /tmp/fvwm-snap-20060829/modules/ChangeLog 2006-08-27 10:00:02.0 +0200 +++ fvwm-snap-20060829/modules/ChangeLog2006-08-29 18:19:16.0 +0200 @@ -1,3 +1,14 @@ +2006-08-29 Harald Dunkel [EMAIL PROTECTED] + + * FvwmScroll/GrabWindow.c: + * FvwmScript/Widgets/TextField.c: + * FvwmScript/Instructions.c: + * FvwmPager/x_pager.c: + * FvwmForm/ReadXServer.c: + * FvwmDragWell/xdndDragSource.c: + change offset and length args for XGetWindowProperty() to long + (to support 64bit architectures) + 2006-08-26 Viktor Griph [EMAIL PROTECTED] * FvwmPager/FvwmPager.h (pager_window): diff -ur /tmp/fvwm-snap-20060829/utils/ChangeLog fvwm-snap-20060829/utils/ChangeLog --- /tmp/fvwm-snap-20060829/utils/ChangeLog 2006-02-11 10:00:04.0 +0100 +++ fvwm-snap-20060829/utils/ChangeLog 2006-08-29 18:19:18.0 +0200 @@ -1,3 +1,8 @@ +2006-08-29 Harald Dunkel [EMAIL PROTECTED] + + * xselection.c: change offset and length args for XGetWindowProperty() + to long (to support 64bit architectures) + 2006-02-11 Dominik Vogt dominik(dot)vogt(at)gmx(dot)de * changelog.vim: signature.asc Description: OpenPGP digital signature
Re: some 64bit cleanup on CVS head (XGetWindowProperty())
Harald Dunkel wrote: Hi folks, Attached you can find a patch to fix XGetWindowProperty in various sources. This makes at least Xine work _much_ better on 64bit Debian. PS: Better means: The decorations around the popups and the main window are correct. Regards Harri signature.asc Description: OpenPGP digital signature
some 64bit cleanup on CVS head (XGetWindowProperty())
Hi folks,
Attached you can find a patch to fix XGetWindowProperty in various
sources. This makes at least Xine work _much_ better on 64bit Debian.
It would be nice if somebody could verify and checkin.
Hope this helps. Please keep me on CC, since I am not subscribed yet.
Regards
Harri
diff -ur fvwm-snap-20060826/fvwm/decorations.c
fvwm-snap-20060826.new/fvwm/decorations.c
--- fvwm-snap-20060826/fvwm/decorations.c 2005-07-20 10:00:03.0
+0200
+++ fvwm-snap-20060826.new/fvwm/decorations.c 2006-08-27 09:38:47.0
+0200
@@ -129,7 +129,7 @@
t-mwm_hints = NULL;
}
if (XGetWindowProperty(
- dpy, FW_W(t), _XA_MwmAtom, 0L, 32, False,
+ dpy, FW_W(t), _XA_MwmAtom, 0L, 32L, False,
_XA_MwmAtom, actual_type, actual_format, nitems,
bytesafter,(unsigned char **)t-mwm_hints)==Success)
{
@@ -183,7 +183,7 @@
t-ol_hints = OL_DECOR_ALL;
if (XGetWindowProperty(
- dpy, FW_W(t), _XA_OL_WIN_ATTR, 0L, 32, False,
+ dpy, FW_W(t), _XA_OL_WIN_ATTR, 0L, 32L, False,
_XA_OL_WIN_ATTR, actual_type, actual_format,
nitems, bytesafter, (unsigned char **)hints) == Success)
{
@@ -243,7 +243,7 @@
}
if (XGetWindowProperty(
- dpy, FW_W(t), _XA_OL_DECOR_ADD, 0L, 32, False,
+ dpy, FW_W(t), _XA_OL_DECOR_ADD, 0L, 32L, False,
XA_ATOM, actual_type, actual_format, nitems,
bytesafter,(unsigned char **)hints)==Success)
{
@@ -274,7 +274,7 @@
}
if (XGetWindowProperty(
- dpy, FW_W(t), _XA_OL_DECOR_DEL, 0L, 32, False,
+ dpy, FW_W(t), _XA_OL_DECOR_DEL, 0L, 32L, False,
XA_ATOM, actual_type, actual_format, nitems,
bytesafter,(unsigned char **)hints)==Success)
{
diff -ur fvwm-snap-20060826/fvwm/gnome.c fvwm-snap-20060826.new/fvwm/gnome.c
--- fvwm-snap-20060826/fvwm/gnome.c 2006-05-10 10:00:04.0 +0200
+++ fvwm-snap-20060826.new/fvwm/gnome.c 2006-08-27 09:42:06.0 +0200
@@ -281,7 +281,7 @@
retval = NULL;
length = 0x7fff;
XGetWindowProperty(
- dpy, win, to_get, 0, length, False, type, type_ret,
+ dpy, win, to_get, 0L, length, False, type, type_ret,
format_ret, num_ret, bytes_after, retval);
if ((retval) (num_ret 0) (format_ret 0))
diff -ur fvwm-snap-20060826/fvwm/icccm2.c fvwm-snap-20060826.new/fvwm/icccm2.c
--- fvwm-snap-20060826/fvwm/icccm2.c2005-07-20 10:00:03.0 +0200
+++ fvwm-snap-20060826.new/fvwm/icccm2.c2006-08-27 09:40:29.0
+0200
@@ -201,7 +201,7 @@
if (ev.property != None)
{
XGetWindowProperty(
- dpy, ev.requestor, ev.property, 0, 256, False,
+ dpy, ev.requestor, ev.property, 0L, 256L, False,
_XA_ATOM_PAIR, type, format, num, rest,
data);
/* FIXME: to be 100% correct, should deal with
diff -ur fvwm-snap-20060826/modules/FvwmDragWell/xdndDragSource.c
fvwm-snap-20060826.new/modules/FvwmDragWell/xdndDragSource.c
--- fvwm-snap-20060826/modules/FvwmDragWell/xdndDragSource.c2006-08-10
10:00:04.0 +0200
+++ fvwm-snap-20060826.new/modules/FvwmDragWell/xdndDragSource.c
2006-08-27 09:48:16.0 +0200
@@ -565,7 +565,7 @@
*version = 0;
XGetWindowProperty(
- ds-display, window, ds-atomSel-xdndAware, 0, 0x800L, False,
+ ds-display, window, ds-atomSel-xdndAware, 0L, 0x800L, False,
XA_ATOM, actual, format, count, remaining, data);
if (actual != XA_ATOM || format != 32 || count == 0 || !data) {
/* not supported */
diff -ur fvwm-snap-20060826/modules/FvwmForm/ReadXServer.c
fvwm-snap-20060826.new/modules/FvwmForm/ReadXServer.c
--- fvwm-snap-20060826/modules/FvwmForm/ReadXServer.c 2006-08-07
10:00:03.0 +0200
+++ fvwm-snap-20060826.new/modules/FvwmForm/ReadXServer.c 2006-08-27
09:44:45.0 +0200
@@ -678,7 +678,7 @@
if (XGetWindowProperty (dpy,
DefaultRootWindow (dpy),
XA_CUT_BUFFER0,
- nread/4, 1024, /* offset, length */
+ nread/4, 1024L, /* offset, length */
False, /* delete */
AnyPropertyType, /* request type */
actual_type,
diff -ur fvwm-snap-20060826/modules/FvwmPager/x_pager.c
fvwm-snap-20060826.new/modules/FvwmPager/x_pager.c
--- fvwm-snap-20060826/modules/FvwmPager/x_pager.c 2006-08-11
10:00:03.0 +0200
+++ fvwm-snap-20060826.new/modules/FvwmPager/x_pager.c 2006-08-27
