[Gajim-devel] group windows by contacts groups

2009-01-13 Thread Serge Matveenko
Hello!

I've add several lines to the gajim code to allow grouping of the tabs
to windows by contact groups.

Here is the patch for gajim-0.11.4 for sources from Ubuntu Hardy repo.


-- 
Serge Matveenko
mailto:se...@matveenko.ru
http://serge.matveenko.ru/


gajim-0.11.4-pergroup.patch.gz
Description: GNU Zip compressed data
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel

Re: [Gajim-devel] group windows by contacts groups

2009-01-13 Thread Yann Leboulanger
Serge Matveenko wrote:
 Hello!
 
 I've add several lines to the gajim code to allow grouping of the tabs
 to windows by contact groups.
 
 Here is the patch for gajim-0.11.4 for sources from Ubuntu Hardy repo.

great, thanks for the patch, but what happen if contact is in several
groups? I see you only take care of the first group, but that can change
from one connection to another. it's totaly random.

-- 
Yann
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel


Re: [Gajim-devel] group windows by contacts groups

2009-01-13 Thread Jonathan Schleifer

Am 13.01.2009 um 14:43 schrieb Serge Matveenko:


Here is the patch for gajim-0.11.4 for sources from Ubuntu Hardy repo.



Although patches are appreciated, please don't do them against a  
codebase into which no new features have been added for 3 years :).  
Please use 0.12.x or svn instead.


--
Jonathan



PGP.sig
Description: Signierter Teil der Nachricht
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel

Re: [Gajim-devel] group windows by contacts groups

2009-01-13 Thread Serge Matveenko
On Tue, Jan 13, 2009 at 4:48 PM, Yann Leboulanger aste...@lagaule.org wrote:
 Serge Matveenko wrote:
 Hello!

 I've add several lines to the gajim code to allow grouping of the tabs
 to windows by contact groups.

 Here is the patch for gajim-0.11.4 for sources from Ubuntu Hardy repo.

 great, thanks for the patch, but what happen if contact is in several
 groups? I see you only take care of the first group, but that can change
 from one connection to another. it's totaly random.

i don't think this is totally random, 'cause user is usually cares
about groups of the contacts and grouping by any of the groups given
to contact seems logical.

but you are right, its possible to have contacts floating from one
window to another...

i see several workarounds:
1. force user to define one and only one primary group for contact
2. sort groups alphabetically on window creation and than use first
group like now
3. try to choose open window for every group, that will cause more
grouped but not less random behavior

it looks for me that first solution looks best, but it will cause the
biggest code changes


-- 
Serge Matveenko
mailto:se...@matveenko.ru
http://serge.matveenko.ru/
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel


Re: [Gajim-devel] group windows by contacts groups

2009-01-13 Thread Serge Matveenko
On Tue, Jan 13, 2009 at 6:21 PM, Serge Matveenko se...@matveenko.ru wrote:
 On Tue, Jan 13, 2009 at 4:58 PM, Jonathan Schleifer
 js-ga...@webkeks.org wrote:
 Am 13.01.2009 um 14:43 schrieb Serge Matveenko:

 Here is the patch for gajim-0.11.4 for sources from Ubuntu Hardy repo.


 Although patches are appreciated, please don't do them against a codebase
 into which no new features have been added for 3 years :). Please use 0.12.x
 or svn instead.

 here is one for svn 2009-13-01 tarball

sorry, here is last, correct one for gajim 0.12.1 release

it patches correctly latest svn revision with some offset


-- 
Serge Matveenko
mailto:se...@matveenko.ru
http://serge.matveenko.ru/
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel


Re: [Gajim-devel] group windows by contacts groups

2009-01-13 Thread Serge Matveenko
On Tue, Jan 13, 2009 at 7:34 PM, Serge Matveenko se...@matveenko.ru wrote:
 sorry, here is last, correct one for gajim 0.12.1 release

 it patches correctly latest svn revision with some offset

we have evening now :)


-- 
Serge Matveenko
mailto:se...@matveenko.ru
http://serge.matveenko.ru/


gajim-0.12.1-pergroup.patch.gz
Description: GNU Zip compressed data
___
Gajim-devel mailing list
Gajim-devel@gajim.org
http://lists.gajim.org/cgi-bin/listinfo/gajim-devel