Re: [galaxy-dev] [API] Error message forwarding

2011-08-29 Thread Nate Coraor
Louise-Amélie Schmitt wrote:
 Hi,
 
 I ran into a little something that is a bit annoying for debug when
 trying to upload files through the API with
 library_upload_from_import_dir.py. When the specified folder is
 wrong, python tries to process the error tuple like a dict, so the
 original error is hard to find.
 
 I modified a little the code to avoid that. It might not work in all
 cases but at least it solved my problem.
 
 Here is the original code:
 
 lib/galaxy/web/api/contents.py l.145-end
 
 else:
 rval = []
 for k, v in output.items():
 if type( v ) ==
 trans.app.model.LibraryDatasetDatasetAssociation:
 v = v.library_dataset
 encoded_id = trans.security.encode_id( create_type +
 '.' + str( v.id ) )
 rval.append( dict( id = encoded_id,
name = v.name,
url = url_for( 'content',
 library_id=library_id, id=encoded_id ) ) )
 return rval
 
 Here is how I modified it:
 
 else:
 rval = []
 try:
 for k, v in output.items():
 if type( v ) ==
 trans.app.model.LibraryDatasetDatasetAssociation:
 v = v.library_dataset
 encoded_id = trans.security.encode_id(
 create_type + '.' + str( v.id ) )
 rval.append( dict( id = encoded_id,
 name = v.name,
 url = url_for( 'content',
 library_id=library_id, id=encoded_id ) ) )
 return rval
 except:
 log.debug( 'HTTP Error %s: %s' % ( output[0], output[1] ) )
 return None
 
 Since it saves me some time  energy I just wanted to share it, so I
 hope it can help.
 Best
 L-A

Hi L-A,

Thanks for finding this.  It's been fixed in 5952:832538ba7258.

--nate

 ___
 Please keep all replies on the list by using reply all
 in your mail client.  To manage your subscriptions to this
 and other Galaxy lists, please use the interface at:
 
   http://lists.bx.psu.edu/

___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/


[galaxy-dev] [API] Error message forwarding

2011-06-20 Thread Louise-Amélie Schmitt

Hi,

I ran into a little something that is a bit annoying for debug when 
trying to upload files through the API with 
library_upload_from_import_dir.py. When the specified folder is wrong, 
python tries to process the error tuple like a dict, so the original 
error is hard to find.


I modified a little the code to avoid that. It might not work in all 
cases but at least it solved my problem.


Here is the original code:

lib/galaxy/web/api/contents.py l.145-end

else:
rval = []
for k, v in output.items():
if type( v ) == 
trans.app.model.LibraryDatasetDatasetAssociation:

v = v.library_dataset
encoded_id = trans.security.encode_id( create_type + 
'.' + str( v.id ) )

rval.append( dict( id = encoded_id,
   name = v.name,
   url = url_for( 'content', 
library_id=library_id, id=encoded_id ) ) )

return rval

Here is how I modified it:

else:
rval = []
try:
for k, v in output.items():
if type( v ) == 
trans.app.model.LibraryDatasetDatasetAssociation:

v = v.library_dataset
encoded_id = trans.security.encode_id( 
create_type + '.' + str( v.id ) )

rval.append( dict( id = encoded_id,
name = v.name,
url = url_for( 'content', 
library_id=library_id, id=encoded_id ) ) )

return rval
except:
log.debug( 'HTTP Error %s: %s' % ( output[0], output[1] ) )
return None

Since it saves me some time  energy I just wanted to share it, so I 
hope it can help.

Best
L-A
___
Please keep all replies on the list by using reply all
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/