Re: Status of migrated issues?

2018-01-29 Thread 'Federico Pareschi' via ganeti-devel
>Sorry, not sure I understand here. Do I read that code.google.com had two
"fixed" state - one fix committed ("fixed"), and one fix committed and also
released ("released")? If so, and if Github only has fixed, I propose to
drop the released state.

This is the way I understood it, yes.

You raise valid arguments, I'll see if I can find some time this week after
releasing 2.16-rc2 to hack around a script to go through all these issues
automatically and close them.

Cheers.


On Mon, 29 Jan 2018 at 10:24, Iustin Pop  wrote:

> On 29 January 2018 at 11:08, 'Federico Pareschi' via ganeti-devel <
> ganeti-devel@googlegroups.com> wrote:
>
>> Sorry, this email had completely flown under my radar.
>>
>
> No worries.
>
> The issues have all been migrated to the github repository, however there
>> is a difference between 'fixed' and 'released' in the old issue tracker on
>> code.google.com. By importing these issues in github, these states
>> turned into tags. I assume 'released' meant the issue could be closed, but
>> 'fixed' simply added the tag but the issue stayed open.
>>
>
> Sorry, not sure I understand here. Do I read that code.google.com had two
> "fixed" state - one fix committed ("fixed"), and one fix committed and also
> released ("released")? If so, and if Github only has fixed, I propose to
> drop the released state.
>
> I had been thinking about going through all of them and closing the ones
>> marked as fixed but I wanted to review them first and is a lot of
>> time/effort that I haven't invested yet (verifying the fix + closing the
>> issue rather than just automatically closing all of them).
>>
>
> I would suggest to simply fix all of them, based on:
>
> - we should trust the code.google.com "fixed" tag;
> - there are a lot of very old issues that are for sure fixed, and
> verifying all of them is time better spent on fixing new issues
>
> If some issue is still open, and if users still hit it, let's crowdsource
> the effort of reopening (against current versions) to the users :)
>
> iustin
>
> On Fri, 26 Jan 2018 at 19:53, Iustin Pop  wrote:
>>
>>> On 2018-01-14 02:15:41, Iustin Pop wrote:
>>> > Hi all,
>>> >
>>> > I did a quick look at the GitHub issue tracker today, and it seems that
>>> > the migrator did not close the migrated issues that were closed.
>>> >
>>> > More specifically, a search of:
>>> >
>>> > is:issue is:open label:Status:Fixed
>>> >
>>> > Shows 98 such open issues. If I'm not mistaken, "Status:Fixed" is a
>>> > googlecode imported label, which tells me that the migrator had some
>>> > issue (ha) importing the bug list.
>>>
>>> Friendly ping? Mostly for my own curiosity.
>>>
>>> iustin
>>>
>>
>


Re: Status of migrated issues?

2018-01-29 Thread 'Iustin Pop' via ganeti-devel
On 29 January 2018 at 11:08, 'Federico Pareschi' via ganeti-devel <
ganeti-devel@googlegroups.com> wrote:

> Sorry, this email had completely flown under my radar.
>

No worries.

The issues have all been migrated to the github repository, however there
> is a difference between 'fixed' and 'released' in the old issue tracker on
> code.google.com. By importing these issues in github, these states turned
> into tags. I assume 'released' meant the issue could be closed, but 'fixed'
> simply added the tag but the issue stayed open.
>

Sorry, not sure I understand here. Do I read that code.google.com had two
"fixed" state - one fix committed ("fixed"), and one fix committed and also
released ("released")? If so, and if Github only has fixed, I propose to
drop the released state.

I had been thinking about going through all of them and closing the ones
> marked as fixed but I wanted to review them first and is a lot of
> time/effort that I haven't invested yet (verifying the fix + closing the
> issue rather than just automatically closing all of them).
>

I would suggest to simply fix all of them, based on:

- we should trust the code.google.com "fixed" tag;
- there are a lot of very old issues that are for sure fixed, and verifying
all of them is time better spent on fixing new issues

If some issue is still open, and if users still hit it, let's crowdsource
the effort of reopening (against current versions) to the users :)

iustin

On Fri, 26 Jan 2018 at 19:53, Iustin Pop  wrote:
>
>> On 2018-01-14 02:15:41, Iustin Pop wrote:
>> > Hi all,
>> >
>> > I did a quick look at the GitHub issue tracker today, and it seems that
>> > the migrator did not close the migrated issues that were closed.
>> >
>> > More specifically, a search of:
>> >
>> > is:issue is:open label:Status:Fixed
>> >
>> > Shows 98 such open issues. If I'm not mistaken, "Status:Fixed" is a
>> > googlecode imported label, which tells me that the migrator had some
>> > issue (ha) importing the bug list.
>>
>> Friendly ping? Mostly for my own curiosity.
>>
>> iustin
>>
>


Re: Status of migrated issues?

2018-01-29 Thread 'Federico Pareschi' via ganeti-devel
Sorry, this email had completely flown under my radar.

The issues have all been migrated to the github repository, however there
is a difference between 'fixed' and 'released' in the old issue tracker on
code.google.com. By importing these issues in github, these states turned
into tags. I assume 'released' meant the issue could be closed, but 'fixed'
simply added the tag but the issue stayed open.

I had been thinking about going through all of them and closing the ones
marked as fixed but I wanted to review them first and is a lot of
time/effort that I haven't invested yet (verifying the fix + closing the
issue rather than just automatically closing all of them).


On Fri, 26 Jan 2018 at 19:53, Iustin Pop  wrote:

> On 2018-01-14 02:15:41, Iustin Pop wrote:
> > Hi all,
> >
> > I did a quick look at the GitHub issue tracker today, and it seems that
> > the migrator did not close the migrated issues that were closed.
> >
> > More specifically, a search of:
> >
> > is:issue is:open label:Status:Fixed
> >
> > Shows 98 such open issues. If I'm not mistaken, "Status:Fixed" is a
> > googlecode imported label, which tells me that the migrator had some
> > issue (ha) importing the bug list.
>
> Friendly ping? Mostly for my own curiosity.
>
> iustin
>