Re: [PATCH instance-debootstrap 0/4] Cleanups and simple tests

['Iustin Pop' via ganeti-devel]

2016-05-30 11:51 GMT+02:00 Brian Foley :

> On Sun, May 29, 2016 at 02:38:22AM +0200, Iustin Pop wrote:
> > From: Iustin Pop 
> >
> > A few cleanups, and adding a test suite to be run without Ganeti, i.e. on
> > standalone systems. However it has downsides, see that patch's
> description.
> >
> > Note: I haven't tested this patch series under Ganeti itself, but the
> only
> > non-test modification is the suite change (wheezy→jessie), so this
> should work
> > as before.
> >
> > If these are LGTM'ed and pushed, I'll followup with release patch (0.16).
> >
> > Iustin Pop (4):
> >   Don't mark common.sh as executable
> >   Check for required programs at configure time
> >   Switch default suite to jessie and bump min disk size
> >   Add a test for exercising the scripts
>
> LGTM. I'll fix the nit and push the patchset.
>

thanks!
iustin

Re: [PATCH instance-debootstrap 0/4] Cleanups and simple tests

['Brian Foley' via ganeti-devel]

On Sun, May 29, 2016 at 02:38:22AM +0200, Iustin Pop wrote:
> From: Iustin Pop 
> 
> A few cleanups, and adding a test suite to be run without Ganeti, i.e. on
> standalone systems. However it has downsides, see that patch's description.
> 
> Note: I haven't tested this patch series under Ganeti itself, but the only
> non-test modification is the suite change (wheezy→jessie), so this should work
> as before.
> 
> If these are LGTM'ed and pushed, I'll followup with release patch (0.16).
> 
> Iustin Pop (4):
>   Don't mark common.sh as executable
>   Check for required programs at configure time
>   Switch default suite to jessie and bump min disk size
>   Add a test for exercising the scripts

LGTM. I'll fix the nit and push the patchset.

Thanks.

[PATCH instance-debootstrap 0/4] Cleanups and simple tests

[Iustin Pop]

From: Iustin Pop 

A few cleanups, and adding a test suite to be run without Ganeti, i.e. on
standalone systems. However it has downsides, see that patch's description.

Note: I haven't tested this patch series under Ganeti itself, but the only
non-test modification is the suite change (wheezy→jessie), so this should work
as before.

If these are LGTM'ed and pushed, I'll followup with release patch (0.16).

Iustin Pop (4):
  Don't mark common.sh as executable
  Check for required programs at configure time
  Switch default suite to jessie and bump min disk size
  Add a test for exercising the scripts

 .gitignore |  3 +++
 Makefile.am|  7 +++--
 common.sh.in   |  2 +-
 configure.ac   | 41 +++-
 create |  4 +--
 test/install-export-import | 67 ++
 6 files changed, 118 insertions(+), 6 deletions(-)
 create mode 100755 test/install-export-import

-- 
2.8.1