Re: [PATCH master 27/52] Remove extraneous check in policy creation

2012-01-11 Thread René Nussbaumer 
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote:
 The values are already checked in CreateIPolicy, no need to manually
 check them again.
 ---
  lib/client/gnt_cluster.py |    2 --
  lib/client/gnt_group.py   |    3 ---
  2 files changed, 0 insertions(+), 5 deletions(-)

LGTM.

René

[PATCH master 27/52] Remove extraneous check in policy creation

2012-01-09 Thread Iustin Pop 
The values are already checked in CreateIPolicy, no need to manually
check them again.
---
 lib/client/gnt_cluster.py |2 --
 lib/client/gnt_group.py   |3 ---
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py
index e43c568..4af6e22 100644
--- a/lib/client/gnt_cluster.py
+++ b/lib/client/gnt_cluster.py
@@ -990,8 +990,6 @@ def SetClusterParams(opts, args):
   ispecs_disk_count=opts.ispecs_disk_count,
   ispecs_disk_size=opts.ispecs_disk_size,
   ispecs_nic_count=opts.ispecs_nic_count)
-  for value in ipolicy.values():
-utils.ForceDictType(value, constants.ISPECS_PARAMETER_TYPES)
 
   mnh = opts.maintain_node_health
 
diff --git a/lib/client/gnt_group.py b/lib/client/gnt_group.py
index d5cb0ac..f39c6e5 100644
--- a/lib/client/gnt_group.py
+++ b/lib/client/gnt_group.py
@@ -194,9 +194,6 @@ def SetGroupParams(opts, args):
 ispecs_nic_count=opts.ispecs_nic_count,
 group_ipolicy=True,
 allowed_values=[constants.VALUE_DEFAULT])
-  for key in ipolicy.keys():
-utils.ForceDictType(ipolicy[key], constants.ISPECS_PARAMETER_TYPES,
-allowed_values=[constants.VALUE_DEFAULT])
 
   op = opcodes.OpGroupSetParams(group_name=args[0],
 ndparams=opts.ndparams,
-- 
1.7.3.1