Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Tue, May 21, 2024 at 6:21 PM Jeff Law wrote: > > > > On 5/21/24 8:02 AM, Paul Koning wrote: > > > > > >> On May 21, 2024, at 9:57 AM, Jeff Law wrote: > >> > >> > >> > >> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: > >>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: > > On Wed, 5 Jul 2023, Joern Rennecke wrote: > > I haven't worked with these targets in years and can't really do > > sensible maintenance or reviews of patches for them. I am currently > > working on optimizations for other ports like RISC-V. > > I noticed MAINTAINERS was not updated, so pushed the patch below. > >>> That leaves the epiphany port unmaintained. Should we automatically add > >>> such > >>> ports to the list of obsoleted ports? > >> Given that epiphany has randomly failed tests for the last 3+ years due to > >> bugs in its patterns, yes, it really needs to be deprecated. > >> > >> I tried to fix the worst of the offenders in epiphany.md a few years back > >> and gave up. Essentially seemingly innocent changes in the RTL will cause > >> reload to occasionally not see a path to get constraints satisfied. So a > >> test which passes today, will flip to failing tomorrow while some other > >> test of tests will go the other way. > > > > Does LRA make that issue go away, or does it not help? > LRA didn't trivially work on epiphany. I didn't care enough about the > port to try and make it LRA compatible. In that case LRA will make the issue go away (the port, that is ...). Richard. > > jeff >
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Tue, May 21, 2024 at 6:21 PM Jeff Law wrote: > > > > On 5/21/24 8:02 AM, Paul Koning wrote: > > > > > >> On May 21, 2024, at 9:57 AM, Jeff Law wrote: > >> > >> > >> > >> On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: > >>> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: > > On Wed, 5 Jul 2023, Joern Rennecke wrote: > > I haven't worked with these targets in years and can't really do > > sensible maintenance or reviews of patches for them. I am currently > > working on optimizations for other ports like RISC-V. > > I noticed MAINTAINERS was not updated, so pushed the patch below. > >>> That leaves the epiphany port unmaintained. Should we automatically add > >>> such > >>> ports to the list of obsoleted ports? > >> Given that epiphany has randomly failed tests for the last 3+ years due to > >> bugs in its patterns, yes, it really needs to be deprecated. > >> > >> I tried to fix the worst of the offenders in epiphany.md a few years back > >> and gave up. Essentially seemingly innocent changes in the RTL will cause > >> reload to occasionally not see a path to get constraints satisfied. So a > >> test which passes today, will flip to failing tomorrow while some other > >> test of tests will go the other way. > > > > Does LRA make that issue go away, or does it not help? > LRA didn't trivially work on epiphany. I didn't care enough about the > port to try and make it LRA compatible. In that case LRA will make the issue go away (the port, that is ...). Richard. > > jeff >
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On 5/21/24 8:02 AM, Paul Koning wrote: On May 21, 2024, at 9:57 AM, Jeff Law wrote: On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated. I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way. Does LRA make that issue go away, or does it not help? LRA didn't trivially work on epiphany. I didn't care enough about the port to try and make it LRA compatible. jeff
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On 5/21/24 8:02 AM, Paul Koning wrote: On May 21, 2024, at 9:57 AM, Jeff Law wrote: On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated. I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way. Does LRA make that issue go away, or does it not help? LRA didn't trivially work on epiphany. I didn't care enough about the port to try and make it LRA compatible. jeff
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
> On May 21, 2024, at 9:57 AM, Jeff Law wrote: > > > > On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: >> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: >>> >>> On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. >>> >>> I noticed MAINTAINERS was not updated, so pushed the patch below. >> That leaves the epiphany port unmaintained. Should we automatically add such >> ports to the list of obsoleted ports? > Given that epiphany has randomly failed tests for the last 3+ years due to > bugs in its patterns, yes, it really needs to be deprecated. > > I tried to fix the worst of the offenders in epiphany.md a few years back and > gave up. Essentially seemingly innocent changes in the RTL will cause reload > to occasionally not see a path to get constraints satisfied. So a test which > passes today, will flip to failing tomorrow while some other test of tests > will go the other way. Does LRA make that issue go away, or does it not help? paul
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
> On May 21, 2024, at 9:57 AM, Jeff Law wrote: > > > > On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: >> On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: >>> >>> On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. >>> >>> I noticed MAINTAINERS was not updated, so pushed the patch below. >> That leaves the epiphany port unmaintained. Should we automatically add such >> ports to the list of obsoleted ports? > Given that epiphany has randomly failed tests for the last 3+ years due to > bugs in its patterns, yes, it really needs to be deprecated. > > I tried to fix the worst of the offenders in epiphany.md a few years back and > gave up. Essentially seemingly innocent changes in the RTL will cause reload > to occasionally not see a path to get constraints satisfied. So a test which > passes today, will flip to failing tomorrow while some other test of tests > will go the other way. Does LRA make that issue go away, or does it not help? paul
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated. I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way. jeff
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On 5/21/24 12:05 AM, Richard Biener via Gcc wrote: On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: On Wed, 5 Jul 2023, Joern Rennecke wrote: I haven't worked with these targets in years and can't really do sensible maintenance or reviews of patches for them. I am currently working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Given that epiphany has randomly failed tests for the last 3+ years due to bugs in its patterns, yes, it really needs to be deprecated. I tried to fix the worst of the offenders in epiphany.md a few years back and gave up. Essentially seemingly innocent changes in the RTL will cause reload to occasionally not see a path to get constraints satisfied. So a test which passes today, will flip to failing tomorrow while some other test of tests will go the other way. jeff
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: > > On Wed, 5 Jul 2023, Joern Rennecke wrote: > > I haven't worked with these targets in years and can't really do > > sensible maintenance or reviews of patches for them. I am currently > > working on optimizations for other ports like RISC-V. > > I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Richard. > Gerald > > > commit f94598ffaf5affbc9421ff230502357b07c55d9c > Author: Gerald Pfeifer > Date: Mon May 20 16:43:05 2024 +0200 > > MAINTAINERS: Update Joern Rennecke's status > > This is per his mail to g...@gcc.gnu.org on 7 Jul 2023. > > ChangeLog: > * MAINTAINERS: Move Joern Rennecke from arc and epiphany > maintainer > to Write After Approval. > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8e0add6bef8..e2870eef2ef 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov > > alpha port Richard Henderson > amdgcn portJulian Brown > amdgcn portAndrew Stubbs > -arc port Joern Rennecke > arc port Claudiu Zissulescu > arm port Nick Clifton > arm port Richard Earnshaw > @@ -68,7 +67,6 @@ c6x port Bernd Schmidt > > cris port Hans-Peter Nilsson > c-sky port Xianmiao Qu > c-sky port Yunhai Shang > -epiphany port Joern Rennecke > fr30 port Nick Clifton > frv port Nick Clifton > frv port Alexandre Oliva > @@ -634,6 +632,7 @@ Joe Ramsay > > Rolf Rasmussen > Fritz Reese > Volker Reichelt > > +Joern Rennecke > Bernhard Reutner-Fischer > Tom Rix > Thomas Rodgers
Re: [committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Mon, May 20, 2024 at 4:45 PM Gerald Pfeifer wrote: > > On Wed, 5 Jul 2023, Joern Rennecke wrote: > > I haven't worked with these targets in years and can't really do > > sensible maintenance or reviews of patches for them. I am currently > > working on optimizations for other ports like RISC-V. > > I noticed MAINTAINERS was not updated, so pushed the patch below. That leaves the epiphany port unmaintained. Should we automatically add such ports to the list of obsoleted ports? Richard. > Gerald > > > commit f94598ffaf5affbc9421ff230502357b07c55d9c > Author: Gerald Pfeifer > Date: Mon May 20 16:43:05 2024 +0200 > > MAINTAINERS: Update Joern Rennecke's status > > This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023. > > ChangeLog: > * MAINTAINERS: Move Joern Rennecke from arc and epiphany > maintainer > to Write After Approval. > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8e0add6bef8..e2870eef2ef 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov > > alpha port Richard Henderson > amdgcn portJulian Brown > amdgcn portAndrew Stubbs > -arc port Joern Rennecke > arc port Claudiu Zissulescu > arm port Nick Clifton > arm port Richard Earnshaw > @@ -68,7 +67,6 @@ c6x port Bernd Schmidt > > cris port Hans-Peter Nilsson > c-sky port Xianmiao Qu > c-sky port Yunhai Shang > -epiphany port Joern Rennecke > fr30 port Nick Clifton > frv port Nick Clifton > frv port Alexandre Oliva > @@ -634,6 +632,7 @@ Joe Ramsay > > Rolf Rasmussen > Fritz Reese > Volker Reichelt > > +Joern Rennecke > Bernhard Reutner-Fischer > Tom Rix > Thomas Rodgers
[committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Wed, 5 Jul 2023, Joern Rennecke wrote: > I haven't worked with these targets in years and can't really do > sensible maintenance or reviews of patches for them. I am currently > working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. Gerald commit f94598ffaf5affbc9421ff230502357b07c55d9c Author: Gerald Pfeifer Date: Mon May 20 16:43:05 2024 +0200 MAINTAINERS: Update Joern Rennecke's status This is per his mail to gcc@gcc.gnu.org on 7 Jul 2023. ChangeLog: * MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer to Write After Approval. diff --git a/MAINTAINERS b/MAINTAINERS index 8e0add6bef8..e2870eef2ef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov alpha port Richard Henderson amdgcn portJulian Brown amdgcn portAndrew Stubbs -arc port Joern Rennecke arc port Claudiu Zissulescu arm port Nick Clifton arm port Richard Earnshaw @@ -68,7 +67,6 @@ c6x port Bernd Schmidt cris port Hans-Peter Nilsson c-sky port Xianmiao Qu c-sky port Yunhai Shang -epiphany port Joern Rennecke fr30 port Nick Clifton frv port Nick Clifton frv port Alexandre Oliva @@ -634,6 +632,7 @@ Joe Ramsay Rolf Rasmussen Fritz Reese Volker Reichelt +Joern Rennecke Bernhard Reutner-Fischer Tom Rix Thomas Rodgers
[committed] PATCH for Re: Stepping down as maintainer for ARC and Epiphany
On Wed, 5 Jul 2023, Joern Rennecke wrote: > I haven't worked with these targets in years and can't really do > sensible maintenance or reviews of patches for them. I am currently > working on optimizations for other ports like RISC-V. I noticed MAINTAINERS was not updated, so pushed the patch below. Gerald commit f94598ffaf5affbc9421ff230502357b07c55d9c Author: Gerald Pfeifer Date: Mon May 20 16:43:05 2024 +0200 MAINTAINERS: Update Joern Rennecke's status This is per his mail to g...@gcc.gnu.org on 7 Jul 2023. ChangeLog: * MAINTAINERS: Move Joern Rennecke from arc and epiphany maintainer to Write After Approval. diff --git a/MAINTAINERS b/MAINTAINERS index 8e0add6bef8..e2870eef2ef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -56,7 +56,6 @@ aarch64 port Kyrylo Tkachov alpha port Richard Henderson amdgcn portJulian Brown amdgcn portAndrew Stubbs -arc port Joern Rennecke arc port Claudiu Zissulescu arm port Nick Clifton arm port Richard Earnshaw @@ -68,7 +67,6 @@ c6x port Bernd Schmidt cris port Hans-Peter Nilsson c-sky port Xianmiao Qu c-sky port Yunhai Shang -epiphany port Joern Rennecke fr30 port Nick Clifton frv port Nick Clifton frv port Alexandre Oliva @@ -634,6 +632,7 @@ Joe Ramsay Rolf Rasmussen Fritz Reese Volker Reichelt +Joern Rennecke Bernhard Reutner-Fischer Tom Rix Thomas Rodgers
