Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Ron]

In article ,
   David Pitt  wrote:
> Kevin Wells, on 28 Aug, wrote:

> > Hi
> > 
> > When using wget 1.19.1 with the quiet option selected I get the
> > following message:
> > 
> > Redirecting output to 'wget-log.##'
> > 
> > The ## is a number that increases each time.
> > 
> > The file is a log of the connection details of wget.
> > 
> > Previous versions did not display this.

> Having done further tests I am seeing the apparently spurious
> 'wget-log' both with and without the '-q' flag. This is both with the
> currency command line example given and a simple wget from my site.

> *wget --version
> GNU Wget 1.19.1 built on riscos.

> *wget http://www.pittdj.co.uk/temp/temp.htm

> Redirecting output to 'wget-log'.
> *
> *wget http://www.pittdj.co.uk/temp/temp.htm -q

> Redirecting output to 'wget-log.1'.
> *

> The '-q' flag results in an empty 'wget-log' file.


> Using wget 1.18, home built here with autobuilder revision 7118, the log
> output defaults to the screen as expected with no redrection.

> wget 1.19.1-3ubuntu1 on Ubuntu 17.10 (development branch) does not redirect
> either.
>  
> FWIW HTH

While testing  1.19.1 I awas already using currency convertor daily and
never encountered this, apparently because I have 
logfile = /RAM::Ramdisc0/$/wgt.log
in my (unixhome) /wgetrc file.

Setting
logfile = /dev/null
stops all output.

The commandline version would be
-o /dev/null

I dont know why --quiet is not working.
The logfile output is quite separate to the output document processing
where my change (close open file) was made I think.
but a build of 1.19.1 without my patches should verify that.

Ron M (just back from sunny Queensland)



___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[David Pitt]

Ralph Corderoy, on 30 Aug, wrote:

> Hi Theo,
> 
> > It is still worth commenting on upstream bug trackers - they won't
> > know what RISC OS is, but if the bug is not a RISC OS specific one
> > then the bug report is still relevant.
> 
> It might be that RISC OS triggers it in a similar way to the odd set up
> on that bug report.
> 
> src/log.c:
> 955 static void
> 956 check_redirect_output (void)
> 957 {
> 958 #ifndef WINDOWS
> 959   /* If it was redirected already to log file by SIGHUP, SIGUSR1
or -o parameter,
> 960* it was permanent.
> 961* If there was no SIGHUP or SIGUSR1 and shell is interactive
> 962* we check if process is fg or bg before every line is
printed.*/
> 963   if (!redirect_request_signal_name && shell_is_interactive &&
!opt.lfilename)
> 964 {
>  →  965   if (tcgetpgrp (STDIN_FILENO) != getpgrp ())
> 966 {
> 967   /* Process backgrounded */
>   → 968   redirect_output (true,NULL);
> 969 }
> 
> I haven't run this code, but I wonder if 965 is true.  If Kevin is happy
> to modify the source and re-build then he might be able to tell that 968
> executes.

Perhaps this :-

https://fossies.org/diffs/wget/1.18_vs_1.19/ChangeLog-diff.html

2016-10-21  losgrandes  

Fixes #45790: wget prints it's progress even when background
 * src/log.c: Use tcgetpgrp(STDIN_FILENO) != getpgrp() to determine when
to print to STD* or logfile.
 Deprecate log_request_redirect_output function.
 Use different file handles for STD* and logfile, to easily switch betwe en
them when changing fg/bg.
 * src/log.h: Make redirect_output function externally linked.
 * src/main.c: Don't use deprecated log_request_redirect_output function. 
 Use redirect_output instead.
 * src/mswindows.c: Don't use deprecated log_request_redirect_output 
function. Use redirect_output instead.
-- 
David Pitt

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[David Pitt]

Kevin Wells, on 28 Aug, wrote:

> Hi
> 
> When using wget 1.19.1 with the quiet option selected I get the
> following message:
> 
> Redirecting output to 'wget-log.##'
> 
> The ## is a number that increases each time.
> 
> The file is a log of the connection details of wget.
> 
> Previous versions did not display this.

Having done further tests I am seeing the apparently spurious
'wget-log' both with and without the '-q' flag. This is both with the
currency command line example given and a simple wget from my site.

*wget --version
GNU Wget 1.19.1 built on riscos.

*wget http://www.pittdj.co.uk/temp/temp.htm

Redirecting output to 'wget-log'.
*
*wget http://www.pittdj.co.uk/temp/temp.htm -q

Redirecting output to 'wget-log.1'.
*

The '-q' flag results in an empty 'wget-log' file.


Using wget 1.18, home built here with autobuilder revision 7118, the log
output defaults to the screen as expected with no redrection.

wget 1.19.1-3ubuntu1 on Ubuntu 17.10 (development branch) does not redirect
either.
 
FWIW HTH
-- 
David Pitt

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Jeremy Nicoll - ml roinfo]

On 2017-08-29 18:23, Kevin Wells wrote:

In message 
  David Pitt  wrote:


Adding -o null: to the command line stops the unwanted wget-log 
appearing.



Thanks for that, so I guess the fix wil have to come from the upstream?

I don't want to have to update about half a dozen of my applications if
I don;t have to.


Would, say, renaming the binary to 'wget2' and defining an alias for 
wget so
that it executes wget2 with the "-o null:" bit added get around that for 
the

moment?

--
Jeremy Nicoll - my opinions are my own

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Ralph Corderoy]

Hi Theo,

> It is still worth commenting on upstream bug trackers - they won't
> know what RISC OS is, but if the bug is not a RISC OS specific one
> then the bug report is still relevant.

It might be that RISC OS triggers it in a similar way to the odd set up
on that bug report.

src/log.c:
955 static void
956 check_redirect_output (void)
957 {
958 #ifndef WINDOWS
959   /* If it was redirected already to log file by SIGHUP, SIGUSR1 or -o 
parameter,
960* it was permanent.
961* If there was no SIGHUP or SIGUSR1 and shell is interactive
962* we check if process is fg or bg before every line is printed.*/
963   if (!redirect_request_signal_name && shell_is_interactive && 
!opt.lfilename)
964 {
 →  965   if (tcgetpgrp (STDIN_FILENO) != getpgrp ())
966 {
967   /* Process backgrounded */
  → 968   redirect_output (true,NULL);
969 }

I haven't run this code, but I wonder if 965 is true.  If Kevin is happy
to modify the source and re-build then he might be able to tell that 968
executes.

-- 
Cheers, Ralph.
https://plus.google.com/+RalphCorderoy

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Theo Markettos]

On Tue, Aug 29, 2017 at 06:23:02PM +0100, Kevin Wells wrote:
> Thanks for that, so I guess the fix wil have to come from the upstream?

Yes.  We don't generally have the manpower to curate patches that diverge
from upstream, apart from anything necessary to make it build on RISC OS.
We should be able, however, to turn around a new upstream build fairly
rapidly - so at such time that a new version is released we can produce a
new RISC OS build rapidly (though testing it is rather more difficult).

It is still worth commenting on upstream bug trackers - they won't know what
RISC OS is, but if the bug is not a RISC OS specific one then the bug report
is still relevant.  Though it seems there has been no activity on this one
since it was reported in June.

Theo

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Kevin Wells]

In message 
  David Pitt  wrote:

>Kevin Wells, on 29 Aug, wrote:
>
>> In message <20170828221529.gk14...@chiark.greenend.org.uk> you wrote:
>>
>> >On Mon, Aug 28, 2017 at 09:25:44PM +0100, Kevin Wells wrote:
>> >> Hi
>> >>
>> >> When using wget 1.19.1 with the quiet option selected I get the
>> >> following message:
>> >>
>> >> Redirecting output to 'wget-log.##'
>> >>
>> >> The ## is a number that increases each time.
>> >>
>> >> The file is a log of the connection details of wget.
>> >>
>> >> Previous versions did not display this.
>> >
>> >What command line are you using?
>>
>*wget 
>http://free.currencyconverterapi.com/api/v3/convert?q=GBP_GIP=ultra-q 
>-O RAM::RamDisc0.$.rate
>
>[snip]
>
>A quick Google might indicate this is a bug :-
>
>https://lists.gnu.org/archive/html/bug-wget/2017-06/msg00014.html
>
>or maybe a feature even :-
>
>https://www.makemkv.com/forum2/viewtopic.php?f=3=15885
>
>Adding -o null: to the command line stops the unwanted wget-log appearing.
>

Thanks for that, so I guess the fix wil have to come from the upstream?

I don't want to have to update about half a dozen of my applications if
I don;t have to.


-- 
Kev Wells
http://kevsoft.co.uk/
They sent me to the gallery or round the music-'alls,

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[David Pitt]

Kevin Wells, on 29 Aug, wrote:

> In message <20170828221529.gk14...@chiark.greenend.org.uk> you wrote:
> 
> >On Mon, Aug 28, 2017 at 09:25:44PM +0100, Kevin Wells wrote:
> >> Hi
> >>
> >> When using wget 1.19.1 with the quiet option selected I get the
> >> following message:
> >>
> >> Redirecting output to 'wget-log.##'
> >>
> >> The ## is a number that increases each time.
> >>
> >> The file is a log of the connection details of wget.
> >>
> >> Previous versions did not display this.
> >
> >What command line are you using?
> 
*wget 
http://free.currencyconverterapi.com/api/v3/convert?q=GBP_GIP=ultra-q 
-O RAM::RamDisc0.$.rate

[snip]

A quick Google might indicate this is a bug :-

https://lists.gnu.org/archive/html/bug-wget/2017-06/msg00014.html

or maybe a feature even :-

https://www.makemkv.com/forum2/viewtopic.php?f=3=15885

Adding -o null: to the command line stops the unwanted wget-log appearing.  

-- 
David Pitt

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Kevin Wells]

In message <20170828221529.gk14...@chiark.greenend.org.uk> you wrote:

>On Mon, Aug 28, 2017 at 09:25:44PM +0100, Kevin Wells wrote:
>> Hi
>>
>> When using wget 1.19.1 with the quiet option selected I get the
>> following message:
>>
>> Redirecting output to 'wget-log.##'
>>
>> The ## is a number that increases each time.
>>
>> The file is a log of the connection details of wget.
>>
>> Previous versions did not display this.
>
>What command line are you using?

<*wget
http://free.currencyconverterapi.com/api/v3/convert?q=GBP_GIP=ultra
-q -O RAM::RamDisc0.$.rate>

The same error also appears on BASIC WIMP apps as well.

>
>What previous version do you have that had a different behaviour?

I used the package manager to update wget and forget the previous
version installed, but I think it was 1.17 something.

>
>I don't think anything has changed from the RISC OS perspective, so I
>suspect an upstream change.  If we know some details we can have a look what
>happened.
>
>Theo


-- 
Kev Wells
http://kevsoft.co.uk/
Q: How do you make a dog drink? A: Put it in a liquidizer.

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

Re: [gccsdk] wget 1.19.1 tries to write a logfile

[Theo Markettos]

On Mon, Aug 28, 2017 at 09:25:44PM +0100, Kevin Wells wrote:
> Hi
> 
> When using wget 1.19.1 with the quiet option selected I get the
> following message:
> 
> Redirecting output to 'wget-log.##'
> 
> The ## is a number that increases each time.
> 
> The file is a log of the connection details of wget.
> 
> Previous versions did not display this.

What command line are you using?

What previous version do you have that had a different behaviour?

I don't think anything has changed from the RISC OS perspective, so I
suspect an upstream change.  If we know some details we can have a look what
happened.

Theo

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK

[gccsdk] wget 1.19.1 tries to write a logfile

[Kevin Wells]

Hi

When using wget 1.19.1 with the quiet option selected I get the
following message:

Redirecting output to 'wget-log.##'

The ## is a number that increases each time.

The file is a log of the connection details of wget.

Previous versions did not display this.

Thanks.

-- 
Kev Wells
http://kevsoft.co.uk/
I went into a theatre as sober as could be,

___
GCCSDK mailing list gcc@gccsdk.riscos.info
Bugzilla: http://www.riscos.info/bugzilla/index.cgi
List Info: http://www.riscos.info/mailman/listinfo/gcc
Main Page: http://www.riscos.info/index.php/GCCSDK