[Bug gcov-profile/114115] xz-utils segfaults when built with -fprofile-generate (bad interaction between IFUNC and binding?)

[jasonwucj at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114115

--- Comment #9 from Chung-Ju Wu  ---
(In reply to Sam James from comment #1)
> One of the xz developers, Jia Tan, has kindly minimised it to not need
> BIND_NOW. I've adapted it a bit to cleanup flags and warnings.
> 

CVE-2024-3094

Jia Tan is the one who injected backdoor in xz-5.6.0 and xz-5.6.1, which may be
the cause of the segfaults. I'm wondering if we still need a workaround for
this issue...

[Bug c/100854] TS 18661-3 and backwards-incompatible setting of __FLT_EVAL_METHOD__

[jasonwucj at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100854

Chung-Ju Wu  changed:

   What|Removed |Added

 CC||andrea.corallo at arm dot com,
   ||kito at gcc dot gnu.org

--- Comment #5 from Chung-Ju Wu  ---
(In reply to Francois-Xavier Coudert from comment #2)
> This affects x86_64-apple-darwin:
> https://gcc.gnu.org/pipermail/gcc/2021-December/237959.html
> 
> The  system header errors out on any value of __FLT_EVAL_METHOD__
> that is not -1, 0, 1, or 2.

I guess this issue has been resolved by newlib implementation. :)

Refer to the discussions on:
https://sourceware.org/pipermail/newlib/2021/018471.html
https://sourceware.org/pipermail/newlib/2022/019522.html

The patches have been committed into newlib code base and it should be workable
now.

[Bug translation/40883] [meta-bug] Translation breakage with trivial fixes

[jasonwucj at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883
Bug 40883 depends on bug 85665, which changed state.

Bug 85665 Summary: Multiple typos in diagnostics
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85665

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

[Bug target/85665] Multiple typos in diagnostics

[jasonwucj at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85665

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Chung-Ju Wu  ---
(In reply to Chung-Ju Wu from comment #13)
> 
> I am thinking of closing this bug issue for now.  But it is ALWAYS WELCOME
> to contribute patches as "obvious fix" if you notice any other typos in the
> nds32 source.

Close this issue as it is an omnibus report.

It is welcome to propose separated patches on gcc-patches mailing list to fix
typos.  Feel free to treat it as "obvious fix" if the typo-fix patches are
nds32 target related.

Thanks.

[Bug target/85665] Multiple typos in diagnostics

[jasonwucj at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85665

--- Comment #13 from Chung-Ju Wu  ---
(In reply to Eric Gallager from comment #12)
> (In reply to Jonathan Wakely from comment #6)
> > (In reply to Roland Illig from comment #3)
> > > Therefore I thought I'd try a different approach this time.
> > 
> > Understandable. Thank you for persisting with trying to fix these kind of
> > issues.
> > 
> > You're likely to have more success if you simply send a patch with fixes to
> > gcc-patc...@gcc.gnu.org, CCing the diagnostics maintainers. They can then
> > review your suggested fixes and commit the whole patch to fix everything at
> > once. Even better would be to get write access to SVN and fix them yourself
> > (getting approval for anything that isn't an "obvious fix" as per
> > https://gcc.gnu.org/svnwrite.html#policies under "Free for all").
> >  
> 
> Having the "obvious fix" rule spelled out in a bit more detail would
> probably be helpful, as a lot of time I feel like I'd have to ask whether
> something would count as an "obvious fix" or not, which would end up being
> pretty much the same thing as getting approval...

I have to admit that there still have some grammatical and language-level typos
in nds32 target.  I am really sorry for that.  For a non-native speaker like
me, it takes more time to nitpick ALL the typos in the sentences.

I am thinking of closing this bug issue for now.  But it is ALWAYS WELCOME to
contribute patches as "obvious fix" if you notice any other typos in the nds32
source.  I will also have further discussion with contributor if the patches do
not fit my original words meaning.

Looking forward to seeing more patches. Thanks! :)

[Bug target/85665] Multiple typos in diagnostics

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85665

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |jasonwucj at gcc dot 
gnu.org

--- Comment #11 from Chung-Ju Wu  ---
(In reply to Jakub Jelinek from comment #9)
> Most of this is nds32 target related, so should be fixed by the
> corresponding maintainer.  As for two spaces after ., that is standard GCC
> convention and I believe it is used in many other spots.  I'll handle the
> ipa-devirt.c issue.

Thanks for the reminder.  I will deal with nds32 part to fix typos. :)

[Bug target/86798] nds32 port needs updating for CVE-2017-5753

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86798

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Chung-Ju Wu  ---
Fixed on the trunk.

[Bug target/86772] [meta-bug] tracking port status for CVE-2017-5753

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86772
Bug 86772 depends on bug 86798, which changed state.

Bug 86798 Summary: nds32 port needs updating for CVE-2017-5753
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86798

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

[Bug target/86798] nds32 port needs updating for CVE-2017-5753

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86798

--- Comment #2 from Chung-Ju Wu  ---
Author: jasonwucj
Date: Sat Sep 22 12:30:50 2018
New Revision: 264503

URL: https://gcc.gnu.org/viewcvs?rev=264503=gcc=rev
Log:
PR target/86798
* config/nds32/nds32.c (TARGET_HAVE_SPECULATION_SAFE_VALUE):
Define to speculation_safe_value_not_needed.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/nds32/nds32.c

[Bug target/86798] nds32 port needs updating for CVE-2017-5753

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86798

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2018-08-03
   Assignee|unassigned at gcc dot gnu.org  |jasonwucj at gcc dot 
gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Chung-Ju Wu  ---
(In reply to Richard Earnshaw from comment #0)
> The nds32 port needs updating for this CVE.  See the linked meta bug for
> details of possible actions required.

Thanks for the reminder.
I will check bug 86772 and then update nds32 port soon. :)

[Bug target/79928] nds32: misspelled diagnostic: not support -fpic

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79928

Chung-Ju Wu  changed:

   What|Removed |Added

 CC||jasonwucj at gcc dot gnu.org

--- Comment #3 from Chung-Ju Wu  ---
(In reply to Martin Sebor from comment #1)
> I'm pretty sure it's no joke, just a mistake.  Let me suggest the following
> wording/patch:
> 
> diff --git a/gcc/config/nds32/nds32.c b/gcc/config/nds32/nds32.c
> index 9313712..705d223 100644
> --- a/gcc/config/nds32/nds32.c
> +++ b/gcc/config/nds32/nds32.c
> @@ -2704,7 +2704,7 @@ nds32_option_override (void)
>  
>/* Currently, we don't support PIC code generation yet.  */
>if (flag_pic)
> -sorry ("not support -fpic");
> +sorry ("position-independent code not supported");
>  }

Hi, Martin & Roland,

Yes, it was indeed a mistake.
Thank both of you to point out this grammar issue.

The patch that Martin provided is OK on mailing list.
Thank you so much. :)


Best regards,
jasonwucj

[Bug target/70668] nds32-elf toolchain fails to compile on OSX

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70668

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Chung-Ju Wu  ---
(In reply to Segher Boessenkool from comment #7)
> Fixed on trunk, backports pending.

Eventually I decided to backport it to gcc-5 and gcc-6 branches.
Thanks all the comments above. :)

Set status as RESOLVED-FIXED.

[Bug target/70668] nds32-elf toolchain fails to compile on OSX

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70668

--- Comment #11 from Chung-Ju Wu  ---
Author: jasonwucj
Date: Tue Jan 10 04:23:35 2017
New Revision: 244258

URL: https://gcc.gnu.org/viewcvs?rev=244258=gcc=rev
Log:
Fix PR70668.

Backport from mainline
2016-04-28  Segher Boessenkool  

PR target/70668
* config/nds32/nds32.md (casesi): Don't access the operands array
out of bounds.

Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/config/nds32/nds32.md

[Bug target/70668] nds32-elf toolchain fails to compile on OSX

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70668

--- Comment #10 from Chung-Ju Wu  ---
Author: jasonwucj
Date: Tue Jan 10 04:18:11 2017
New Revision: 244257

URL: https://gcc.gnu.org/viewcvs?rev=244257=gcc=rev
Log:
Fix PR70668.

Backport from mainline
2016-04-28  Segher Boessenkool  

PR target/70668
* config/nds32/nds32.md (casesi): Don't access the operands array
out of bounds.

Modified:
branches/gcc-6-branch/gcc/ChangeLog
branches/gcc-6-branch/gcc/config/nds32/nds32.md

[Bug rtl-optimization/65827] LRA use smaller reg class than original reg for reload and it spill fail if reg class no hard reg available

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65827

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jasonwucj at gcc dot gnu.org
 Resolution|--- |FIXED

--- Comment #2 from Chung-Ju Wu  ---
(In reply to Andrew Pinski from comment #1)
> This might have been fixed already.

Thanks to reminder. :)
Yes, after I try this PR on trunk, the problem no longer exist.

Target:
  nds32le-elf
Configure option:
  -target=nds32le-elf
  --enable-languages=c
  --enable-checking=yes
  --disable-multilib
Testcase:
  gcc.c-torture/execute/pr65427.c
GCC version:
  gcc version 7.0.0 20170101 (experimental) (GCC)

So I think the status can be set as RESOLVED-FIXED.

[Bug target/70668] nds32-elf toolchain fails to compile on OSX

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70668

Chung-Ju Wu  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jakub at gcc dot gnu.org,
   ||jasonwucj at gcc dot gnu.org,
   ||law at redhat dot com,
   ||rguenth at gcc dot gnu.org
   Assignee|unassigned at gcc dot gnu.org  |jasonwucj at gcc dot 
gnu.org
   Target Milestone|--- |7.0

--- Comment #8 from Chung-Ju Wu  ---
(In reply to Segher Boessenkool from comment #7)
> Fixed on trunk, backports pending.

https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01862.html

Thank you for the patch to fix this issue.
Sorry I was busy on other stuff and didn't notice your mail last month.
I appreciate Jeff to help approve the patch. :)

I think this patch is also OK for gcc-5 and gcc-6 branches.

By the way, I guess this issue also appears on gcc-4.9 branch.
But I am not sure whether 4.9 branch is closed or not.
Maybe we need some comments from release managers.

Jakub/Richard, would you give us some comments? :)

[Bug target/64217] LRA: generate wrong liveness info after r217947 for clobber in jump_insn

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64217

--- Comment #3 from Chung-Ju Wu jasonwucj at gcc dot gnu.org ---
Author: jasonwucj
Date: Tue Dec 16 06:22:35 2014
New Revision: 218774

URL: https://gcc.gnu.org/viewcvs?rev=218774root=gccview=rev
Log:
PR target/64217
* config/nds32/nds32.md (casesi_internal): Add '=r' for clobber
register constraint.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/nds32/nds32.md

[Bug target/64217] LRA: generate wrong liveness info after r217947 for clobber in jump_insn

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64217

Chung-Ju Wu jasonwucj at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Chung-Ju Wu jasonwucj at gcc dot gnu.org ---
Fixed.

[Bug target/64217] LRA: generate wrong liveness info after r217947 for clobber in jump_insn

[jasonwucj at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64217

Chung-Ju Wu jasonwucj at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2014-12-12
 CC||jasonwucj at gcc dot gnu.org
  Component|rtl-optimization|target
   Assignee|unassigned at gcc dot gnu.org  |jasonwucj at gcc dot 
gnu.org
 Ever confirmed|0   |1

--- Comment #2 from Chung-Ju Wu jasonwucj at gcc dot gnu.org ---
(In reply to Vladimir Makarov from comment #1)
 
 So I'd add at least '=' but it is better to add '=r' or '=some other
 register constraint' to solve the problem.
 

Thanks Kito for reporting this issue.

Also thanks Vladimir to help identify the root cause.
Sorry for that our wrong pattern makes LRA live range analysis confused.

I will have a patch to fix it soon.  Thanks both of you. :)