[Bug analyzer/114588] Analyzer buffer overflow ASCII art hardcodes "RED" and "GREEN" as the terminal colors
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 David Malcolm changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #4 from David Malcolm --- Should be fixed by the above commit.
[Bug analyzer/114588] Analyzer buffer overflow ASCII art hardcodes "RED" and "GREEN" as the terminal colors
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 --- Comment #3 from GCC Commits --- The master branch has been updated by David Malcolm : https://gcc.gnu.org/g:4b02dd48f531ea88587edd2b75b6e5243b4389e8 commit r14-9817-g4b02dd48f531ea88587edd2b75b6e5243b4389e8 Author: David Malcolm Date: Fri Apr 5 14:49:53 2024 -0400 analyzer: respect GCC_COLORS in out-of-bounds diagrams [PR114588] gcc/analyzer/ChangeLog: PR analyzer/114588 * access-diagram.cc (access_diagram_impl::access_diagram_impl): Replace hardcoded colors for valid_style and invalid_style with calls to text_art::get_style_from_color_cap_name. gcc/ChangeLog: PR analyzer/114588 * diagnostic-color.cc (color_dict): Add "valid" and "invalid" as color capability names. * doc/invoke.texi: Document them in description of GCC_COLORS. * text-art/style.cc: Include "diagnostic-color.h". (text_art::get_style_from_color_cap_name): New. * text-art/types.h (get_style_from_color_cap_name): New decl. Signed-off-by: David Malcolm
[Bug analyzer/114588] Analyzer buffer overflow ASCII art hardcodes "RED" and "GREEN" as the terminal colors
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org --- Comment #2 from Eric Gallager --- (In reply to Andrew Pinski from comment #1) > Confirmed. I should note that Red/Green is the opposite meaning in some > places than western cultures. That is Red is good and Green is bad. Most of > China is where that is true. > > See > https://graphicdesign.stackexchange.com/questions/6982/except-china-which- > country-will-use-red-for-up-and-green-for-down also. Japan, too, it's why the (chart with upwards trend) emoji uses red, and the (chart with downwards trend) emoji uses blue, because they were originally from Japan. Red = "heating up" (which is good for shares of a stock) and blue = "cooling off" (which is bad for shares of a stock)
[Bug analyzer/114588] Analyzer buffer overflow ASCII art hardcodes "RED" and "GREEN" as the terminal colors
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114588 --- Comment #1 from Andrew Pinski --- Confirmed. I should note that Red/Green is the opposite meaning in some places than western cultures. That is Red is good and Green is bad. Most of China is where that is true. See https://graphicdesign.stackexchange.com/questions/6982/except-china-which-country-will-use-red-for-up-and-green-for-down also.
