[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 Eric Botcazou changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from Eric Botcazou --- .
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 --- Comment #7 from Eric Botcazou --- Author: ebotcazou Date: Tue Jan 8 19:09:52 2019 New Revision: 267734 URL: https://gcc.gnu.org/viewcvs?rev=267734&root=gcc&view=rev Log: PR bootstrap/88721 * config/sparc/sparc.c (function_arg_slotno): Set *PPREGNO & *PPADDING to -1 on entry. PR debug/88723 * config/sparc/sparc.c (sparc_delegitimize_address): Deal with naked UNSPECs and UNSPEC_MOVE_GOTDATA specifically. Modified: trunk/gcc/ChangeLog trunk/gcc/config/sparc/sparc.c
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 --- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #5 from Eric Botcazou --- >> I've just successfully finished a sparc-sun-solaris2.11 with it: worked fine. > > Thanks, same for me but for some reason I didn't have the original failure. This is weird indeed: I've just successfully bootstrapped mainline as of r267652 without either patch.
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 Eric Botcazou changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |ebotcazou at gcc dot gnu.org --- Comment #5 from Eric Botcazou --- > I've just successfully finished a sparc-sun-solaris2.11 with it: worked fine. Thanks, same for me but for some reason I didn't have the original failure.
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 --- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE --- > --- Comment #3 from Eric Botcazou --- >> This patch allowed the bootstrap to finish. > > There are 3 callers of function_arg_slotno so we would potentially need to add > 6 initializations already. So I'd rather initialize pregno and ppadding at > the > beginning of the function if this works: > > enum mode_class mclass = GET_MODE_CLASS (mode); > > /* Silence warnings in the callers. */ > *pregno = -1; > *ppadding = -1; > > if (type && TREE_ADDRESSABLE (type)) > return -1; I've just successfully finished a sparc-sun-solaris2.11 with it: worked fine. Thanks. Rainer
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 --- Comment #3 from Eric Botcazou --- > This patch allowed the bootstrap to finish. There are 3 callers of function_arg_slotno so we would potentially need to add 6 initializations already. So I'd rather initialize pregno and ppadding at the beginning of the function if this works: enum mode_class mclass = GET_MODE_CLASS (mode); /* Silence warnings in the callers. */ *pregno = -1; *ppadding = -1; if (type && TREE_ADDRESSABLE (type)) return -1;
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 Eric Botcazou changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2019-01-07 Ever confirmed|0 |1 --- Comment #2 from Eric Botcazou --- Two false positives I think.
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 --- Comment #1 from Rainer Orth --- Created attachment 45354 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45354&action=edit Possible patch This patch allowed the bootstrap to finish.
[Bug bootstrap/88721] [9 regression] -Wmaybe-uninitialized warnings in sparc.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88721 Rainer Orth changed: What|Removed |Added Target Milestone|--- |9.0