[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread townsend at astro dot wisc.edu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

--- Comment #7 from Rich Townsend  ---
(In reply to Rich Townsend from comment #2)
> (In reply to Andrew Pinski from comment #1)
> > Dup.
> > 
> > *** This bug has been marked as a duplicate of bug 89864 ***
> 
> Are you sure? The discussion in 89864 indicates that the patch to fix this
> bug should be in the 9.1 release. Also, IIRC I don't see the bug when
> configuring without the --with-sysroot and --with-build-sysroot flags
> (although I'm just rechecking that now).

Yep, confirmed that configuring without those flags allows the compile to
complete.

Now going to try out the patch mentioned by Iain in #5.

(In reply to Rich Townsend from comment #6)
> (In reply to Rich Townsend from comment #2)
> > (In reply to Andrew Pinski from comment #1)
> > > Dup.
> > > 
> > > *** This bug has been marked as a duplicate of bug 89864 ***
> > 
> > Are you sure? The discussion in 89864 indicates that the patch to fix this
> > bug should be in the 9.1 release. Also, IIRC I don't see the bug when
> > configuring without the --with-sysroot and --with-build-sysroot flags
> > (although I'm just rechecking that now).
> 
> Yep, confirmed that configuring without those flags allows the compile to
> complete.
> 
> Now going to try out the patch mentioned by Iain in #5.

The patch successfully applied to the 9.1 release (with offsets), and the build
completed without hitch. Nice work, Iain!

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread townsend at astro dot wisc.edu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

--- Comment #6 from Rich Townsend  ---
(In reply to Rich Townsend from comment #2)
> (In reply to Andrew Pinski from comment #1)
> > Dup.
> > 
> > *** This bug has been marked as a duplicate of bug 89864 ***
> 
> Are you sure? The discussion in 89864 indicates that the patch to fix this
> bug should be in the 9.1 release. Also, IIRC I don't see the bug when
> configuring without the --with-sysroot and --with-build-sysroot flags
> (although I'm just rechecking that now).

Yep, confirmed that configuring without those flags allows the compile to
complete.

Now going to try out the patch mentioned by Iain in #5.

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

--- Comment #5 from Iain Sandoe  ---
(In reply to Rich Townsend from comment #0)
> I'm running into a bug building on OSX Mojave, which seems to be tied into
> the problems with _Atomic in Apple's system headers. The error itself is:

> /Users/townsend/devel/sdk2/build/gcc/configure CC=
> --build=x86_64-apple-darwin18.5.0 --prefix=/Applications/mesasdk-dev
> --with-gmp=/Applications/mesasdk-dev --with-mpfr=/Applications/mesasdk-dev
> --with-mpc=/Applications/mesasdk-dev --enable-languages=c,c++,fortran
> --disable-multilib --disable-nls --disable-libsanitizer --with-sysroot=/
> --with-build-sysroot=/Users/townsend/devel/sdk2/build/xcode
> 
> The messing around with --with-sysroot and --with-build-sysroot is so that
> the resulting compiler can be used on older OSX versions, without any
> undefined symbols cropping up. My understanding of these flags is that:

This part is a duplicate of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79885

there's an experimental patch at comment #10

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

--- Comment #4 from Iain Sandoe  ---
(In reply to Iain Sandoe from comment #3)
> (In reply to Rich Townsend from comment #2)
> > (In reply to Andrew Pinski from comment #1)
> > > Dup.
> > > 
> > > *** This bug has been marked as a duplicate of bug 89864 ***
> > 
> > Are you sure? The discussion in 89864 indicates that the patch to fix this
> > bug should be in the 9.1 release. Also, IIRC I don't see the bug when
> > configuring without the --with-sysroot and --with-build-sysroot flags
> > (although I'm just rechecking that now).
> 
> in the 9.2 release - but you can grab a snapshot from any time after it was
> applied.

scrub that - the change to fix the problem _is_ in 9.1 - there's a follow up
change that adjusts the testing only, that will be in 9.2.

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread iains at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

Iain Sandoe  changed:

   What|Removed |Added

 CC||iains at gcc dot gnu.org

--- Comment #3 from Iain Sandoe  ---
(In reply to Rich Townsend from comment #2)
> (In reply to Andrew Pinski from comment #1)
> > Dup.
> > 
> > *** This bug has been marked as a duplicate of bug 89864 ***
> 
> Are you sure? The discussion in 89864 indicates that the patch to fix this
> bug should be in the 9.1 release. Also, IIRC I don't see the bug when
> configuring without the --with-sysroot and --with-build-sysroot flags
> (although I'm just rechecking that now).

in the 9.2 release - but you can grab a snapshot from any time after it was
applied.

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread townsend at astro dot wisc.edu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

--- Comment #2 from Rich Townsend  ---
(In reply to Andrew Pinski from comment #1)
> Dup.
> 
> *** This bug has been marked as a duplicate of bug 89864 ***

Are you sure? The discussion in 89864 indicates that the patch to fix this bug
should be in the 9.1 release. Also, IIRC I don't see the bug when configuring
without the --with-sysroot and --with-build-sysroot flags (although I'm just
rechecking that now).

[Bug bootstrap/90558] '_Atomic does not name a type' error resurfaces when building with old headers on OSX Mojave

2019-05-21 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90558

Andrew Pinski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Andrew Pinski  ---
Dup.

*** This bug has been marked as a duplicate of bug 89864 ***